Skip to content

L
linux
Commit ffc60a42 authored by Linus Torvalds's avatar Linus Torvalds
Browse files
Options

Fix bogus debug code in usb/misc/cytherm.c 

Uncovered by recent cleanup of "dev_dbg()".
parent 3e924164
Show whitespace changes
Inline Side-by-side
Showing with 9 additions and 9 deletions
drivers/usb/misc/cytherm.c
View file @ ffc60a42
...@@ -119,12 +119,12 @@ static ssize_t set_brightness(struct device *dev, const char *buf, ...@@ -119,12 +119,12 @@ static ssize_t set_brightness(struct device *dev, const char *buf,
retval = vendor_command(cytherm->udev, WRITE_RAM, BRIGHTNESS, retval = vendor_command(cytherm->udev, WRITE_RAM, BRIGHTNESS,
cytherm->brightness, buffer, 8); cytherm->brightness, buffer, 8);
if (retval) if (retval)
dev_dbg(&led->udev->dev, "retval = %d\n", retval); dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
/* Inform C that we have changed the brightness setting */ /* Inform C that we have changed the brightness setting */
retval = vendor_command(cytherm->udev, WRITE_RAM, BRIGHTNESS_SEM, retval = vendor_command(cytherm->udev, WRITE_RAM, BRIGHTNESS_SEM,
0x01, buffer, 8); 0x01, buffer, 8);
if (retval) if (retval)
dev_dbg(&led->udev->dev, "retval = %d\n", retval); dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
kfree(buffer); kfree(buffer);
...@@ -158,13 +158,13 @@ static ssize_t show_temp(struct device *dev, char *buf) ...@@ -158,13 +158,13 @@ static ssize_t show_temp(struct device *dev, char *buf)
/* read temperature */ /* read temperature */
retval = vendor_command(cytherm->udev, READ_RAM, TEMP, 0, buffer, 8); retval = vendor_command(cytherm->udev, READ_RAM, TEMP, 0, buffer, 8);
if (retval) if (retval)
dev_dbg(&led->udev->dev, "retval = %d\n", retval); dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
temp = buffer[1]; temp = buffer[1];
/* read sign */ /* read sign */
retval = vendor_command(cytherm->udev, READ_RAM, SIGN, 0, buffer, 8); retval = vendor_command(cytherm->udev, READ_RAM, SIGN, 0, buffer, 8);
if (retval) if (retval)
dev_dbg(&led->udev->dev, "retval = %d\n", retval); dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
sign = buffer[1]; sign = buffer[1];
kfree(buffer); kfree(buffer);
...@@ -202,7 +202,7 @@ static ssize_t show_button(struct device *dev, char *buf) ...@@ -202,7 +202,7 @@ static ssize_t show_button(struct device *dev, char *buf)
/* check button */ /* check button */
retval = vendor_command(cytherm->udev, READ_RAM, BUTTON, 0, buffer, 8); retval = vendor_command(cytherm->udev, READ_RAM, BUTTON, 0, buffer, 8);
if (retval) if (retval)
dev_dbg(&led->udev->dev, "retval = %d\n", retval); dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
retval = buffer[1]; retval = buffer[1];
...@@ -239,7 +239,7 @@ static ssize_t show_port0(struct device *dev, char *buf) ...@@ -239,7 +239,7 @@ static ssize_t show_port0(struct device *dev, char *buf)
retval = vendor_command(cytherm->udev, READ_PORT, 0, 0, buffer, 8); retval = vendor_command(cytherm->udev, READ_PORT, 0, 0, buffer, 8);
if (retval) if (retval)
dev_dbg(&led->udev->dev, "retval = %d\n", retval); dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
retval = buffer[1]; retval = buffer[1];
...@@ -274,7 +274,7 @@ static ssize_t set_port0(struct device *dev, const char *buf, size_t count) ...@@ -274,7 +274,7 @@ static ssize_t set_port0(struct device *dev, const char *buf, size_t count)
retval = vendor_command(cytherm->udev, WRITE_PORT, 0, retval = vendor_command(cytherm->udev, WRITE_PORT, 0,
tmp, buffer, 8); tmp, buffer, 8);
if (retval) if (retval)
dev_dbg(&led->udev->dev, "retval = %d\n", retval); dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
kfree(buffer); kfree(buffer);
...@@ -299,7 +299,7 @@ static ssize_t show_port1(struct device *dev, char *buf) ...@@ -299,7 +299,7 @@ static ssize_t show_port1(struct device *dev, char *buf)
retval = vendor_command(cytherm->udev, READ_PORT, 1, 0, buffer, 8); retval = vendor_command(cytherm->udev, READ_PORT, 1, 0, buffer, 8);
if (retval) if (retval)
dev_dbg(&led->udev->dev, "retval = %d\n", retval); dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
retval = buffer[1]; retval = buffer[1];
...@@ -334,7 +334,7 @@ static ssize_t set_port1(struct device *dev, const char *buf, size_t count) ...@@ -334,7 +334,7 @@ static ssize_t set_port1(struct device *dev, const char *buf, size_t count)
retval = vendor_command(cytherm->udev, WRITE_PORT, 1, retval = vendor_command(cytherm->udev, WRITE_PORT, 1,
tmp, buffer, 8); tmp, buffer, 8);
if (retval) if (retval)
dev_dbg(&led->udev->dev, "retval = %d\n", retval); dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
kfree(buffer); kfree(buffer);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7