Fixed compiler warnings

Made stopping of slave more robust
Fixed tokudb test cases that gave different results between runs
Speed up some slow tokudb tests by adding begin ... commit


mysql-test/extra/rpl_tests/rpl_stop_slave.test:
  Ensure that slaves are properly synced before they are stopped.
  (Otherwise some tests results will be different between runs)
storage/innobase/buf/buf0buf.cc:
  Fixed compiler warning
storage/tokudb/mysql-test/tokudb/r/cluster_filter_unpack_varchar_and_int_hidden.result:
  Test case could be solved with index or range scan.
storage/tokudb/mysql-test/tokudb/t/cluster_filter_unpack_varchar_and_int_hidden.test:
  Test case could be solved with index or range scan.
storage/tokudb/mysql-test/tokudb_bugs/r/5733_innodb.result:
  Speed up test by adding begin...commit
storage/tokudb/mysql-test/tokudb_bugs/r/5733_tokudb.result:
  Speed up test by adding begin...commit
storage/tokudb/mysql-test/tokudb_bugs/t/5733_innodb.test:
  Speed up test by adding begin...commit
storage/tokudb/mysql-test/tokudb_bugs/t/5733_tokudb.test:
  Speed up test by adding begin...commit
storage/tokudb/mysql-test/tokudb_mariadb/r/compression.result:
  Added drop table (safety)
storage/tokudb/mysql-test/tokudb_mariadb/t/compression.test:
  Added drop table (safety)

mysql-test/extra/rpl_tests/rpl_stop_slave.test

@@ -59,3 +59,6 @@ source include/wait_for_slave_sql_to_stop.inc;
 connection slave;
 START SLAVE SQL_THREAD;
 source include/wait_for_slave_sql_to_start.inc;
+
+connection master;
+sync_slave_with_master;

storage/innobase/buf/buf0buf.cc

@@ -2436,7 +2436,7 @@ buf_page_get_gen(
 	ibool		must_read;
 	rw_lock_t*	hash_lock;
 	ib_mutex_t*	block_mutex;
-	buf_page_t*	hash_bpage;
+	buf_page_t*	hash_bpage  __attribute__((unused));
 	ulint		retries = 0;
 	buf_pool_t*	buf_pool = buf_pool_get(space, offset);
 

storage/tokudb/mysql-test/tokudb/r/cluster_filter_unpack_varchar_and_int_hidden.result

@@ -182,14 +182,14 @@ a	b	c	d	e	f
 3	30	200	2000	20000	200000
 explain select * from t1 where b > 0;
 id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
-1	SIMPLE	t1	index	b	b	NULL	NULL	NULL;	Using where; Using index
+1	SIMPLE	t1	index_or_range	b	b	NULL	NULL	NULL;	Using where; Using index_or_range
 select * from t1 where b > 0;
 a	b	c	d	e	f
 2	20	100	1000	10000	100000
 3	30	200	2000	20000	200000
 explain select * from t1 where d > "0";
 id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
-1	SIMPLE	t1	index	d	d	NULL	NULL	NULL;	Using where; Using index
+1	SIMPLE	t1	index_or_range	d	d	NULL	NULL	NULL;	Using where; Using index_or_range
 select * from t1 where d > "0";
 a	b	c	d	e	f
 2	20	100	1000	10000	100000

storage/tokudb/mysql-test/tokudb/t/cluster_filter_unpack_varchar_and_int_hidden.test

@@ -83,10 +83,12 @@ explain select * from t1;
 select * from t1;
 
 --replace_column 7 NULL 9 NULL;
+--replace_result index index_or_range range index_or_range
 explain select * from t1 where b > 0;
 select * from t1 where b > 0;
 
 --replace_column 7 NULL 9 NULL;
+--replace_result index index_or_range range index_or_range
 explain select * from t1 where d > "0";
 select * from t1 where d > "0";
 

storage/tokudb/mysql-test/tokudb_bugs/r/5733_innodb.result

 drop table if exists t;
 set default_storage_engine='innodb';
 create table t (id bigint primary key, x bigint not null);
+begin;
 insert into t values (0,0);
 insert into t values (1,0);
 insert into t values (2,0);
@@ -10001,6 +10002,7 @@ insert into t values (9996,0);
 insert into t values (9997,0);
 insert into t values (9998,0);
 insert into t values (9999,0);
+commit;
 explain select id from t where id>0 limit 10;
 id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
 1	SIMPLE	t	range	PRIMARY	PRIMARY	8	NULL	#	Using where; Using index

storage/tokudb/mysql-test/tokudb_bugs/r/5733_tokudb.result

 drop table if exists t;
 set default_storage_engine='tokudb';
 create table t (id bigint primary key, x bigint not null);
+begin;
 insert into t values (0,0);
 insert into t values (1,0);
 insert into t values (2,0);
@@ -10001,9 +10002,10 @@ insert into t values (9996,0);
 insert into t values (9997,0);
 insert into t values (9998,0);
 insert into t values (9999,0);
+commit;
 explain select id from t where id>0 limit 10;
 id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
-1	SIMPLE	t	range	PRIMARY	PRIMARY	8	NULL	#	Using where; Using index
+1	SIMPLE	t	index_or_range	PRIMARY	PRIMARY	8	NULL	#	Using where; Using index_or_range
 explain select * from t where id>0 limit 10;
 id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
 1	SIMPLE	t	range	PRIMARY	PRIMARY	8	NULL	#	Using where

storage/tokudb/mysql-test/tokudb_bugs/t/5733_innodb.test

@@ -11,12 +11,14 @@ set default_storage_engine='innodb';
 
 create table t (id bigint primary key, x bigint not null);
 
+begin;
 let $i=0;
 let $n=10000;
 while ($i < $n) {
       eval insert into t values ($i,0);
       inc $i;
 }
+commit;
 
 replace_column 9 #;
 explain select id from t where id>0 limit 10;

storage/tokudb/mysql-test/tokudb_bugs/t/5733_tokudb.test

@@ -11,14 +11,18 @@ set default_storage_engine='tokudb';
 
 create table t (id bigint primary key, x bigint not null);
 
+begin;
 let $i=0;
 let $n=10000;
 while ($i < $n) {
       eval insert into t values ($i,0);
       inc $i;
 }
+commit;
 
+# TokuDB may do index or range scan on this. Both are ok
 replace_column 9 #;
+--replace_result index index_or_range range index_or_range
 explain select id from t where id>0 limit 10;
 
 replace_column 9 #;

storage/tokudb/mysql-test/tokudb_mariadb/r/compression.result

+drop table if exists t1,t2,t3,t4,t5,t6;
 create table t1 (a text) engine=tokudb compression=tokudb_uncompressed;
 create table t2 (a text) engine=tokudb compression=tokudb_zlib;
 create table t3 (a text) engine=tokudb compression=tokudb_quicklz;

storage/tokudb/mysql-test/tokudb_mariadb/t/compression.test

+#
+# Initial cleanup from previous tests
+#
+--disable_warnings
+drop table if exists t1,t2,t3,t4,t5,t6;
+--enable_warnings
+
 create table t1 (a text) engine=tokudb compression=tokudb_uncompressed;
 create table t2 (a text) engine=tokudb compression=tokudb_zlib;
 create table t3 (a text) engine=tokudb compression=tokudb_quicklz;