Commit 3a4b8879 authored by Jan Lindström's avatar Jan Lindström

Set index page page compression on by default and remove innodb_trim_pct

as it is not used/implemented.
parent d64fa1d6
...@@ -16786,15 +16786,17 @@ static MYSQL_SYSVAR_BOOL(trx_purge_view_update_only_debug, ...@@ -16786,15 +16786,17 @@ static MYSQL_SYSVAR_BOOL(trx_purge_view_update_only_debug,
NULL, NULL, FALSE); NULL, NULL, FALSE);
#endif /* UNIV_DEBUG */ #endif /* UNIV_DEBUG */
/*
static MYSQL_SYSVAR_LONG(trim_pct, srv_trim_pct, static MYSQL_SYSVAR_LONG(trim_pct, srv_trim_pct,
PLUGIN_VAR_OPCMDARG , PLUGIN_VAR_OPCMDARG ,
"How many percent of compressed pages should be trimmed", "How many percent of compressed pages should be trimmed",
NULL, NULL, 100, 0, 100, 0); NULL, NULL, 100, 0, 100, 0);
*/
static MYSQL_SYSVAR_BOOL(compress_index_pages, srv_page_compress_index_pages, static MYSQL_SYSVAR_BOOL(compress_index_pages, srv_page_compress_index_pages,
PLUGIN_VAR_OPCMDARG, PLUGIN_VAR_OPCMDARG,
"Use page compression for only index pages.", "Use page compression for only index pages. Default TRUE.",
NULL, NULL, FALSE); NULL, NULL, TRUE);
static MYSQL_SYSVAR_BOOL(use_trim, srv_use_trim, static MYSQL_SYSVAR_BOOL(use_trim, srv_use_trim,
PLUGIN_VAR_OPCMDARG, PLUGIN_VAR_OPCMDARG,
...@@ -16974,7 +16976,7 @@ static struct st_mysql_sys_var* innobase_system_variables[]= { ...@@ -16974,7 +16976,7 @@ static struct st_mysql_sys_var* innobase_system_variables[]= {
MYSQL_SYSVAR(limit_optimistic_insert_debug), MYSQL_SYSVAR(limit_optimistic_insert_debug),
MYSQL_SYSVAR(trx_purge_view_update_only_debug), MYSQL_SYSVAR(trx_purge_view_update_only_debug),
#endif /* UNIV_DEBUG */ #endif /* UNIV_DEBUG */
MYSQL_SYSVAR(trim_pct), // MYSQL_SYSVAR(trim_pct),
MYSQL_SYSVAR(compress_index_pages), MYSQL_SYSVAR(compress_index_pages),
MYSQL_SYSVAR(use_trim), MYSQL_SYSVAR(use_trim),
#ifdef HAVE_LZ4 #ifdef HAVE_LZ4
......
...@@ -148,7 +148,7 @@ UNIV_INTERN my_bool srv_use_native_aio = TRUE; ...@@ -148,7 +148,7 @@ UNIV_INTERN my_bool srv_use_native_aio = TRUE;
/* If this flag is TRUE, then we will use page compression /* If this flag is TRUE, then we will use page compression
only for index pages */ only for index pages */
UNIV_INTERN my_bool srv_page_compress_index_pages = FALSE; UNIV_INTERN my_bool srv_page_compress_index_pages = TRUE;
UNIV_INTERN long srv_trim_pct = 100; UNIV_INTERN long srv_trim_pct = 100;
/* If this flag is TRUE, then we will use fallocate(PUCH_HOLE) /* If this flag is TRUE, then we will use fallocate(PUCH_HOLE)
to the pages */ to the pages */
......
...@@ -17934,10 +17934,12 @@ static MYSQL_SYSVAR_BOOL(use_stacktrace, srv_use_stacktrace, ...@@ -17934,10 +17934,12 @@ static MYSQL_SYSVAR_BOOL(use_stacktrace, srv_use_stacktrace,
"Print stacktrace on long semaphore wait (off by default supported only on linux)", "Print stacktrace on long semaphore wait (off by default supported only on linux)",
NULL, NULL, FALSE); NULL, NULL, FALSE);
/*
static MYSQL_SYSVAR_LONG(trim_pct, srv_trim_pct, static MYSQL_SYSVAR_LONG(trim_pct, srv_trim_pct,
PLUGIN_VAR_OPCMDARG , PLUGIN_VAR_OPCMDARG ,
"How many percent of compressed pages should be trimmed", "How many percent of compressed pages should be trimmed",
NULL, NULL, 100, 0, 100, 0); NULL, NULL, 100, 0, 100, 0);
*/
static MYSQL_SYSVAR_UINT(compression_level, page_zip_level, static MYSQL_SYSVAR_UINT(compression_level, page_zip_level,
PLUGIN_VAR_RQCMDARG, PLUGIN_VAR_RQCMDARG,
...@@ -17947,8 +17949,8 @@ static MYSQL_SYSVAR_UINT(compression_level, page_zip_level, ...@@ -17947,8 +17949,8 @@ static MYSQL_SYSVAR_UINT(compression_level, page_zip_level,
static MYSQL_SYSVAR_BOOL(compress_index_pages, srv_page_compress_index_pages, static MYSQL_SYSVAR_BOOL(compress_index_pages, srv_page_compress_index_pages,
PLUGIN_VAR_OPCMDARG, PLUGIN_VAR_OPCMDARG,
"Use page compression for only index pages.", "Use page compression for only index pages. Default TRUE.",
NULL, NULL, FALSE); NULL, NULL, TRUE);
static MYSQL_SYSVAR_BOOL(use_trim, srv_use_trim, static MYSQL_SYSVAR_BOOL(use_trim, srv_use_trim,
PLUGIN_VAR_OPCMDARG, PLUGIN_VAR_OPCMDARG,
...@@ -18166,7 +18168,7 @@ static struct st_mysql_sys_var* innobase_system_variables[]= { ...@@ -18166,7 +18168,7 @@ static struct st_mysql_sys_var* innobase_system_variables[]= {
MYSQL_SYSVAR(fake_changes), MYSQL_SYSVAR(fake_changes),
MYSQL_SYSVAR(locking_fake_changes), MYSQL_SYSVAR(locking_fake_changes),
MYSQL_SYSVAR(use_stacktrace), MYSQL_SYSVAR(use_stacktrace),
MYSQL_SYSVAR(trim_pct), // MYSQL_SYSVAR(trim_pct),
MYSQL_SYSVAR(compress_index_pages), MYSQL_SYSVAR(compress_index_pages),
MYSQL_SYSVAR(use_trim), MYSQL_SYSVAR(use_trim),
#ifdef HAVE_LZ4 #ifdef HAVE_LZ4
......
...@@ -163,7 +163,7 @@ UNIV_INTERN my_bool srv_use_native_aio = TRUE; ...@@ -163,7 +163,7 @@ UNIV_INTERN my_bool srv_use_native_aio = TRUE;
/* If this flag is TRUE, then we will use page compression /* If this flag is TRUE, then we will use page compression
only for index pages */ only for index pages */
UNIV_INTERN my_bool srv_page_compress_index_pages = FALSE; UNIV_INTERN my_bool srv_page_compress_index_pages = TRUE;
UNIV_INTERN long srv_trim_pct = 100; UNIV_INTERN long srv_trim_pct = 100;
/* Default compression level if page compression is used and no compression /* Default compression level if page compression is used and no compression
level is set for the table*/ level is set for the table*/
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment