Bug#14399148 INNODB TABLES UNDER LOAD PRODUCE DUPLICATE COPIES OF ROWS

IN QUERIES

This bug was caused by an incorrect fix of
Bug#13807811 BTR_PCUR_RESTORE_POSITION() CAN SKIP A RECORD

There was nothing wrong with btr_pcur_restore_position(), but with the
use of it in the table scan during index creation.

rb:1206 approved by Jimmy Yang

storage/innobase/btr/btr0pcur.c

@@ -312,10 +312,10 @@ btr_pcur_restore_position(
 	/* Restore the old search mode */
 	cursor->search_mode = old_mode;
 
-	if (btr_pcur_is_on_user_rec(cursor, mtr)) {
 	switch (cursor->rel_pos) {
 	case BTR_PCUR_ON:
-			if (!cmp_dtuple_rec(
+		if (btr_pcur_is_on_user_rec(cursor, mtr)
+		    && !cmp_dtuple_rec(
 			    tuple, btr_pcur_get_rec(cursor),
 			    rec_get_offsets(btr_pcur_get_rec(cursor),
 					    index, NULL,
@@ -338,20 +338,15 @@ btr_pcur_restore_position(
 
 			return(TRUE);
 		}
-
-			break;
+#ifdef UNIV_DEBUG
+		/* fall through */
 	case BTR_PCUR_BEFORE:
-			page_cur_move_to_next(btr_pcur_get_page_cur(cursor));
-			break;
 	case BTR_PCUR_AFTER:
-			page_cur_move_to_prev(btr_pcur_get_page_cur(cursor));
 		break;
-#ifdef UNIV_DEBUG
 	default:
 		ut_error;
 #endif /* UNIV_DEBUG */
 	}
-	}
 
 	mem_heap_free(heap);
 

storage/innodb_plugin/ChangeLog

+2012-08-07	The InnoDB Team
+
+	* btr/btr0pcur.c, row/row0merge.c:
+	Fix Bug#14399148 INNODB TABLES UNDER LOAD PRODUCE DUPLICATE COPIES
+	OF ROWS IN QUERIES
+
 2012-03-15	The InnoDB Team
 
 	* fil/fil0fil.c, ibuf/ibuf0ibuf.c, include/fil0fil.h,

storage/innodb_plugin/btr/btr0pcur.c

@@ -336,10 +336,10 @@ btr_pcur_restore_position_func(
 	/* Restore the old search mode */
 	cursor->search_mode = old_mode;
 
-	if (btr_pcur_is_on_user_rec(cursor)) {
 	switch (cursor->rel_pos) {
 	case BTR_PCUR_ON:
-			if (!cmp_dtuple_rec(
+		if (btr_pcur_is_on_user_rec(cursor)
+		    && !cmp_dtuple_rec(
 			    tuple, btr_pcur_get_rec(cursor),
 			    rec_get_offsets(btr_pcur_get_rec(cursor),
 					    index, NULL,
@@ -361,20 +361,15 @@ btr_pcur_restore_position_func(
 
 			return(TRUE);
 		}
-
-			break;
+#ifdef UNIV_DEBUG
+		/* fall through */
 	case BTR_PCUR_BEFORE:
-			page_cur_move_to_next(btr_pcur_get_page_cur(cursor));
-			break;
 	case BTR_PCUR_AFTER:
-			page_cur_move_to_prev(btr_pcur_get_page_cur(cursor));
 		break;
-#ifdef UNIV_DEBUG
 	default:
 		ut_error;
 #endif /* UNIV_DEBUG */
 	}
-	}
 
 	mem_heap_free(heap);
 

storage/innodb_plugin/row/row0merge.c

@@ -1214,11 +1214,25 @@ row_merge_read_clustered_index(
 				goto err_exit;
 			}
 
+			/* Store the cursor position on the last user
+			record on the page. */
+			btr_pcur_move_to_prev_on_page(&pcur);
+			/* Leaf pages must never be empty, unless
+			this is the only page in the index tree. */
+			ut_ad(btr_pcur_is_on_user_rec(&pcur)
+			      || buf_block_get_page_no(
+				      btr_pcur_get_block(&pcur))
+			      == clust_index->page);
+
 			btr_pcur_store_position(&pcur, &mtr);
 			mtr_commit(&mtr);
 			mtr_start(&mtr);
+			/* Restore position on the record, or its
+			predecessor if the record was purged
+			meanwhile. */
 			btr_pcur_restore_position(BTR_SEARCH_LEAF,
 						  &pcur, &mtr);
+			/* Move to the successor of the original record. */
 			has_next = btr_pcur_move_to_next_user_rec(&pcur, &mtr);
 		}