Commit 5d5a4372 authored by Kirill Smelkov's avatar Kirill Smelkov

X UUID -> NID (NodeID)

parent ce27f975
...@@ -265,9 +265,9 @@ func (c *Client) talkMaster1(ctx context.Context) (err error) { ...@@ -265,9 +265,9 @@ func (c *Client) talkMaster1(ctx context.Context) (err error) {
// FIXME vvv dup from Storage.talkMaster1 // FIXME vvv dup from Storage.talkMaster1
// XXX -> node.Dial / node.DialMaster ? // XXX -> node.Dial / node.DialMaster ?
if accept.YourUUID != c.node.MyInfo.UUID { if accept.YourNID != c.node.MyInfo.NID {
log.Infof(ctx, "master told us to have uuid=%v", accept.YourUUID) log.Infof(ctx, "master told us to have nid=%v", accept.YourNID)
c.node.MyInfo.UUID = accept.YourUUID c.node.MyInfo.NID = accept.YourNID
} }
wg, ctx := errgroup.WithContext(ctx) // XXX -> xsync.WorkGroup wg, ctx := errgroup.WithContext(ctx) // XXX -> xsync.WorkGroup
...@@ -530,7 +530,7 @@ func (c *Client) Load(ctx context.Context, xid zodb.Xid) (buf *mem.Buf, serial z ...@@ -530,7 +530,7 @@ func (c *Client) Load(ctx context.Context, xid zodb.Xid) (buf *mem.Buf, serial z
storv := make([]*xneo.Node, 0, 1) storv := make([]*xneo.Node, 0, 1)
for _, cell := range c.node.PartTab.Get(xid.Oid) { for _, cell := range c.node.PartTab.Get(xid.Oid) {
if cell.Readable() { if cell.Readable() {
stor := c.node.NodeTab.Get(cell.UUID) stor := c.node.NodeTab.Get(cell.NID)
// this storage might not yet come up // this storage might not yet come up
if stor != nil && stor.State == proto.RUNNING { if stor != nil && stor.State == proto.RUNNING {
storv = append(storv, stor) storv = append(storv, stor)
......
...@@ -142,7 +142,7 @@ func (m *Master) Run(ctx context.Context, l xnet.Listener) (err error) { ...@@ -142,7 +142,7 @@ func (m *Master) Run(ctx context.Context, l xnet.Listener) (err error) {
m.node.MyInfo = proto.NodeInfo{ m.node.MyInfo = proto.NodeInfo{
Type: proto.MASTER, Type: proto.MASTER,
Addr: naddr, Addr: naddr,
UUID: m.allocUUID(proto.MASTER), NID: m.allocNID(proto.MASTER),
State: proto.RUNNING, State: proto.RUNNING,
IdTime: proto.IdTimeNone, // XXX ok? IdTime: proto.IdTimeNone, // XXX ok?
} }
...@@ -1038,7 +1038,7 @@ func (m *Master) identify(ctx context.Context, n nodeCome) (node *xneo.Node, res ...@@ -1038,7 +1038,7 @@ func (m *Master) identify(ctx context.Context, n nodeCome) (node *xneo.Node, res
// - NodeType valid // - NodeType valid
// - IdTime ? // - IdTime ?
uuid := n.idReq.UUID nid := n.idReq.NID
nodeType := n.idReq.NodeType nodeType := n.idReq.NodeType
err := func() *proto.Error { err := func() *proto.Error {
...@@ -1046,18 +1046,18 @@ func (m *Master) identify(ctx context.Context, n nodeCome) (node *xneo.Node, res ...@@ -1046,18 +1046,18 @@ func (m *Master) identify(ctx context.Context, n nodeCome) (node *xneo.Node, res
return &proto.Error{proto.PROTOCOL_ERROR, "cluster name mismatch"} return &proto.Error{proto.PROTOCOL_ERROR, "cluster name mismatch"}
} }
if uuid == 0 { if nid == 0 {
uuid = m.allocUUID(nodeType) nid = m.allocNID(nodeType)
} }
// XXX uuid < 0 (temporary) -> reallocate if conflict ? // XXX nid < 0 (temporary) -> reallocate if conflict ?
// XXX check uuid matches NodeType // XXX check nid matches NodeType
node = m.node.NodeTab.Get(uuid) node = m.node.NodeTab.Get(nid)
if node != nil { if node != nil {
// reject - uuid is already occupied by someone else // reject - nid is already occupied by someone else
// XXX check also for down state - it could be the same node reconnecting // XXX check also for down state - it could be the same node reconnecting
return &proto.Error{proto.PROTOCOL_ERROR, fmt.Sprintf("uuid %v already used by another node", uuid)} return &proto.Error{proto.PROTOCOL_ERROR, fmt.Sprintf("nid %v already used by another node", nid)}
} }
// accept only certain kind of nodes depending on .clusterState, e.g. // accept only certain kind of nodes depending on .clusterState, e.g.
...@@ -1079,18 +1079,18 @@ func (m *Master) identify(ctx context.Context, n nodeCome) (node *xneo.Node, res ...@@ -1079,18 +1079,18 @@ func (m *Master) identify(ctx context.Context, n nodeCome) (node *xneo.Node, res
return nil return nil
}() }()
subj := fmt.Sprintf("identify: %s (%s)", n.req.Link().RemoteAddr(), n.idReq.UUID) subj := fmt.Sprintf("identify: %s (%s)", n.req.Link().RemoteAddr(), n.idReq.NID)
if err != nil { if err != nil {
log.Infof(ctx, "%s: rejecting: %s", subj, err) log.Infof(ctx, "%s: rejecting: %s", subj, err)
return nil, err return nil, err
} }
log.Infof(ctx, "%s: accepting as %s", subj, uuid) log.Infof(ctx, "%s: accepting as %s", subj, nid)
accept := &proto.AcceptIdentification{ accept := &proto.AcceptIdentification{
NodeType: proto.MASTER, NodeType: proto.MASTER,
MyUUID: m.node.MyInfo.UUID, MyNID: m.node.MyInfo.NID,
YourUUID: uuid, YourNID: nid,
} }
// update nodeTab // update nodeTab
...@@ -1107,7 +1107,7 @@ func (m *Master) identify(ctx context.Context, n nodeCome) (node *xneo.Node, res ...@@ -1107,7 +1107,7 @@ func (m *Master) identify(ctx context.Context, n nodeCome) (node *xneo.Node, res
nodeInfo := proto.NodeInfo{ nodeInfo := proto.NodeInfo{
Type: nodeType, Type: nodeType,
Addr: n.idReq.Address, Addr: n.idReq.Address,
UUID: uuid, NID: nid,
State: nodeState, State: nodeState,
IdTime: proto.IdTime(m.monotime()), IdTime: proto.IdTime(m.monotime()),
} }
...@@ -1117,16 +1117,16 @@ func (m *Master) identify(ctx context.Context, n nodeCome) (node *xneo.Node, res ...@@ -1117,16 +1117,16 @@ func (m *Master) identify(ctx context.Context, n nodeCome) (node *xneo.Node, res
return node, accept return node, accept
} }
// allocUUID allocates new node uuid for a node of kind nodeType // allocNID allocates new node ID for a node of kind nodeType
// XXX it is bad idea for master to assign uuid to coming node // XXX it is bad idea for master to assign node ID to coming node
// -> better nodes generate really unique UUID themselves and always show with them // -> better nodes generate really unique UUID themselves and always show with them
func (m *Master) allocUUID(nodeType proto.NodeType) proto.NodeUUID { func (m *Master) allocNID(nodeType proto.NodeType) proto.NodeID {
for num := int32(1); num < 1<<24; num++ { for num := int32(1); num < 1<<24; num++ {
uuid := proto.UUID(nodeType, num) nid := proto.NID(nodeType, num)
if m.node.NodeTab.Get(uuid) == nil { if m.node.NodeTab.Get(nid) == nil {
return uuid return nid
} }
} }
panic("all uuid allocated ???") // XXX more robust ? panic("all nid allocated ???") // XXX more robust ?
} }
...@@ -74,7 +74,7 @@ func _TestMasterStorage(t0 *tEnv) { ...@@ -74,7 +74,7 @@ func _TestMasterStorage(t0 *tEnv) {
// TODO create C; C tries connect to master - rejected ("not yet operational") // TODO create C; C tries connect to master - rejected ("not yet operational")
// TODO test ID rejects (uuid already registered, ...) // TODO test ID rejects (nid already registered, ...)
// M <- start cmd // M <- start cmd
wg := xsync.NewWorkGroup(bg) wg := xsync.NewWorkGroup(bg)
...@@ -96,7 +96,7 @@ func _TestMasterStorage(t0 *tEnv) { ...@@ -96,7 +96,7 @@ func _TestMasterStorage(t0 *tEnv) {
PTid: 1, PTid: 1,
NumReplicas: 0, NumReplicas: 0,
RowList: []proto.RowInfo{ RowList: []proto.RowInfo{
{[]proto.CellInfo{{proto.UUID(proto.STORAGE, 1), proto.UP_TO_DATE}}}, {[]proto.CellInfo{{proto.NID(proto.STORAGE, 1), proto.UP_TO_DATE}}},
}, },
})) }))
...@@ -139,7 +139,7 @@ func _TestMasterStorage(t0 *tEnv) { ...@@ -139,7 +139,7 @@ func _TestMasterStorage(t0 *tEnv) {
tCM.Expect(netconnect("c:1", "m:3", "m:1")) tCM.Expect(netconnect("c:1", "m:3", "m:1"))
tCM.Expect(conntx("c:1", "m:3", 1, &proto.RequestIdentification{ tCM.Expect(conntx("c:1", "m:3", 1, &proto.RequestIdentification{
NodeType: proto.CLIENT, NodeType: proto.CLIENT,
UUID: 0, NID: 0,
Address: xnaddr(""), Address: xnaddr(""),
ClusterName: "abc1", ClusterName: "abc1",
IdTime: proto.IdTimeNone, IdTime: proto.IdTimeNone,
...@@ -151,8 +151,8 @@ func _TestMasterStorage(t0 *tEnv) { ...@@ -151,8 +151,8 @@ func _TestMasterStorage(t0 *tEnv) {
tCM.Expect(conntx("m:3", "c:1", 1, &proto.AcceptIdentification{ tCM.Expect(conntx("m:3", "c:1", 1, &proto.AcceptIdentification{
NodeType: proto.MASTER, NodeType: proto.MASTER,
MyUUID: proto.UUID(proto.MASTER, 1), MyNID: proto.NID(proto.MASTER, 1),
YourUUID: proto.UUID(proto.CLIENT, 1), YourNID: proto.NID(proto.CLIENT, 1),
})) }))
// C <- M NotifyNodeInformation C1,M1,S1 // C <- M NotifyNodeInformation C1,M1,S1
...@@ -169,7 +169,7 @@ func _TestMasterStorage(t0 *tEnv) { ...@@ -169,7 +169,7 @@ func _TestMasterStorage(t0 *tEnv) {
PTid: 1, PTid: 1,
NumReplicas: 0, NumReplicas: 0,
RowList: []proto.RowInfo{ RowList: []proto.RowInfo{
{[]proto.CellInfo{{proto.UUID(proto.STORAGE, 1), proto.UP_TO_DATE}}}, {[]proto.CellInfo{{proto.NID(proto.STORAGE, 1), proto.UP_TO_DATE}}},
}, },
})) }))
...@@ -220,7 +220,7 @@ func _TestMasterStorage(t0 *tEnv) { ...@@ -220,7 +220,7 @@ func _TestMasterStorage(t0 *tEnv) {
tCS.Expect(netconnect("c:2", "s:3", "s:1")) tCS.Expect(netconnect("c:2", "s:3", "s:1"))
tCS.Expect(conntx("c:2", "s:3", 1, &proto.RequestIdentification{ tCS.Expect(conntx("c:2", "s:3", 1, &proto.RequestIdentification{
NodeType: proto.CLIENT, NodeType: proto.CLIENT,
UUID: proto.UUID(proto.CLIENT, 1), NID: proto.NID(proto.CLIENT, 1),
Address: xnaddr(""), Address: xnaddr(""),
ClusterName: "abc1", ClusterName: "abc1",
IdTime: 0.02, IdTime: 0.02,
...@@ -230,8 +230,8 @@ func _TestMasterStorage(t0 *tEnv) { ...@@ -230,8 +230,8 @@ func _TestMasterStorage(t0 *tEnv) {
tCS.Expect(conntx("s:3", "c:2", 1, &proto.AcceptIdentification{ tCS.Expect(conntx("s:3", "c:2", 1, &proto.AcceptIdentification{
NodeType: proto.STORAGE, NodeType: proto.STORAGE,
MyUUID: proto.UUID(proto.STORAGE, 1), MyNID: proto.NID(proto.STORAGE, 1),
YourUUID: proto.UUID(proto.CLIENT, 1), YourNID: proto.NID(proto.CLIENT, 1),
})) }))
// ... -> GetObject(xid1) // ... -> GetObject(xid1)
......
...@@ -69,22 +69,22 @@ func (cs *ClusterState) Set(v ClusterState) { ...@@ -69,22 +69,22 @@ func (cs *ClusterState) Set(v ClusterState) {
// node type -> character representing it. // node type -> character representing it.
const nodeTypeChar = "SMCA" // NOTE neo/py does this out of sync with NodeType constants. const nodeTypeChar = "SMCA" // NOTE neo/py does this out of sync with NodeType constants.
// String returns string representation of a node uuid. // String returns string representation of a node ID.
// //
// It returns ex 'S1', 'M2', ... // It returns ex 'S1', 'M2', ...
func (nodeUUID NodeUUID) String() string { func (nid NodeID) String() string {
if nodeUUID == 0 { if nid == 0 {
return "?(0)0" return "?(0)0"
} }
num := nodeUUID & (1<<24 - 1) num := nid & (1<<24 - 1)
// XXX UUID_NAMESPACES description does not match neo/py code // XXX UUID_NAMESPACES description does not match neo/py code
//typ := nodeUUID >> 24 //typ := nid >> 24
//temp := typ&(1 << 7) != 0 //temp := typ&(1 << 7) != 0
//typ &= 1<<7 - 1 //typ &= 1<<7 - 1
//nodeType := typ >> 4 //nodeType := typ >> 4
typ := uint8(-int8(nodeUUID>>24)) >> 4 typ := uint8(-int8(nid>>24)) >> 4
if typ < 4 { if typ < 4 {
return fmt.Sprintf("%c%d", nodeTypeChar[typ], num) return fmt.Sprintf("%c%d", nodeTypeChar[typ], num)
...@@ -110,8 +110,8 @@ var nodeTypeNum = [...]int8{ ...@@ -110,8 +110,8 @@ var nodeTypeNum = [...]int8{
CLIENT: -0x20, CLIENT: -0x20,
ADMIN: -0x30, ADMIN: -0x30,
} }
// UUID creates node uuid from node type and number. // NID creates node ID from node type and number.
func UUID(typ NodeType, num int32) NodeUUID { func NID(typ NodeType, num int32) NodeID {
// XXX neo/py does not what UUID_NAMESPACES describes // XXX neo/py does not what UUID_NAMESPACES describes
/* /*
temp := uint32(0) temp := uint32(0)
...@@ -131,9 +131,9 @@ func UUID(typ NodeType, num int32) NodeUUID { ...@@ -131,9 +131,9 @@ func UUID(typ NodeType, num int32) NodeUUID {
panic("node number out of range") panic("node number out of range")
} }
//uuid := temp << (7 + 3*8) | uint32(typ) << (4 + 3*8) | uint32(num) //nid := temp << (7 + 3*8) | uint32(typ) << (4 + 3*8) | uint32(num)
uuid := uint32(uint8(typn))<<(3*8) | uint32(num) nid := uint32(uint8(typn))<<(3*8) | uint32(num)
return NodeUUID(uuid) return NodeID(nid)
} }
// ---------------------------------------- // ----------------------------------------
......
...@@ -89,7 +89,7 @@ const ( ...@@ -89,7 +89,7 @@ const (
// answerBit is set in message code in answer messages for compatibility with neo/py // answerBit is set in message code in answer messages for compatibility with neo/py
answerBit = 0x8000 answerBit = 0x8000
//INVALID_UUID UUID = 0 //INVALID_NID NID = 0
INVALID_TID zodb.Tid = 1<<64 - 1 // 0xffffffffffffffff INVALID_TID zodb.Tid = 1<<64 - 1 // 0xffffffffffffffff
INVALID_OID zodb.Oid = 1<<64 - 1 INVALID_OID zodb.Oid = 1<<64 - 1
...@@ -267,7 +267,7 @@ const ( ...@@ -267,7 +267,7 @@ const (
DISCARDED //short: D DISCARDED //short: D
) )
// NodeUUID is a node identifier, 4-bytes signed integer // NodeID is a node identifier, 4-bytes signed integer
// //
// High-order byte: // High-order byte:
// //
...@@ -276,17 +276,17 @@ const ( ...@@ -276,17 +276,17 @@ const (
// | +-+-+---------- node type // | +-+-+---------- node type
// +---------------- temporary if negative // +---------------- temporary if negative
// //
// UUID namespaces are required to prevent conflicts when the master generate // NID namespaces are required to prevent conflicts when the master generate
// new uuid before it knows uuid of existing storage nodes. So only the high // new nid before it knows nid of existing storage nodes. So only the high
// order bit is really important and the 31 other bits could be random. // order bit is really important and the 31 other bits could be random.
// Extra namespace information and non-randomness of 3 LOB help to read logs. // Extra namespace information and non-randomness of 3 LOB help to read logs.
// //
// 0 is invalid NodeUUID XXX correct? // 0 is invalid NodeID XXX correct?
// //
// TODO -> back to 16-bytes randomly generated UUID // TODO -> back to 16-bytes randomly generated node IDs
type NodeUUID int32 type NodeID int32
// TODO NodeType -> base NodeUUID // TODO NodeType -> base NodeID
// Address represents host:port network endpoint. // Address represents host:port network endpoint.
...@@ -377,14 +377,14 @@ func (t *IdTime) neoDecodeN(data []byte) (uint64, bool) { ...@@ -377,14 +377,14 @@ func (t *IdTime) neoDecodeN(data []byte) (uint64, bool) {
type NodeInfo struct { type NodeInfo struct {
Type NodeType Type NodeType
Addr Address // serving address Addr Address // serving address
UUID NodeUUID NID NodeID
State NodeState State NodeState
IdTime IdTime // XXX clarify semantic where it is used IdTime IdTime // XXX clarify semantic where it is used
} }
//neo:proto typeonly //neo:proto typeonly
type CellInfo struct { type CellInfo struct {
UUID NodeUUID NID NodeID
State CellState State CellState
} }
...@@ -412,7 +412,7 @@ type Error struct { ...@@ -412,7 +412,7 @@ type Error struct {
//neo:nodes * -> * //neo:nodes * -> *
type RequestIdentification struct { type RequestIdentification struct {
NodeType NodeType // XXX name NodeType NodeType // XXX name
UUID NodeUUID NID NodeID
Address Address // where requesting node is also accepting connections Address Address // where requesting node is also accepting connections
ClusterName string ClusterName string
IdTime IdTime IdTime IdTime
...@@ -424,8 +424,8 @@ type RequestIdentification struct { ...@@ -424,8 +424,8 @@ type RequestIdentification struct {
//neo:proto answer //neo:proto answer
type AcceptIdentification struct { type AcceptIdentification struct {
NodeType NodeType // XXX name NodeType NodeType // XXX name
MyUUID NodeUUID MyNID NodeID
YourUUID NodeUUID YourNID NodeID
} }
// Empty request used as network barrier. // Empty request used as network barrier.
...@@ -449,7 +449,7 @@ type PrimaryMaster struct { ...@@ -449,7 +449,7 @@ type PrimaryMaster struct {
} }
type AnswerPrimary struct { type AnswerPrimary struct {
PrimaryNodeUUID NodeUUID PrimaryNodeID NodeID
} }
// Notify peer that I'm not the primary master. Attach any extra information // Notify peer that I'm not the primary master. Attach any extra information
...@@ -457,7 +457,7 @@ type AnswerPrimary struct { ...@@ -457,7 +457,7 @@ type AnswerPrimary struct {
// //
//neo:nodes SM -> * //neo:nodes SM -> *
type NotPrimaryMaster struct { type NotPrimaryMaster struct {
Primary NodeUUID // XXX PSignedNull in py Primary NodeID // XXX PSignedNull in py
KnownMasterList []struct { KnownMasterList []struct {
Address Address
} }
...@@ -613,7 +613,7 @@ type AnswerBeginTransaction struct { ...@@ -613,7 +613,7 @@ type AnswerBeginTransaction struct {
//neo:nodes C -> M //neo:nodes C -> M
type FailedVote struct { type FailedVote struct {
Tid zodb.Tid Tid zodb.Tid
NodeList []NodeUUID NodeList []NodeID
// answer = Error // answer = Error
} }
...@@ -745,7 +745,7 @@ type AnswerStoreObject struct { ...@@ -745,7 +745,7 @@ type AnswerStoreObject struct {
//neo:nodes C -> S; C -> M -> S //neo:nodes C -> S; C -> M -> S
type AbortTransaction struct { type AbortTransaction struct {
Tid zodb.Tid Tid zodb.Tid
NodeList []NodeUUID // unused for * -> S NodeList []NodeID // unused for * -> S
} }
// Ask to store a transaction. Implies vote. // Ask to store a transaction. Implies vote.
...@@ -844,7 +844,7 @@ type AnswerObjectHistory struct { ...@@ -844,7 +844,7 @@ type AnswerObjectHistory struct {
type PartitionList struct { type PartitionList struct {
MinOffset uint32 // PNumber MinOffset uint32 // PNumber
MaxOffset uint32 // PNumber MaxOffset uint32 // PNumber
NodeUUID NodeUUID NodeID NodeID
} }
type AnswerPartitionList struct { type AnswerPartitionList struct {
...@@ -868,7 +868,7 @@ type AnswerNodeList struct { ...@@ -868,7 +868,7 @@ type AnswerNodeList struct {
// //
//neo:nodes ctl -> A -> M //neo:nodes ctl -> A -> M
type SetNodeState struct { type SetNodeState struct {
NodeUUID NodeID
NodeState NodeState
// answer = Error // answer = Error
...@@ -879,7 +879,7 @@ type SetNodeState struct { ...@@ -879,7 +879,7 @@ type SetNodeState struct {
// //
//neo:nodes ctl -> A -> M //neo:nodes ctl -> A -> M
type AddPendingNodes struct { type AddPendingNodes struct {
NodeList []NodeUUID NodeList []NodeID
// answer = Error // answer = Error
} }
...@@ -890,7 +890,7 @@ type AddPendingNodes struct { ...@@ -890,7 +890,7 @@ type AddPendingNodes struct {
//neo:nodes ctl -> A -> M //neo:nodes ctl -> A -> M
type TweakPartitionTable struct { type TweakPartitionTable struct {
DryRun bool DryRun bool
NodeList []NodeUUID NodeList []NodeID
// answer = Error // answer = Error
} }
...@@ -928,7 +928,7 @@ type repairFlags struct { ...@@ -928,7 +928,7 @@ type repairFlags struct {
// //
//neo:nodes ctl -> A -> M //neo:nodes ctl -> A -> M
type Repair struct { type Repair struct {
NodeList []NodeUUID NodeList []NodeID
repairFlags repairFlags
} }
...@@ -1020,7 +1020,7 @@ type AnswerPack struct { ...@@ -1020,7 +1020,7 @@ type AnswerPack struct {
// //
//neo:nodes ctl -> A -> M //neo:nodes ctl -> A -> M
type CheckReplicas struct { type CheckReplicas struct {
PartitionDict map[uint32]NodeUUID // partition -> source (PNumber) PartitionDict map[uint32]NodeID // partition -> source (PNumber)
MinTID zodb.Tid MinTID zodb.Tid
MaxTID zodb.Tid MaxTID zodb.Tid
...@@ -1087,7 +1087,7 @@ type AnswerCheckSerialRange struct { ...@@ -1087,7 +1087,7 @@ type AnswerCheckSerialRange struct {
//neo:nodes S -> M //neo:nodes S -> M
type PartitionCorrupted struct { type PartitionCorrupted struct {
Partition uint32 // PNumber Partition uint32 // PNumber
CellList []NodeUUID CellList []NodeID
} }
// Notify that node is ready to serve requests. // Notify that node is ready to serve requests.
......
...@@ -205,7 +205,7 @@ func TestMsgMarshal(t *testing.T) { ...@@ -205,7 +205,7 @@ func TestMsgMarshal(t *testing.T) {
hex("c408") + hex("0a0b0c0d0e0f0104"), hex("c408") + hex("0a0b0c0d0e0f0104"),
}, },
// PTid, [] (of [] of {UUID, CellState}) // PTid, [] (of [] of {NodeID, CellState})
{&AnswerPartitionTable{ {&AnswerPartitionTable{
PTid: 0x0102030405060708, PTid: 0x0102030405060708,
NumReplicas: 34, NumReplicas: 34,
...@@ -263,9 +263,9 @@ func TestMsgMarshal(t *testing.T) { ...@@ -263,9 +263,9 @@ func TestMsgMarshal(t *testing.T) {
hex("c408")+u64(8) + hex("93") + hex("c408")+u64(7) + hex("c408")+u64(1) + hex("c2"), hex("c408")+u64(8) + hex("93") + hex("c408")+u64(7) + hex("c408")+u64(1) + hex("c2"),
}, },
// map[uint32]UUID + trailing ... // map[uint32]NodeID + trailing ...
{&CheckReplicas{ {&CheckReplicas{
PartitionDict: map[uint32]NodeUUID{ PartitionDict: map[uint32]NodeID{
1: 7, 1: 7,
2: 9, 2: 9,
7: 3, 7: 3,
...@@ -295,7 +295,7 @@ func TestMsgMarshal(t *testing.T) { ...@@ -295,7 +295,7 @@ func TestMsgMarshal(t *testing.T) {
}, },
// uint32, []uint32 // uint32, []uint32
{&PartitionCorrupted{7, []NodeUUID{1, 3, 9, 4}}, {&PartitionCorrupted{7, []NodeID{1, 3, 9, 4}},
// N // N
u32(7) + u32(4) + u32(1) + u32(3) + u32(9) + u32(4), u32(7) + u32(4) + u32(1) + u32(3) + u32(9) + u32(4),
...@@ -329,7 +329,7 @@ func TestMsgMarshal(t *testing.T) { ...@@ -329,7 +329,7 @@ func TestMsgMarshal(t *testing.T) {
// IdTime, empty Address, int32 // IdTime, empty Address, int32
{&NotifyNodeInformation{1504466245.926185, []NodeInfo{ {&NotifyNodeInformation{1504466245.926185, []NodeInfo{
{CLIENT, Address{}, UUID(CLIENT, 1), RUNNING, 1504466245.925599}}}, {CLIENT, Address{}, NID(CLIENT, 1), RUNNING, 1504466245.925599}}},
// N // N
hex("41d66b15517b469d") + u32(1) + hex("41d66b15517b469d") + u32(1) +
u8(2) + u32(0) /* <- ø Address */ + hex("e0000001") + u8(2) + u8(2) + u32(0) /* <- ø Address */ + hex("e0000001") + u8(2) +
...@@ -425,8 +425,8 @@ func TestMsgDecodeLenOverflowN(t *testing.T) { ...@@ -425,8 +425,8 @@ func TestMsgDecodeLenOverflowN(t *testing.T) {
} }
} }
func TestUUID(t *testing.T) { func TestNID(t *testing.T) {
var testv = []struct{typ NodeType; num int32; uuid uint32; str string}{ var testv = []struct{typ NodeType; num int32; nid uint32; str string}{
{STORAGE, 1, 0x00000001, "S1"}, {STORAGE, 1, 0x00000001, "S1"},
{MASTER, 2, 0xf0000002, "M2"}, {MASTER, 2, 0xf0000002, "M2"},
{CLIENT, 3, 0xe0000003, "C3"}, {CLIENT, 3, 0xe0000003, "C3"},
...@@ -434,18 +434,18 @@ func TestUUID(t *testing.T) { ...@@ -434,18 +434,18 @@ func TestUUID(t *testing.T) {
} }
for _, tt := range testv { for _, tt := range testv {
uuid := UUID(tt.typ, tt.num) nid := NID(tt.typ, tt.num)
if uint32(uuid) != tt.uuid { if uint32(nid) != tt.nid {
t.Errorf("%v: uuid=%08x ; want %08x", tt, uuid, tt.uuid) t.Errorf("%v: nid=%08x ; want %08x", tt, nid, tt.nid)
} }
if uuids := uuid.String(); uuids != tt.str { if nids := nid.String(); nids != tt.str {
t.Errorf("%v: str(uuid): %q ; want %q", tt, uuids, tt.str) t.Errorf("%v: str(nid): %q ; want %q", tt, nids, tt.str)
} }
} }
} }
func TestUUIDDecode(t *testing.T) { func TestNIDDecode(t *testing.T) {
var testv = []struct{uuid uint32; str string}{ var testv = []struct{nid uint32; str string}{
{0, "?(0)0"}, {0, "?(0)0"},
{0x00000001, "S1"}, {0x00000001, "S1"},
{0xf0000002, "M2"}, {0xf0000002, "M2"},
...@@ -467,9 +467,9 @@ func TestUUIDDecode(t *testing.T) { ...@@ -467,9 +467,9 @@ func TestUUIDDecode(t *testing.T) {
} }
for _, tt := range testv { for _, tt := range testv {
str := NodeUUID(tt.uuid).String() str := NodeID(tt.nid).String()
if str != tt.str { if str != tt.str {
t.Errorf("%08x -> %q ; want %q", tt.uuid, str, tt.str) t.Errorf("%08x -> %q ; want %q", tt.nid, str, tt.str)
} }
} }
} }
...@@ -136,7 +136,7 @@ func (p *RequestIdentification) neoMsgEncodedLenN() int { ...@@ -136,7 +136,7 @@ func (p *RequestIdentification) neoMsgEncodedLenN() int {
func (p *RequestIdentification) neoMsgEncodeN(data []byte) { func (p *RequestIdentification) neoMsgEncodeN(data []byte) {
(data[0:])[0] = uint8(int8(p.NodeType)) (data[0:])[0] = uint8(int8(p.NodeType))
binary.BigEndian.PutUint32(data[1:], uint32(int32(p.UUID))) binary.BigEndian.PutUint32(data[1:], uint32(int32(p.NID)))
{ {
n := p.Address.neoEncodeN(data[5:]) n := p.Address.neoEncodeN(data[5:])
data = data[5+n:] data = data[5+n:]
...@@ -185,7 +185,7 @@ func (p *RequestIdentification) neoMsgDecodeN(data []byte) (int, error) { ...@@ -185,7 +185,7 @@ func (p *RequestIdentification) neoMsgDecodeN(data []byte) (int, error) {
goto overflow goto overflow
} }
p.NodeType = NodeType(int8((data[0 : 0+1])[0])) p.NodeType = NodeType(int8((data[0 : 0+1])[0]))
p.UUID = NodeUUID(int32(binary.BigEndian.Uint32(data[1 : 1+4]))) p.NID = NodeID(int32(binary.BigEndian.Uint32(data[1 : 1+4])))
data = data[5:] data = data[5:]
{ {
n, ok := p.Address.neoDecodeN(data) n, ok := p.Address.neoDecodeN(data)
...@@ -274,7 +274,7 @@ func (p *RequestIdentification) neoMsgEncodedLenM() int { ...@@ -274,7 +274,7 @@ func (p *RequestIdentification) neoMsgEncodedLenM() int {
a := &p.NewNID[i] a := &p.NewNID[i]
size += msgpack.Uint32Size((*a)) size += msgpack.Uint32Size((*a))
} }
return 14 + msgpack.Int32Size(int32(p.UUID)) + msgpack.BinHeadSize(len(p.Address.Host)) + len(p.Address.Host) + msgpack.Uint16Size(p.Address.Port) + msgpack.BinHeadSize(len(p.ClusterName)) + len(p.ClusterName) + msgpack.ArrayHeadSize(len(p.DevPath)) + msgpack.ArrayHeadSize(len(p.NewNID)) + size return 14 + msgpack.Int32Size(int32(p.NID)) + msgpack.BinHeadSize(len(p.Address.Host)) + len(p.Address.Host) + msgpack.Uint16Size(p.Address.Port) + msgpack.BinHeadSize(len(p.ClusterName)) + len(p.ClusterName) + msgpack.ArrayHeadSize(len(p.DevPath)) + msgpack.ArrayHeadSize(len(p.NewNID)) + size
} }
func (p *RequestIdentification) neoMsgEncodeM(data []byte) { func (p *RequestIdentification) neoMsgEncodeM(data []byte) {
...@@ -286,7 +286,7 @@ func (p *RequestIdentification) neoMsgEncodeM(data []byte) { ...@@ -286,7 +286,7 @@ func (p *RequestIdentification) neoMsgEncodeM(data []byte) {
} }
data[3] = byte(p.NodeType) data[3] = byte(p.NodeType)
{ {
n := msgpack.PutInt32(data[4:], int32(p.UUID)) n := msgpack.PutInt32(data[4:], int32(p.NID))
data = data[4+n:] data = data[4+n:]
} }
data[0] = byte(msgpack.FixArray_4 | 2) data[0] = byte(msgpack.FixArray_4 | 2)
...@@ -364,9 +364,9 @@ func (p *RequestIdentification) neoMsgDecodeM(data []byte) (int, error) { ...@@ -364,9 +364,9 @@ func (p *RequestIdentification) neoMsgDecodeM(data []byte) (int, error) {
{ {
v, tail, err := msgp.ReadInt32Bytes(data) v, tail, err := msgp.ReadInt32Bytes(data)
if err != nil { if err != nil {
return 0, mdecodeErr("RequestIdentification.UUID", err) return 0, mdecodeErr("RequestIdentification.NID", err)
} }
p.UUID = NodeUUID(v) p.NID = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -473,8 +473,8 @@ func (p *AcceptIdentification) neoMsgEncodedLenN() int { ...@@ -473,8 +473,8 @@ func (p *AcceptIdentification) neoMsgEncodedLenN() int {
func (p *AcceptIdentification) neoMsgEncodeN(data []byte) { func (p *AcceptIdentification) neoMsgEncodeN(data []byte) {
(data[0:])[0] = uint8(int8(p.NodeType)) (data[0:])[0] = uint8(int8(p.NodeType))
binary.BigEndian.PutUint32(data[1:], uint32(int32(p.MyUUID))) binary.BigEndian.PutUint32(data[1:], uint32(int32(p.MyNID)))
binary.BigEndian.PutUint32(data[5:], uint32(int32(p.YourUUID))) binary.BigEndian.PutUint32(data[5:], uint32(int32(p.YourNID)))
} }
func (p *AcceptIdentification) neoMsgDecodeN(data []byte) (int, error) { func (p *AcceptIdentification) neoMsgDecodeN(data []byte) (int, error) {
...@@ -482,8 +482,8 @@ func (p *AcceptIdentification) neoMsgDecodeN(data []byte) (int, error) { ...@@ -482,8 +482,8 @@ func (p *AcceptIdentification) neoMsgDecodeN(data []byte) (int, error) {
goto overflow goto overflow
} }
p.NodeType = NodeType(int8((data[0 : 0+1])[0])) p.NodeType = NodeType(int8((data[0 : 0+1])[0]))
p.MyUUID = NodeUUID(int32(binary.BigEndian.Uint32(data[1 : 1+4]))) p.MyNID = NodeID(int32(binary.BigEndian.Uint32(data[1 : 1+4])))
p.YourUUID = NodeUUID(int32(binary.BigEndian.Uint32(data[5 : 5+4]))) p.YourNID = NodeID(int32(binary.BigEndian.Uint32(data[5 : 5+4])))
return 9, nil return 9, nil
overflow: overflow:
...@@ -491,7 +491,7 @@ overflow: ...@@ -491,7 +491,7 @@ overflow:
} }
func (p *AcceptIdentification) neoMsgEncodedLenM() int { func (p *AcceptIdentification) neoMsgEncodedLenM() int {
return 4 + msgpack.Int32Size(int32(p.MyUUID)) + msgpack.Int32Size(int32(p.YourUUID)) return 4 + msgpack.Int32Size(int32(p.MyNID)) + msgpack.Int32Size(int32(p.YourNID))
} }
func (p *AcceptIdentification) neoMsgEncodeM(data []byte) { func (p *AcceptIdentification) neoMsgEncodeM(data []byte) {
...@@ -503,11 +503,11 @@ func (p *AcceptIdentification) neoMsgEncodeM(data []byte) { ...@@ -503,11 +503,11 @@ func (p *AcceptIdentification) neoMsgEncodeM(data []byte) {
} }
data[3] = byte(p.NodeType) data[3] = byte(p.NodeType)
{ {
n := msgpack.PutInt32(data[4:], int32(p.MyUUID)) n := msgpack.PutInt32(data[4:], int32(p.MyNID))
data = data[4+n:] data = data[4+n:]
} }
{ {
n := msgpack.PutInt32(data[0:], int32(p.YourUUID)) n := msgpack.PutInt32(data[0:], int32(p.YourNID))
data = data[0+n:] data = data[0+n:]
} }
} }
...@@ -537,18 +537,18 @@ func (p *AcceptIdentification) neoMsgDecodeM(data []byte) (int, error) { ...@@ -537,18 +537,18 @@ func (p *AcceptIdentification) neoMsgDecodeM(data []byte) (int, error) {
{ {
v, tail, err := msgp.ReadInt32Bytes(data) v, tail, err := msgp.ReadInt32Bytes(data)
if err != nil { if err != nil {
return 0, mdecodeErr("AcceptIdentification.MyUUID", err) return 0, mdecodeErr("AcceptIdentification.MyNID", err)
} }
p.MyUUID = NodeUUID(v) p.MyNID = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
{ {
v, tail, err := msgp.ReadInt32Bytes(data) v, tail, err := msgp.ReadInt32Bytes(data)
if err != nil { if err != nil {
return 0, mdecodeErr("AcceptIdentification.YourUUID", err) return 0, mdecodeErr("AcceptIdentification.YourNID", err)
} }
p.YourUUID = NodeUUID(v) p.YourNID = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -721,14 +721,14 @@ func (p *AnswerPrimary) neoMsgEncodedLenN() int { ...@@ -721,14 +721,14 @@ func (p *AnswerPrimary) neoMsgEncodedLenN() int {
} }
func (p *AnswerPrimary) neoMsgEncodeN(data []byte) { func (p *AnswerPrimary) neoMsgEncodeN(data []byte) {
binary.BigEndian.PutUint32(data[0:], uint32(int32(p.PrimaryNodeUUID))) binary.BigEndian.PutUint32(data[0:], uint32(int32(p.PrimaryNodeID)))
} }
func (p *AnswerPrimary) neoMsgDecodeN(data []byte) (int, error) { func (p *AnswerPrimary) neoMsgDecodeN(data []byte) (int, error) {
if len(data) < 4 { if len(data) < 4 {
goto overflow goto overflow
} }
p.PrimaryNodeUUID = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) p.PrimaryNodeID = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
return 4, nil return 4, nil
overflow: overflow:
...@@ -736,13 +736,13 @@ overflow: ...@@ -736,13 +736,13 @@ overflow:
} }
func (p *AnswerPrimary) neoMsgEncodedLenM() int { func (p *AnswerPrimary) neoMsgEncodedLenM() int {
return 1 + msgpack.Int32Size(int32(p.PrimaryNodeUUID)) return 1 + msgpack.Int32Size(int32(p.PrimaryNodeID))
} }
func (p *AnswerPrimary) neoMsgEncodeM(data []byte) { func (p *AnswerPrimary) neoMsgEncodeM(data []byte) {
data[0] = byte(msgpack.FixArray_4 | 1) data[0] = byte(msgpack.FixArray_4 | 1)
{ {
n := msgpack.PutInt32(data[1:], int32(p.PrimaryNodeUUID)) n := msgpack.PutInt32(data[1:], int32(p.PrimaryNodeID))
data = data[1+n:] data = data[1+n:]
} }
} }
...@@ -759,9 +759,9 @@ func (p *AnswerPrimary) neoMsgDecodeM(data []byte) (int, error) { ...@@ -759,9 +759,9 @@ func (p *AnswerPrimary) neoMsgDecodeM(data []byte) (int, error) {
{ {
v, tail, err := msgp.ReadInt32Bytes(data) v, tail, err := msgp.ReadInt32Bytes(data)
if err != nil { if err != nil {
return 0, mdecodeErr("AnswerPrimary.PrimaryNodeUUID", err) return 0, mdecodeErr("AnswerPrimary.PrimaryNodeID", err)
} }
p.PrimaryNodeUUID = NodeUUID(v) p.PrimaryNodeID = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -807,7 +807,7 @@ func (p *NotPrimaryMaster) neoMsgDecodeN(data []byte) (int, error) { ...@@ -807,7 +807,7 @@ func (p *NotPrimaryMaster) neoMsgDecodeN(data []byte) (int, error) {
if len(data) < 8 { if len(data) < 8 {
goto overflow goto overflow
} }
p.Primary = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) p.Primary = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
{ {
l := binary.BigEndian.Uint32(data[4 : 4+4]) l := binary.BigEndian.Uint32(data[4 : 4+4])
data = data[8:] data = data[8:]
...@@ -882,7 +882,7 @@ func (p *NotPrimaryMaster) neoMsgDecodeM(data []byte) (int, error) { ...@@ -882,7 +882,7 @@ func (p *NotPrimaryMaster) neoMsgDecodeM(data []byte) (int, error) {
if err != nil { if err != nil {
return 0, mdecodeErr("NotPrimaryMaster.Primary", err) return 0, mdecodeErr("NotPrimaryMaster.Primary", err)
} }
p.Primary = NodeUUID(v) p.Primary = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -964,7 +964,7 @@ func (p *NotifyNodeInformation) neoMsgEncodeN(data []byte) { ...@@ -964,7 +964,7 @@ func (p *NotifyNodeInformation) neoMsgEncodeN(data []byte) {
n := (*a).Addr.neoEncodeN(data[1:]) n := (*a).Addr.neoEncodeN(data[1:])
data = data[1+n:] data = data[1+n:]
} }
binary.BigEndian.PutUint32(data[0:], uint32(int32((*a).UUID))) binary.BigEndian.PutUint32(data[0:], uint32(int32((*a).NID)))
(data[4:])[0] = uint8(int8((*a).State)) (data[4:])[0] = uint8(int8((*a).State))
{ {
n := (*a).IdTime.neoEncodeN(data[5:]) n := (*a).IdTime.neoEncodeN(data[5:])
...@@ -1009,7 +1009,7 @@ func (p *NotifyNodeInformation) neoMsgDecodeN(data []byte) (int, error) { ...@@ -1009,7 +1009,7 @@ func (p *NotifyNodeInformation) neoMsgDecodeN(data []byte) (int, error) {
if len(data) < 5 { if len(data) < 5 {
goto overflow goto overflow
} }
(*a).UUID = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) (*a).NID = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
(*a).State = NodeState(int8((data[4 : 4+1])[0])) (*a).State = NodeState(int8((data[4 : 4+1])[0]))
data = data[5:] data = data[5:]
{ {
...@@ -1033,7 +1033,7 @@ func (p *NotifyNodeInformation) neoMsgEncodedLenM() int { ...@@ -1033,7 +1033,7 @@ func (p *NotifyNodeInformation) neoMsgEncodedLenM() int {
var size int var size int
for i := 0; i < len(p.NodeList); i++ { for i := 0; i < len(p.NodeList); i++ {
a := &p.NodeList[i] a := &p.NodeList[i]
size += msgpack.BinHeadSize(len((*a).Addr.Host)) + len((*a).Addr.Host) + msgpack.Uint16Size((*a).Addr.Port) + msgpack.Int32Size(int32((*a).UUID)) size += msgpack.BinHeadSize(len((*a).Addr.Host)) + len((*a).Addr.Host) + msgpack.Uint16Size((*a).Addr.Port) + msgpack.Int32Size(int32((*a).NID))
} }
return 10 + msgpack.ArrayHeadSize(len(p.NodeList)) + len(p.NodeList)*17 + size return 10 + msgpack.ArrayHeadSize(len(p.NodeList)) + len(p.NodeList)*17 + size
} }
...@@ -1068,7 +1068,7 @@ func (p *NotifyNodeInformation) neoMsgEncodeM(data []byte) { ...@@ -1068,7 +1068,7 @@ func (p *NotifyNodeInformation) neoMsgEncodeM(data []byte) {
data = data[0+n:] data = data[0+n:]
} }
{ {
n := msgpack.PutInt32(data[0:], int32((*a).UUID)) n := msgpack.PutInt32(data[0:], int32((*a).NID))
data = data[0+n:] data = data[0+n:]
} }
data[0] = byte(msgpack.FixExt1) data[0] = byte(msgpack.FixExt1)
...@@ -1156,9 +1156,9 @@ func (p *NotifyNodeInformation) neoMsgDecodeM(data []byte) (int, error) { ...@@ -1156,9 +1156,9 @@ func (p *NotifyNodeInformation) neoMsgDecodeM(data []byte) (int, error) {
{ {
v, tail, err := msgp.ReadInt32Bytes(data) v, tail, err := msgp.ReadInt32Bytes(data)
if err != nil { if err != nil {
return 0, mdecodeErr("NotifyNodeInformation.UUID", err) return 0, mdecodeErr("NotifyNodeInformation.NID", err)
} }
(*a).UUID = NodeUUID(v) (*a).NID = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -1497,7 +1497,7 @@ func (p *AnswerPartitionTable) neoMsgEncodeN(data []byte) { ...@@ -1497,7 +1497,7 @@ func (p *AnswerPartitionTable) neoMsgEncodeN(data []byte) {
data = data[4:] data = data[4:]
for i := 0; i < l; i++ { for i := 0; i < l; i++ {
a := &(*a).CellList[i] a := &(*a).CellList[i]
binary.BigEndian.PutUint32(data[0:], uint32(int32((*a).UUID))) binary.BigEndian.PutUint32(data[0:], uint32(int32((*a).NID)))
(data[4:])[0] = uint8(int8((*a).State)) (data[4:])[0] = uint8(int8((*a).State))
data = data[5:] data = data[5:]
} }
...@@ -1532,7 +1532,7 @@ func (p *AnswerPartitionTable) neoMsgDecodeN(data []byte) (int, error) { ...@@ -1532,7 +1532,7 @@ func (p *AnswerPartitionTable) neoMsgDecodeN(data []byte) (int, error) {
(*a).CellList = make([]CellInfo, l) (*a).CellList = make([]CellInfo, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &(*a).CellList[i] a := &(*a).CellList[i]
(*a).UUID = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) (*a).NID = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
(*a).State = CellState(int8((data[4 : 4+1])[0])) (*a).State = CellState(int8((data[4 : 4+1])[0]))
data = data[5:] data = data[5:]
} }
...@@ -1552,7 +1552,7 @@ func (p *AnswerPartitionTable) neoMsgEncodedLenM() int { ...@@ -1552,7 +1552,7 @@ func (p *AnswerPartitionTable) neoMsgEncodedLenM() int {
a := &p.RowList[i] a := &p.RowList[i]
for i := 0; i < len((*a).CellList); i++ { for i := 0; i < len((*a).CellList); i++ {
a := &(*a).CellList[i] a := &(*a).CellList[i]
size += msgpack.Int32Size(int32((*a).UUID)) size += msgpack.Int32Size(int32((*a).NID))
} }
size += msgpack.ArrayHeadSize(len((*a).CellList)) + len((*a).CellList)*4 size += msgpack.ArrayHeadSize(len((*a).CellList)) + len((*a).CellList)*4
} }
...@@ -1584,7 +1584,7 @@ func (p *AnswerPartitionTable) neoMsgEncodeM(data []byte) { ...@@ -1584,7 +1584,7 @@ func (p *AnswerPartitionTable) neoMsgEncodeM(data []byte) {
a := &(*a).CellList[i] a := &(*a).CellList[i]
data[0] = byte(msgpack.FixArray_4 | 2) data[0] = byte(msgpack.FixArray_4 | 2)
{ {
n := msgpack.PutInt32(data[1:], int32((*a).UUID)) n := msgpack.PutInt32(data[1:], int32((*a).NID))
data = data[1+n:] data = data[1+n:]
} }
data[0] = byte(msgpack.FixExt1) data[0] = byte(msgpack.FixExt1)
...@@ -1664,9 +1664,9 @@ func (p *AnswerPartitionTable) neoMsgDecodeM(data []byte) (int, error) { ...@@ -1664,9 +1664,9 @@ func (p *AnswerPartitionTable) neoMsgDecodeM(data []byte) (int, error) {
{ {
v, tail, err := msgp.ReadInt32Bytes(data) v, tail, err := msgp.ReadInt32Bytes(data)
if err != nil { if err != nil {
return 0, mdecodeErr("AnswerPartitionTable.UUID", err) return 0, mdecodeErr("AnswerPartitionTable.NID", err)
} }
(*a).UUID = NodeUUID(v) (*a).NID = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -1729,7 +1729,7 @@ func (p *SendPartitionTable) neoMsgEncodeN(data []byte) { ...@@ -1729,7 +1729,7 @@ func (p *SendPartitionTable) neoMsgEncodeN(data []byte) {
data = data[4:] data = data[4:]
for i := 0; i < l; i++ { for i := 0; i < l; i++ {
a := &(*a).CellList[i] a := &(*a).CellList[i]
binary.BigEndian.PutUint32(data[0:], uint32(int32((*a).UUID))) binary.BigEndian.PutUint32(data[0:], uint32(int32((*a).NID)))
(data[4:])[0] = uint8(int8((*a).State)) (data[4:])[0] = uint8(int8((*a).State))
data = data[5:] data = data[5:]
} }
...@@ -1764,7 +1764,7 @@ func (p *SendPartitionTable) neoMsgDecodeN(data []byte) (int, error) { ...@@ -1764,7 +1764,7 @@ func (p *SendPartitionTable) neoMsgDecodeN(data []byte) (int, error) {
(*a).CellList = make([]CellInfo, l) (*a).CellList = make([]CellInfo, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &(*a).CellList[i] a := &(*a).CellList[i]
(*a).UUID = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) (*a).NID = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
(*a).State = CellState(int8((data[4 : 4+1])[0])) (*a).State = CellState(int8((data[4 : 4+1])[0]))
data = data[5:] data = data[5:]
} }
...@@ -1784,7 +1784,7 @@ func (p *SendPartitionTable) neoMsgEncodedLenM() int { ...@@ -1784,7 +1784,7 @@ func (p *SendPartitionTable) neoMsgEncodedLenM() int {
a := &p.RowList[i] a := &p.RowList[i]
for i := 0; i < len((*a).CellList); i++ { for i := 0; i < len((*a).CellList); i++ {
a := &(*a).CellList[i] a := &(*a).CellList[i]
size += msgpack.Int32Size(int32((*a).UUID)) size += msgpack.Int32Size(int32((*a).NID))
} }
size += msgpack.ArrayHeadSize(len((*a).CellList)) + len((*a).CellList)*4 size += msgpack.ArrayHeadSize(len((*a).CellList)) + len((*a).CellList)*4
} }
...@@ -1816,7 +1816,7 @@ func (p *SendPartitionTable) neoMsgEncodeM(data []byte) { ...@@ -1816,7 +1816,7 @@ func (p *SendPartitionTable) neoMsgEncodeM(data []byte) {
a := &(*a).CellList[i] a := &(*a).CellList[i]
data[0] = byte(msgpack.FixArray_4 | 2) data[0] = byte(msgpack.FixArray_4 | 2)
{ {
n := msgpack.PutInt32(data[1:], int32((*a).UUID)) n := msgpack.PutInt32(data[1:], int32((*a).NID))
data = data[1+n:] data = data[1+n:]
} }
data[0] = byte(msgpack.FixExt1) data[0] = byte(msgpack.FixExt1)
...@@ -1896,9 +1896,9 @@ func (p *SendPartitionTable) neoMsgDecodeM(data []byte) (int, error) { ...@@ -1896,9 +1896,9 @@ func (p *SendPartitionTable) neoMsgDecodeM(data []byte) (int, error) {
{ {
v, tail, err := msgp.ReadInt32Bytes(data) v, tail, err := msgp.ReadInt32Bytes(data)
if err != nil { if err != nil {
return 0, mdecodeErr("SendPartitionTable.UUID", err) return 0, mdecodeErr("SendPartitionTable.NID", err)
} }
(*a).UUID = NodeUUID(v) (*a).NID = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -1951,7 +1951,7 @@ func (p *NotifyPartitionChanges) neoMsgEncodeN(data []byte) { ...@@ -1951,7 +1951,7 @@ func (p *NotifyPartitionChanges) neoMsgEncodeN(data []byte) {
for i := 0; i < l; i++ { for i := 0; i < l; i++ {
a := &p.CellList[i] a := &p.CellList[i]
binary.BigEndian.PutUint32(data[0:], (*a).Offset) binary.BigEndian.PutUint32(data[0:], (*a).Offset)
binary.BigEndian.PutUint32(data[4:], uint32(int32((*a).CellInfo.UUID))) binary.BigEndian.PutUint32(data[4:], uint32(int32((*a).CellInfo.NID)))
(data[8:])[0] = uint8(int8((*a).CellInfo.State)) (data[8:])[0] = uint8(int8((*a).CellInfo.State))
data = data[9:] data = data[9:]
} }
...@@ -1979,7 +1979,7 @@ func (p *NotifyPartitionChanges) neoMsgDecodeN(data []byte) (int, error) { ...@@ -1979,7 +1979,7 @@ func (p *NotifyPartitionChanges) neoMsgDecodeN(data []byte) (int, error) {
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &p.CellList[i] a := &p.CellList[i]
(*a).Offset = binary.BigEndian.Uint32(data[0 : 0+4]) (*a).Offset = binary.BigEndian.Uint32(data[0 : 0+4])
(*a).CellInfo.UUID = NodeUUID(int32(binary.BigEndian.Uint32(data[4 : 4+4]))) (*a).CellInfo.NID = NodeID(int32(binary.BigEndian.Uint32(data[4 : 4+4])))
(*a).CellInfo.State = CellState(int8((data[8 : 8+1])[0])) (*a).CellInfo.State = CellState(int8((data[8 : 8+1])[0]))
data = data[9:] data = data[9:]
} }
...@@ -1994,7 +1994,7 @@ func (p *NotifyPartitionChanges) neoMsgEncodedLenM() int { ...@@ -1994,7 +1994,7 @@ func (p *NotifyPartitionChanges) neoMsgEncodedLenM() int {
var size int var size int
for i := 0; i < len(p.CellList); i++ { for i := 0; i < len(p.CellList); i++ {
a := &p.CellList[i] a := &p.CellList[i]
size += msgpack.Uint32Size((*a).Offset) + msgpack.Int32Size(int32((*a).CellInfo.UUID)) size += msgpack.Uint32Size((*a).Offset) + msgpack.Int32Size(int32((*a).CellInfo.NID))
} }
return 1 + msgpack.Uint64Size(uint64(p.PTid)) + msgpack.Uint32Size(p.NumReplicas) + msgpack.ArrayHeadSize(len(p.CellList)) + len(p.CellList)*5 + size return 1 + msgpack.Uint64Size(uint64(p.PTid)) + msgpack.Uint32Size(p.NumReplicas) + msgpack.ArrayHeadSize(len(p.CellList)) + len(p.CellList)*5 + size
} }
...@@ -2022,7 +2022,7 @@ func (p *NotifyPartitionChanges) neoMsgEncodeM(data []byte) { ...@@ -2022,7 +2022,7 @@ func (p *NotifyPartitionChanges) neoMsgEncodeM(data []byte) {
} }
data[0] = byte(msgpack.FixArray_4 | 2) data[0] = byte(msgpack.FixArray_4 | 2)
{ {
n := msgpack.PutInt32(data[1:], int32((*a).CellInfo.UUID)) n := msgpack.PutInt32(data[1:], int32((*a).CellInfo.NID))
data = data[1+n:] data = data[1+n:]
} }
data[0] = byte(msgpack.FixExt1) data[0] = byte(msgpack.FixExt1)
...@@ -2102,9 +2102,9 @@ func (p *NotifyPartitionChanges) neoMsgDecodeM(data []byte) (int, error) { ...@@ -2102,9 +2102,9 @@ func (p *NotifyPartitionChanges) neoMsgDecodeM(data []byte) (int, error) {
{ {
v, tail, err := msgp.ReadInt32Bytes(data) v, tail, err := msgp.ReadInt32Bytes(data)
if err != nil { if err != nil {
return 0, mdecodeErr("NotifyPartitionChanges.CellInfo.UUID", err) return 0, mdecodeErr("NotifyPartitionChanges.CellInfo.NID", err)
} }
(*a).CellInfo.UUID = NodeUUID(v) (*a).CellInfo.NID = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -2964,10 +2964,10 @@ func (p *FailedVote) neoMsgDecodeN(data []byte) (int, error) { ...@@ -2964,10 +2964,10 @@ func (p *FailedVote) neoMsgDecodeN(data []byte) (int, error) {
goto overflow goto overflow
} }
nread += uint64(l) * 4 nread += uint64(l) * 4
p.NodeList = make([]NodeUUID, l) p.NodeList = make([]NodeID, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &p.NodeList[i] a := &p.NodeList[i]
(*a) = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) (*a) = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
data = data[4:] data = data[4:]
} }
} }
...@@ -3028,7 +3028,7 @@ func (p *FailedVote) neoMsgDecodeM(data []byte) (int, error) { ...@@ -3028,7 +3028,7 @@ func (p *FailedVote) neoMsgDecodeM(data []byte) (int, error) {
} }
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
p.NodeList = make([]NodeUUID, l) p.NodeList = make([]NodeID, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &p.NodeList[i] a := &p.NodeList[i]
{ {
...@@ -3036,7 +3036,7 @@ func (p *FailedVote) neoMsgDecodeM(data []byte) (int, error) { ...@@ -3036,7 +3036,7 @@ func (p *FailedVote) neoMsgDecodeM(data []byte) (int, error) {
if err != nil { if err != nil {
return 0, mdecodeErr("FailedVote", err) return 0, mdecodeErr("FailedVote", err)
} }
(*a) = NodeUUID(v) (*a) = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -4451,10 +4451,10 @@ func (p *AbortTransaction) neoMsgDecodeN(data []byte) (int, error) { ...@@ -4451,10 +4451,10 @@ func (p *AbortTransaction) neoMsgDecodeN(data []byte) (int, error) {
goto overflow goto overflow
} }
nread += uint64(l) * 4 nread += uint64(l) * 4
p.NodeList = make([]NodeUUID, l) p.NodeList = make([]NodeID, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &p.NodeList[i] a := &p.NodeList[i]
(*a) = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) (*a) = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
data = data[4:] data = data[4:]
} }
} }
...@@ -4515,7 +4515,7 @@ func (p *AbortTransaction) neoMsgDecodeM(data []byte) (int, error) { ...@@ -4515,7 +4515,7 @@ func (p *AbortTransaction) neoMsgDecodeM(data []byte) (int, error) {
} }
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
p.NodeList = make([]NodeUUID, l) p.NodeList = make([]NodeID, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &p.NodeList[i] a := &p.NodeList[i]
{ {
...@@ -4523,7 +4523,7 @@ func (p *AbortTransaction) neoMsgDecodeM(data []byte) (int, error) { ...@@ -4523,7 +4523,7 @@ func (p *AbortTransaction) neoMsgDecodeM(data []byte) (int, error) {
if err != nil { if err != nil {
return 0, mdecodeErr("AbortTransaction", err) return 0, mdecodeErr("AbortTransaction", err)
} }
(*a) = NodeUUID(v) (*a) = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -5857,7 +5857,7 @@ func (p *PartitionList) neoMsgEncodedLenN() int { ...@@ -5857,7 +5857,7 @@ func (p *PartitionList) neoMsgEncodedLenN() int {
func (p *PartitionList) neoMsgEncodeN(data []byte) { func (p *PartitionList) neoMsgEncodeN(data []byte) {
binary.BigEndian.PutUint32(data[0:], p.MinOffset) binary.BigEndian.PutUint32(data[0:], p.MinOffset)
binary.BigEndian.PutUint32(data[4:], p.MaxOffset) binary.BigEndian.PutUint32(data[4:], p.MaxOffset)
binary.BigEndian.PutUint32(data[8:], uint32(int32(p.NodeUUID))) binary.BigEndian.PutUint32(data[8:], uint32(int32(p.NodeID)))
} }
func (p *PartitionList) neoMsgDecodeN(data []byte) (int, error) { func (p *PartitionList) neoMsgDecodeN(data []byte) (int, error) {
...@@ -5866,7 +5866,7 @@ func (p *PartitionList) neoMsgDecodeN(data []byte) (int, error) { ...@@ -5866,7 +5866,7 @@ func (p *PartitionList) neoMsgDecodeN(data []byte) (int, error) {
} }
p.MinOffset = binary.BigEndian.Uint32(data[0 : 0+4]) p.MinOffset = binary.BigEndian.Uint32(data[0 : 0+4])
p.MaxOffset = binary.BigEndian.Uint32(data[4 : 4+4]) p.MaxOffset = binary.BigEndian.Uint32(data[4 : 4+4])
p.NodeUUID = NodeUUID(int32(binary.BigEndian.Uint32(data[8 : 8+4]))) p.NodeID = NodeID(int32(binary.BigEndian.Uint32(data[8 : 8+4])))
return 12, nil return 12, nil
overflow: overflow:
...@@ -5874,7 +5874,7 @@ overflow: ...@@ -5874,7 +5874,7 @@ overflow:
} }
func (p *PartitionList) neoMsgEncodedLenM() int { func (p *PartitionList) neoMsgEncodedLenM() int {
return 1 + msgpack.Uint32Size(p.MinOffset) + msgpack.Uint32Size(p.MaxOffset) + msgpack.Int32Size(int32(p.NodeUUID)) return 1 + msgpack.Uint32Size(p.MinOffset) + msgpack.Uint32Size(p.MaxOffset) + msgpack.Int32Size(int32(p.NodeID))
} }
func (p *PartitionList) neoMsgEncodeM(data []byte) { func (p *PartitionList) neoMsgEncodeM(data []byte) {
...@@ -5888,7 +5888,7 @@ func (p *PartitionList) neoMsgEncodeM(data []byte) { ...@@ -5888,7 +5888,7 @@ func (p *PartitionList) neoMsgEncodeM(data []byte) {
data = data[0+n:] data = data[0+n:]
} }
{ {
n := msgpack.PutInt32(data[0:], int32(p.NodeUUID)) n := msgpack.PutInt32(data[0:], int32(p.NodeID))
data = data[0+n:] data = data[0+n:]
} }
} }
...@@ -5923,9 +5923,9 @@ func (p *PartitionList) neoMsgDecodeM(data []byte) (int, error) { ...@@ -5923,9 +5923,9 @@ func (p *PartitionList) neoMsgDecodeM(data []byte) (int, error) {
{ {
v, tail, err := msgp.ReadInt32Bytes(data) v, tail, err := msgp.ReadInt32Bytes(data)
if err != nil { if err != nil {
return 0, mdecodeErr("PartitionList.NodeUUID", err) return 0, mdecodeErr("PartitionList.NodeID", err)
} }
p.NodeUUID = NodeUUID(v) p.NodeID = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -5965,7 +5965,7 @@ func (p *AnswerPartitionList) neoMsgEncodeN(data []byte) { ...@@ -5965,7 +5965,7 @@ func (p *AnswerPartitionList) neoMsgEncodeN(data []byte) {
data = data[4:] data = data[4:]
for i := 0; i < l; i++ { for i := 0; i < l; i++ {
a := &(*a).CellList[i] a := &(*a).CellList[i]
binary.BigEndian.PutUint32(data[0:], uint32(int32((*a).UUID))) binary.BigEndian.PutUint32(data[0:], uint32(int32((*a).NID)))
(data[4:])[0] = uint8(int8((*a).State)) (data[4:])[0] = uint8(int8((*a).State))
data = data[5:] data = data[5:]
} }
...@@ -6000,7 +6000,7 @@ func (p *AnswerPartitionList) neoMsgDecodeN(data []byte) (int, error) { ...@@ -6000,7 +6000,7 @@ func (p *AnswerPartitionList) neoMsgDecodeN(data []byte) (int, error) {
(*a).CellList = make([]CellInfo, l) (*a).CellList = make([]CellInfo, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &(*a).CellList[i] a := &(*a).CellList[i]
(*a).UUID = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) (*a).NID = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
(*a).State = CellState(int8((data[4 : 4+1])[0])) (*a).State = CellState(int8((data[4 : 4+1])[0]))
data = data[5:] data = data[5:]
} }
...@@ -6020,7 +6020,7 @@ func (p *AnswerPartitionList) neoMsgEncodedLenM() int { ...@@ -6020,7 +6020,7 @@ func (p *AnswerPartitionList) neoMsgEncodedLenM() int {
a := &p.RowList[i] a := &p.RowList[i]
for i := 0; i < len((*a).CellList); i++ { for i := 0; i < len((*a).CellList); i++ {
a := &(*a).CellList[i] a := &(*a).CellList[i]
size += msgpack.Int32Size(int32((*a).UUID)) size += msgpack.Int32Size(int32((*a).NID))
} }
size += msgpack.ArrayHeadSize(len((*a).CellList)) + len((*a).CellList)*4 size += msgpack.ArrayHeadSize(len((*a).CellList)) + len((*a).CellList)*4
} }
...@@ -6052,7 +6052,7 @@ func (p *AnswerPartitionList) neoMsgEncodeM(data []byte) { ...@@ -6052,7 +6052,7 @@ func (p *AnswerPartitionList) neoMsgEncodeM(data []byte) {
a := &(*a).CellList[i] a := &(*a).CellList[i]
data[0] = byte(msgpack.FixArray_4 | 2) data[0] = byte(msgpack.FixArray_4 | 2)
{ {
n := msgpack.PutInt32(data[1:], int32((*a).UUID)) n := msgpack.PutInt32(data[1:], int32((*a).NID))
data = data[1+n:] data = data[1+n:]
} }
data[0] = byte(msgpack.FixExt1) data[0] = byte(msgpack.FixExt1)
...@@ -6132,9 +6132,9 @@ func (p *AnswerPartitionList) neoMsgDecodeM(data []byte) (int, error) { ...@@ -6132,9 +6132,9 @@ func (p *AnswerPartitionList) neoMsgDecodeM(data []byte) (int, error) {
{ {
v, tail, err := msgp.ReadInt32Bytes(data) v, tail, err := msgp.ReadInt32Bytes(data)
if err != nil { if err != nil {
return 0, mdecodeErr("AnswerPartitionList.UUID", err) return 0, mdecodeErr("AnswerPartitionList.NID", err)
} }
(*a).UUID = NodeUUID(v) (*a).NID = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -6259,7 +6259,7 @@ func (p *AnswerNodeList) neoMsgEncodeN(data []byte) { ...@@ -6259,7 +6259,7 @@ func (p *AnswerNodeList) neoMsgEncodeN(data []byte) {
n := (*a).Addr.neoEncodeN(data[1:]) n := (*a).Addr.neoEncodeN(data[1:])
data = data[1+n:] data = data[1+n:]
} }
binary.BigEndian.PutUint32(data[0:], uint32(int32((*a).UUID))) binary.BigEndian.PutUint32(data[0:], uint32(int32((*a).NID)))
(data[4:])[0] = uint8(int8((*a).State)) (data[4:])[0] = uint8(int8((*a).State))
{ {
n := (*a).IdTime.neoEncodeN(data[5:]) n := (*a).IdTime.neoEncodeN(data[5:])
...@@ -6296,7 +6296,7 @@ func (p *AnswerNodeList) neoMsgDecodeN(data []byte) (int, error) { ...@@ -6296,7 +6296,7 @@ func (p *AnswerNodeList) neoMsgDecodeN(data []byte) (int, error) {
if len(data) < 5 { if len(data) < 5 {
goto overflow goto overflow
} }
(*a).UUID = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) (*a).NID = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
(*a).State = NodeState(int8((data[4 : 4+1])[0])) (*a).State = NodeState(int8((data[4 : 4+1])[0]))
data = data[5:] data = data[5:]
{ {
...@@ -6320,7 +6320,7 @@ func (p *AnswerNodeList) neoMsgEncodedLenM() int { ...@@ -6320,7 +6320,7 @@ func (p *AnswerNodeList) neoMsgEncodedLenM() int {
var size int var size int
for i := 0; i < len(p.NodeList); i++ { for i := 0; i < len(p.NodeList); i++ {
a := &p.NodeList[i] a := &p.NodeList[i]
size += msgpack.BinHeadSize(len((*a).Addr.Host)) + len((*a).Addr.Host) + msgpack.Uint16Size((*a).Addr.Port) + msgpack.Int32Size(int32((*a).UUID)) size += msgpack.BinHeadSize(len((*a).Addr.Host)) + len((*a).Addr.Host) + msgpack.Uint16Size((*a).Addr.Port) + msgpack.Int32Size(int32((*a).NID))
} }
return 1 + msgpack.ArrayHeadSize(len(p.NodeList)) + len(p.NodeList)*17 + size return 1 + msgpack.ArrayHeadSize(len(p.NodeList)) + len(p.NodeList)*17 + size
} }
...@@ -6353,7 +6353,7 @@ func (p *AnswerNodeList) neoMsgEncodeM(data []byte) { ...@@ -6353,7 +6353,7 @@ func (p *AnswerNodeList) neoMsgEncodeM(data []byte) {
data = data[0+n:] data = data[0+n:]
} }
{ {
n := msgpack.PutInt32(data[0:], int32((*a).UUID)) n := msgpack.PutInt32(data[0:], int32((*a).NID))
data = data[0+n:] data = data[0+n:]
} }
data[0] = byte(msgpack.FixExt1) data[0] = byte(msgpack.FixExt1)
...@@ -6432,9 +6432,9 @@ func (p *AnswerNodeList) neoMsgDecodeM(data []byte) (int, error) { ...@@ -6432,9 +6432,9 @@ func (p *AnswerNodeList) neoMsgDecodeM(data []byte) (int, error) {
{ {
v, tail, err := msgp.ReadInt32Bytes(data) v, tail, err := msgp.ReadInt32Bytes(data)
if err != nil { if err != nil {
return 0, mdecodeErr("AnswerNodeList.UUID", err) return 0, mdecodeErr("AnswerNodeList.NID", err)
} }
(*a).UUID = NodeUUID(v) (*a).NID = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -6484,7 +6484,7 @@ func (p *SetNodeState) neoMsgEncodedLenN() int { ...@@ -6484,7 +6484,7 @@ func (p *SetNodeState) neoMsgEncodedLenN() int {
} }
func (p *SetNodeState) neoMsgEncodeN(data []byte) { func (p *SetNodeState) neoMsgEncodeN(data []byte) {
binary.BigEndian.PutUint32(data[0:], uint32(int32(p.NodeUUID))) binary.BigEndian.PutUint32(data[0:], uint32(int32(p.NodeID)))
(data[4:])[0] = uint8(int8(p.NodeState)) (data[4:])[0] = uint8(int8(p.NodeState))
} }
...@@ -6492,7 +6492,7 @@ func (p *SetNodeState) neoMsgDecodeN(data []byte) (int, error) { ...@@ -6492,7 +6492,7 @@ func (p *SetNodeState) neoMsgDecodeN(data []byte) (int, error) {
if len(data) < 5 { if len(data) < 5 {
goto overflow goto overflow
} }
p.NodeUUID = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) p.NodeID = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
p.NodeState = NodeState(int8((data[4 : 4+1])[0])) p.NodeState = NodeState(int8((data[4 : 4+1])[0]))
return 5, nil return 5, nil
...@@ -6501,13 +6501,13 @@ overflow: ...@@ -6501,13 +6501,13 @@ overflow:
} }
func (p *SetNodeState) neoMsgEncodedLenM() int { func (p *SetNodeState) neoMsgEncodedLenM() int {
return 4 + msgpack.Int32Size(int32(p.NodeUUID)) return 4 + msgpack.Int32Size(int32(p.NodeID))
} }
func (p *SetNodeState) neoMsgEncodeM(data []byte) { func (p *SetNodeState) neoMsgEncodeM(data []byte) {
data[0] = byte(msgpack.FixArray_4 | 2) data[0] = byte(msgpack.FixArray_4 | 2)
{ {
n := msgpack.PutInt32(data[1:], int32(p.NodeUUID)) n := msgpack.PutInt32(data[1:], int32(p.NodeID))
data = data[1+n:] data = data[1+n:]
} }
data[0] = byte(msgpack.FixExt1) data[0] = byte(msgpack.FixExt1)
...@@ -6530,9 +6530,9 @@ func (p *SetNodeState) neoMsgDecodeM(data []byte) (int, error) { ...@@ -6530,9 +6530,9 @@ func (p *SetNodeState) neoMsgDecodeM(data []byte) (int, error) {
{ {
v, tail, err := msgp.ReadInt32Bytes(data) v, tail, err := msgp.ReadInt32Bytes(data)
if err != nil { if err != nil {
return 0, mdecodeErr("SetNodeState.NodeUUID", err) return 0, mdecodeErr("SetNodeState.NodeID", err)
} }
p.NodeUUID = NodeUUID(v) p.NodeID = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -6593,10 +6593,10 @@ func (p *AddPendingNodes) neoMsgDecodeN(data []byte) (int, error) { ...@@ -6593,10 +6593,10 @@ func (p *AddPendingNodes) neoMsgDecodeN(data []byte) (int, error) {
goto overflow goto overflow
} }
nread += uint64(l) * 4 nread += uint64(l) * 4
p.NodeList = make([]NodeUUID, l) p.NodeList = make([]NodeID, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &p.NodeList[i] a := &p.NodeList[i]
(*a) = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) (*a) = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
data = data[4:] data = data[4:]
} }
} }
...@@ -6647,7 +6647,7 @@ func (p *AddPendingNodes) neoMsgDecodeM(data []byte) (int, error) { ...@@ -6647,7 +6647,7 @@ func (p *AddPendingNodes) neoMsgDecodeM(data []byte) (int, error) {
} }
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
p.NodeList = make([]NodeUUID, l) p.NodeList = make([]NodeID, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &p.NodeList[i] a := &p.NodeList[i]
{ {
...@@ -6655,7 +6655,7 @@ func (p *AddPendingNodes) neoMsgDecodeM(data []byte) (int, error) { ...@@ -6655,7 +6655,7 @@ func (p *AddPendingNodes) neoMsgDecodeM(data []byte) (int, error) {
if err != nil { if err != nil {
return 0, mdecodeErr("AddPendingNodes", err) return 0, mdecodeErr("AddPendingNodes", err)
} }
(*a) = NodeUUID(v) (*a) = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -6704,10 +6704,10 @@ func (p *TweakPartitionTable) neoMsgDecodeN(data []byte) (int, error) { ...@@ -6704,10 +6704,10 @@ func (p *TweakPartitionTable) neoMsgDecodeN(data []byte) (int, error) {
goto overflow goto overflow
} }
nread += uint64(l) * 4 nread += uint64(l) * 4
p.NodeList = make([]NodeUUID, l) p.NodeList = make([]NodeID, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &p.NodeList[i] a := &p.NodeList[i]
(*a) = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) (*a) = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
data = data[4:] data = data[4:]
} }
} }
...@@ -6767,7 +6767,7 @@ func (p *TweakPartitionTable) neoMsgDecodeM(data []byte) (int, error) { ...@@ -6767,7 +6767,7 @@ func (p *TweakPartitionTable) neoMsgDecodeM(data []byte) (int, error) {
} }
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
p.NodeList = make([]NodeUUID, l) p.NodeList = make([]NodeID, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &p.NodeList[i] a := &p.NodeList[i]
{ {
...@@ -6775,7 +6775,7 @@ func (p *TweakPartitionTable) neoMsgDecodeM(data []byte) (int, error) { ...@@ -6775,7 +6775,7 @@ func (p *TweakPartitionTable) neoMsgDecodeM(data []byte) (int, error) {
if err != nil { if err != nil {
return 0, mdecodeErr("TweakPartitionTable", err) return 0, mdecodeErr("TweakPartitionTable", err)
} }
(*a) = NodeUUID(v) (*a) = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -6816,7 +6816,7 @@ func (p *AnswerTweakPartitionTable) neoMsgEncodeN(data []byte) { ...@@ -6816,7 +6816,7 @@ func (p *AnswerTweakPartitionTable) neoMsgEncodeN(data []byte) {
data = data[4:] data = data[4:]
for i := 0; i < l; i++ { for i := 0; i < l; i++ {
a := &(*a).CellList[i] a := &(*a).CellList[i]
binary.BigEndian.PutUint32(data[0:], uint32(int32((*a).UUID))) binary.BigEndian.PutUint32(data[0:], uint32(int32((*a).NID)))
(data[4:])[0] = uint8(int8((*a).State)) (data[4:])[0] = uint8(int8((*a).State))
data = data[5:] data = data[5:]
} }
...@@ -6850,7 +6850,7 @@ func (p *AnswerTweakPartitionTable) neoMsgDecodeN(data []byte) (int, error) { ...@@ -6850,7 +6850,7 @@ func (p *AnswerTweakPartitionTable) neoMsgDecodeN(data []byte) (int, error) {
(*a).CellList = make([]CellInfo, l) (*a).CellList = make([]CellInfo, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &(*a).CellList[i] a := &(*a).CellList[i]
(*a).UUID = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) (*a).NID = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
(*a).State = CellState(int8((data[4 : 4+1])[0])) (*a).State = CellState(int8((data[4 : 4+1])[0]))
data = data[5:] data = data[5:]
} }
...@@ -6870,7 +6870,7 @@ func (p *AnswerTweakPartitionTable) neoMsgEncodedLenM() int { ...@@ -6870,7 +6870,7 @@ func (p *AnswerTweakPartitionTable) neoMsgEncodedLenM() int {
a := &p.RowList[i] a := &p.RowList[i]
for i := 0; i < len((*a).CellList); i++ { for i := 0; i < len((*a).CellList); i++ {
a := &(*a).CellList[i] a := &(*a).CellList[i]
size += msgpack.Int32Size(int32((*a).UUID)) size += msgpack.Int32Size(int32((*a).NID))
} }
size += msgpack.ArrayHeadSize(len((*a).CellList)) + len((*a).CellList)*4 size += msgpack.ArrayHeadSize(len((*a).CellList)) + len((*a).CellList)*4
} }
...@@ -6895,7 +6895,7 @@ func (p *AnswerTweakPartitionTable) neoMsgEncodeM(data []byte) { ...@@ -6895,7 +6895,7 @@ func (p *AnswerTweakPartitionTable) neoMsgEncodeM(data []byte) {
a := &(*a).CellList[i] a := &(*a).CellList[i]
data[0] = byte(msgpack.FixArray_4 | 2) data[0] = byte(msgpack.FixArray_4 | 2)
{ {
n := msgpack.PutInt32(data[1:], int32((*a).UUID)) n := msgpack.PutInt32(data[1:], int32((*a).NID))
data = data[1+n:] data = data[1+n:]
} }
data[0] = byte(msgpack.FixExt1) data[0] = byte(msgpack.FixExt1)
...@@ -6965,9 +6965,9 @@ func (p *AnswerTweakPartitionTable) neoMsgDecodeM(data []byte) (int, error) { ...@@ -6965,9 +6965,9 @@ func (p *AnswerTweakPartitionTable) neoMsgDecodeM(data []byte) (int, error) {
{ {
v, tail, err := msgp.ReadInt32Bytes(data) v, tail, err := msgp.ReadInt32Bytes(data)
if err != nil { if err != nil {
return 0, mdecodeErr("AnswerTweakPartitionTable.UUID", err) return 0, mdecodeErr("AnswerTweakPartitionTable.NID", err)
} }
(*a).UUID = NodeUUID(v) (*a).NID = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -7162,10 +7162,10 @@ func (p *Repair) neoMsgDecodeN(data []byte) (int, error) { ...@@ -7162,10 +7162,10 @@ func (p *Repair) neoMsgDecodeN(data []byte) (int, error) {
goto overflow goto overflow
} }
nread += 1 + uint64(l)*4 nread += 1 + uint64(l)*4
p.NodeList = make([]NodeUUID, l) p.NodeList = make([]NodeID, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &p.NodeList[i] a := &p.NodeList[i]
(*a) = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) (*a) = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
data = data[4:] data = data[4:]
} }
} }
...@@ -7219,7 +7219,7 @@ func (p *Repair) neoMsgDecodeM(data []byte) (int, error) { ...@@ -7219,7 +7219,7 @@ func (p *Repair) neoMsgDecodeM(data []byte) (int, error) {
} }
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
p.NodeList = make([]NodeUUID, l) p.NodeList = make([]NodeID, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &p.NodeList[i] a := &p.NodeList[i]
{ {
...@@ -7227,7 +7227,7 @@ func (p *Repair) neoMsgDecodeM(data []byte) (int, error) { ...@@ -7227,7 +7227,7 @@ func (p *Repair) neoMsgDecodeM(data []byte) (int, error) {
if err != nil { if err != nil {
return 0, mdecodeErr("Repair", err) return 0, mdecodeErr("Repair", err)
} }
(*a) = NodeUUID(v) (*a) = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -8159,12 +8159,12 @@ func (p *CheckReplicas) neoMsgDecodeN(data []byte) (int, error) { ...@@ -8159,12 +8159,12 @@ func (p *CheckReplicas) neoMsgDecodeN(data []byte) (int, error) {
goto overflow goto overflow
} }
nread += 16 + uint64(l)*8 nread += 16 + uint64(l)*8
p.PartitionDict = make(map[uint32]NodeUUID, l) p.PartitionDict = make(map[uint32]NodeID, l)
m := p.PartitionDict m := p.PartitionDict
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
var key uint32 var key uint32
key = binary.BigEndian.Uint32(data[0 : 0+4]) key = binary.BigEndian.Uint32(data[0 : 0+4])
m[key] = NodeUUID(int32(binary.BigEndian.Uint32(data[4 : 4+4]))) m[key] = NodeID(int32(binary.BigEndian.Uint32(data[4 : 4+4])))
data = data[8:] data = data[8:]
} }
} }
...@@ -8230,7 +8230,7 @@ func (p *CheckReplicas) neoMsgDecodeM(data []byte) (int, error) { ...@@ -8230,7 +8230,7 @@ func (p *CheckReplicas) neoMsgDecodeM(data []byte) (int, error) {
} }
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
p.PartitionDict = make(map[uint32]NodeUUID, l) p.PartitionDict = make(map[uint32]NodeID, l)
m := p.PartitionDict m := p.PartitionDict
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
var key uint32 var key uint32
...@@ -8248,7 +8248,7 @@ func (p *CheckReplicas) neoMsgDecodeM(data []byte) (int, error) { ...@@ -8248,7 +8248,7 @@ func (p *CheckReplicas) neoMsgDecodeM(data []byte) (int, error) {
if err != nil { if err != nil {
return 0, mdecodeErr("CheckReplicas", err) return 0, mdecodeErr("CheckReplicas", err)
} }
m[key] = NodeUUID(v) m[key] = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
...@@ -8914,10 +8914,10 @@ func (p *PartitionCorrupted) neoMsgDecodeN(data []byte) (int, error) { ...@@ -8914,10 +8914,10 @@ func (p *PartitionCorrupted) neoMsgDecodeN(data []byte) (int, error) {
goto overflow goto overflow
} }
nread += uint64(l) * 4 nread += uint64(l) * 4
p.CellList = make([]NodeUUID, l) p.CellList = make([]NodeID, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &p.CellList[i] a := &p.CellList[i]
(*a) = NodeUUID(int32(binary.BigEndian.Uint32(data[0 : 0+4]))) (*a) = NodeID(int32(binary.BigEndian.Uint32(data[0 : 0+4])))
data = data[4:] data = data[4:]
} }
} }
...@@ -8981,7 +8981,7 @@ func (p *PartitionCorrupted) neoMsgDecodeM(data []byte) (int, error) { ...@@ -8981,7 +8981,7 @@ func (p *PartitionCorrupted) neoMsgDecodeM(data []byte) (int, error) {
} }
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
p.CellList = make([]NodeUUID, l) p.CellList = make([]NodeID, l)
for i := 0; uint32(i) < l; i++ { for i := 0; uint32(i) < l; i++ {
a := &p.CellList[i] a := &p.CellList[i]
{ {
...@@ -8989,7 +8989,7 @@ func (p *PartitionCorrupted) neoMsgDecodeM(data []byte) (int, error) { ...@@ -8989,7 +8989,7 @@ func (p *PartitionCorrupted) neoMsgDecodeM(data []byte) (int, error) {
if err != nil { if err != nil {
return 0, mdecodeErr("PartitionCorrupted", err) return 0, mdecodeErr("PartitionCorrupted", err)
} }
(*a) = NodeUUID(v) (*a) = NodeID(v)
nread += uint64(len(data) - len(tail)) nread += uint64(len(data) - len(tail))
data = tail data = tail
} }
......
...@@ -208,7 +208,7 @@ func (stor *Storage) talkMaster1(ctx context.Context) (err error) { ...@@ -208,7 +208,7 @@ func (stor *Storage) talkMaster1(ctx context.Context) (err error) {
defer xio.CloseWhenDone(ctx, mlink)() defer xio.CloseWhenDone(ctx, mlink)()
// XXX add master UUID -> nodeTab ? or master will notify us with it himself ? // XXX add master NID -> nodeTab ? or master will notify us with it himself ?
// XXX move -> SetNumReplicas handler // XXX move -> SetNumReplicas handler
/* /*
...@@ -219,9 +219,9 @@ func (stor *Storage) talkMaster1(ctx context.Context) (err error) { ...@@ -219,9 +219,9 @@ func (stor *Storage) talkMaster1(ctx context.Context) (err error) {
*/ */
// XXX -> node.Dial ? // XXX -> node.Dial ?
if accept.YourUUID != stor.node.MyInfo.UUID { if accept.YourNID != stor.node.MyInfo.NID {
log.Infof(ctx, "master told us to have uuid=%v", accept.YourUUID) log.Infof(ctx, "master told us to have nid=%v", accept.YourNID)
stor.node.MyInfo.UUID = accept.YourUUID stor.node.MyInfo.NID = accept.YourNID
} }
// XXX the first packet M sends always is NotifyNodeInformation (with us) // XXX the first packet M sends always is NotifyNodeInformation (with us)
...@@ -325,7 +325,7 @@ func (stor *Storage) m1initialize1(ctx context.Context, req neonet.Request) erro ...@@ -325,7 +325,7 @@ func (stor *Storage) m1initialize1(ctx context.Context, req neonet.Request) erro
// TODO M sends us δPT -> save locally? // TODO M sends us δPT -> save locally?
case *proto.NotifyNodeInformation: case *proto.NotifyNodeInformation:
// XXX check for myUUID and consider it a command (like neo/py) does? // XXX check for myNID and consider it a command (like neo/py) does?
stor.node.UpdateNodeTab(ctx, msg) // XXX lock? stor.node.UpdateNodeTab(ctx, msg) // XXX lock?
case *proto.NotifyClusterState: case *proto.NotifyClusterState:
...@@ -410,7 +410,7 @@ func (stor *Storage) m1serve1(ctx context.Context, req neonet.Request) error { ...@@ -410,7 +410,7 @@ func (stor *Storage) m1serve1(ctx context.Context, req neonet.Request) error {
// identify processes identification request from connected peer. // identify processes identification request from connected peer.
func (stor *Storage) identify(idReq *proto.RequestIdentification) (proto.Msg, bool) { func (stor *Storage) identify(idReq *proto.RequestIdentification) (proto.Msg, bool) {
// XXX stub: we accept clients and don't care about their UUID // XXX stub: we accept clients and don't care about their NID
if idReq.NodeType != proto.CLIENT { if idReq.NodeType != proto.CLIENT {
return &proto.Error{proto.PROTOCOL_ERROR, "only clients are accepted"}, false return &proto.Error{proto.PROTOCOL_ERROR, "only clients are accepted"}, false
} }
...@@ -428,9 +428,9 @@ func (stor *Storage) identify(idReq *proto.RequestIdentification) (proto.Msg, bo ...@@ -428,9 +428,9 @@ func (stor *Storage) identify(idReq *proto.RequestIdentification) (proto.Msg, bo
} }
return &proto.AcceptIdentification{ return &proto.AcceptIdentification{
NodeType: stor.node.MyInfo.Type, NodeType: stor.node.MyInfo.Type,
MyUUID: stor.node.MyInfo.UUID, // XXX lock wrt update MyNID: stor.node.MyInfo.NID, // XXX lock wrt update
YourUUID: idReq.UUID, YourNID: idReq.NID,
}, true }, true
} }
......
// Copyright (C) 2018-2020 Nexedi SA and Contributors. // Copyright (C) 2018-2021 Nexedi SA and Contributors.
// Kirill Smelkov <kirr@nexedi.com> // Kirill Smelkov <kirr@nexedi.com>
// schema & queries are based on neo/storage/database/sqlite.py // schema & queries are based on neo/storage/database/sqlite.py
// //
...@@ -534,7 +534,7 @@ func Open(dburl string) (_ *Backend, err error) { ...@@ -534,7 +534,7 @@ func Open(dburl string) (_ *Backend, err error) {
} }
checkConfig("version", schemaVersion) checkConfig("version", schemaVersion)
checkConfig("nid", int(proto.UUID(proto.STORAGE, 1))) checkConfig("nid", int(proto.NID(proto.STORAGE, 1)))
checkConfig("replicas", 0) // XXX neo/py uses nreplicas as 1 + n(replica) checkConfig("replicas", 0) // XXX neo/py uses nreplicas as 1 + n(replica)
err = errv.Err() err = errv.Err()
......
...@@ -430,7 +430,7 @@ func (t0 *tEnv) NewCluster_MS(name string, Sback storage.Backend) *tCluster { ...@@ -430,7 +430,7 @@ func (t0 *tEnv) NewCluster_MS(name string, Sback storage.Backend) *tCluster {
t.Expect("s-m", netconnect("s:2", "m:2", "m:1")) t.Expect("s-m", netconnect("s:2", "m:2", "m:1"))
t.Expect("s-m", conntx("s:2", "m:2", 1, &proto.RequestIdentification{ t.Expect("s-m", conntx("s:2", "m:2", 1, &proto.RequestIdentification{
NodeType: proto.STORAGE, NodeType: proto.STORAGE,
UUID: 0, NID: 0,
Address: xnaddr("s:1"), Address: xnaddr("s:1"),
ClusterName: name, ClusterName: name,
IdTime: proto.IdTimeNone, IdTime: proto.IdTimeNone,
...@@ -442,8 +442,8 @@ func (t0 *tEnv) NewCluster_MS(name string, Sback storage.Backend) *tCluster { ...@@ -442,8 +442,8 @@ func (t0 *tEnv) NewCluster_MS(name string, Sback storage.Backend) *tCluster {
t.Expect("s-m", conntx("m:2", "s:2", 1, &proto.AcceptIdentification{ t.Expect("s-m", conntx("m:2", "s:2", 1, &proto.AcceptIdentification{
NodeType: proto.MASTER, NodeType: proto.MASTER,
MyUUID: proto.UUID(proto.MASTER, 1), MyNID: proto.NID(proto.MASTER, 1),
YourUUID: proto.UUID(proto.STORAGE, 1), YourNID: proto.NID(proto.STORAGE, 1),
})) }))
// M starts recovery on S // M starts recovery on S
......
...@@ -132,7 +132,7 @@ func nodei(laddr string, typ proto.NodeType, num int32, state proto.NodeState, i ...@@ -132,7 +132,7 @@ func nodei(laddr string, typ proto.NodeType, num int32, state proto.NodeState, i
return proto.NodeInfo{ return proto.NodeInfo{
Type: typ, Type: typ,
Addr: xnaddr(laddr), Addr: xnaddr(laddr),
UUID: proto.UUID(typ, num), NID: proto.NID(typ, num),
State: state, State: state,
IdTime: idtime, IdTime: idtime,
} }
......
...@@ -39,9 +39,9 @@ import ( ...@@ -39,9 +39,9 @@ import (
// //
// It is // It is
// //
// UUID -> *Node // NID -> *Node
// //
// mapping listing known nodes and associating their uuid with information // mapping listing known nodes and associating their node ID with information
// about a node. // about a node.
// //
// Master maintains such table and provides it to its peers to know each other: // Master maintains such table and provides it to its peers to know each other:
...@@ -53,8 +53,8 @@ import ( ...@@ -53,8 +53,8 @@ import (
// //
// Usage examples: // Usage examples:
// //
// - C needs to connect/talk to a storage by uuid // - C needs to connect/talk to a storage by nid
// (the uuid itself is obtained from PartitionTable by oid). // (the nid itself is obtained from PartitionTable by oid).
// - S pulls from other S. // - S pulls from other S.
// //
// NOTE once a node was added to NodeTable its entry is never deleted: if e.g. // NOTE once a node was added to NodeTable its entry is never deleted: if e.g.
...@@ -82,7 +82,7 @@ type NodeTable struct { ...@@ -82,7 +82,7 @@ type NodeTable struct {
type Node struct { type Node struct {
nodeTab *NodeTable // this node is part of nodeTab *NodeTable // this node is part of
proto.NodeInfo // .type, .addr, .uuid, ... XXX also protect by mu? proto.NodeInfo // .type, .addr, .nid, ... XXX also protect by mu?
linkMu sync.Mutex linkMu sync.Mutex
link *neonet.NodeLink // link to this peer; nil if not connected link *neonet.NodeLink // link to this peer; nil if not connected
...@@ -118,11 +118,11 @@ func (nt *NodeTable) All() []*Node { ...@@ -118,11 +118,11 @@ func (nt *NodeTable) All() []*Node {
return nt.nodev return nt.nodev
} }
// Get finds node by uuid. // Get finds node by node ID.
func (nt *NodeTable) Get(uuid proto.NodeUUID) *Node { func (nt *NodeTable) Get(nid proto.NodeID) *Node {
// FIXME linear scan // FIXME linear scan
for _, node := range nt.nodev { for _, node := range nt.nodev {
if node.UUID == uuid { if node.NID == nid {
return node return node
} }
} }
...@@ -135,7 +135,7 @@ func (nt *NodeTable) Get(uuid proto.NodeUUID) *Node { ...@@ -135,7 +135,7 @@ func (nt *NodeTable) Get(uuid proto.NodeUUID) *Node {
// //
// it returns corresponding node entry for convenience. // it returns corresponding node entry for convenience.
func (nt *NodeTable) Update(nodeInfo proto.NodeInfo) *Node { func (nt *NodeTable) Update(nodeInfo proto.NodeInfo) *Node {
node := nt.Get(nodeInfo.UUID) node := nt.Get(nodeInfo.NID)
if node == nil { if node == nil {
node = &Node{nodeTab: nt} node = &Node{nodeTab: nt}
nt.nodev = append(nt.nodev, node) nt.nodev = append(nt.nodev, node)
...@@ -185,7 +185,7 @@ func (nt *NodeTable) String() string { ...@@ -185,7 +185,7 @@ func (nt *NodeTable) String() string {
// XXX also for .storv // XXX also for .storv
for _, n := range nt.nodev { for _, n := range nt.nodev {
// XXX recheck output // XXX recheck output
fmt.Fprintf(&buf, "%s (%s)\t%s\t%s\t@ %s\n", n.UUID, n.Type, n.State, n.Addr, n.IdTime) fmt.Fprintf(&buf, "%s (%s)\t%s\t%s\t@ %s\n", n.NID, n.Type, n.State, n.Addr, n.IdTime)
} }
return buf.String() return buf.String()
...@@ -331,7 +331,7 @@ func (p *Node) CloseLink(ctx context.Context) { ...@@ -331,7 +331,7 @@ func (p *Node) CloseLink(ctx context.Context) {
// XXX p.* reading without lock - ok? // XXX p.* reading without lock - ok?
// XXX app.MyInfo without lock - ok? // XXX app.MyInfo without lock - ok?
func (p *Node) dial(ctx context.Context) (_ *neonet.NodeLink, err error) { func (p *Node) dial(ctx context.Context) (_ *neonet.NodeLink, err error) {
defer task.Runningf(&ctx, "connect %s", p.UUID)(&err) // XXX "connect" good word here? defer task.Runningf(&ctx, "connect %s", p.NID)(&err) // XXX "connect" good word here?
app := p.nodeTab.nodeApp app := p.nodeTab.nodeApp
link, accept, err := app.Dial(ctx, p.Type, p.Addr.String()) link, accept, err := app.Dial(ctx, p.Type, p.Addr.String())
...@@ -343,11 +343,11 @@ func (p *Node) dial(ctx context.Context) (_ *neonet.NodeLink, err error) { ...@@ -343,11 +343,11 @@ func (p *Node) dial(ctx context.Context) (_ *neonet.NodeLink, err error) {
switch { switch {
// type is already checked by app.Dial // type is already checked by app.Dial
case accept.MyUUID != p.UUID: case accept.MyNID != p.NID:
err = fmt.Errorf("connected, but peer's uuid is not %v (identifies as %v)", p.UUID, accept.MyUUID) err = fmt.Errorf("connected, but peer's nid is not %v (identifies as %v)", p.NID, accept.MyNID)
case accept.YourUUID != app.MyInfo.UUID: case accept.YourNID != app.MyInfo.NID:
err = fmt.Errorf("connected, but peer gives us uuid %v (our is %v)", accept.YourUUID, app.MyInfo.UUID) err = fmt.Errorf("connected, but peer gives us nid %v (our is %v)", accept.YourNID, app.MyInfo.NID)
// XXX Node.Dial is currently used by Client only. // XXX Node.Dial is currently used by Client only.
// XXX For Client it would be not correct to check #partition only at // XXX For Client it would be not correct to check #partition only at
......
...@@ -32,7 +32,7 @@ import ( ...@@ -32,7 +32,7 @@ import (
// //
// It is // It is
// //
// oid -> []uuid // oid -> []nid
// //
// mapping associating object ID with list of storage nodes on where data for // mapping associating object ID with list of storage nodes on where data for
// this oid should be written-to/loaded-from. This mapping is organized as follows: // this oid should be written-to/loaded-from. This mapping is organized as follows:
...@@ -124,7 +124,7 @@ type PartitionTable struct { ...@@ -124,7 +124,7 @@ type PartitionTable struct {
// Cell describes one storage in a pid entry in partition table // Cell describes one storage in a pid entry in partition table
type Cell struct { type Cell struct {
proto.CellInfo // .uuid + .state proto.CellInfo // .nid + .state
// XXX ? + .haveUpToTid associated node has data up to such tid // XXX ? + .haveUpToTid associated node has data up to such tid
// = uptodate if haveUpToTid == lastTid // = uptodate if haveUpToTid == lastTid
...@@ -165,8 +165,8 @@ func MakePartTab(np int, nodev []*Node) *PartitionTable { ...@@ -165,8 +165,8 @@ func MakePartTab(np int, nodev []*Node) *PartitionTable {
for i, j := 0, 0; i < np; i, j = i+1, j+1 % len(nodev) { for i, j := 0, 0; i < np; i, j = i+1, j+1 % len(nodev) {
node := nodev[j] node := nodev[j]
// XXX assert node.State > DOWN // XXX assert node.State > DOWN
//fmt.Printf("tab[%d] <- %v\n", i, node.UUID) //fmt.Printf("tab[%d] <- %v\n", i, node.NID)
tab[i] = []Cell{{CellInfo: proto.CellInfo{node.UUID, proto.UP_TO_DATE /*XXX ok?*/}}} tab[i] = []Cell{{CellInfo: proto.CellInfo{node.NID, proto.UP_TO_DATE /*XXX ok?*/}}}
} }
return &PartitionTable{tab: tab} return &PartitionTable{tab: tab}
...@@ -181,7 +181,7 @@ func MakePartTab(np int, nodev []*Node) *PartitionTable { ...@@ -181,7 +181,7 @@ func MakePartTab(np int, nodev []*Node) *PartitionTable {
// //
// information about nodes being up or down is obtained from supplied NodeTable // information about nodes being up or down is obtained from supplied NodeTable
// //
// XXX or keep not only NodeUUID in Cell - add *Node ? // XXX or keep not only NodeID in Cell - add *Node ?
func (pt *PartitionTable) OperationalWith(nt *NodeTable) bool { func (pt *PartitionTable) OperationalWith(nt *NodeTable) bool {
// empty partition table is never operational // empty partition table is never operational
if len(pt.tab) == 0 { if len(pt.tab) == 0 {
...@@ -203,7 +203,7 @@ func (pt *PartitionTable) OperationalWith(nt *NodeTable) bool { ...@@ -203,7 +203,7 @@ func (pt *PartitionTable) OperationalWith(nt *NodeTable) bool {
// to last_tid. // to last_tid.
// //
// We leave it as is for now. // We leave it as is for now.
node := nt.Get(cell.UUID) node := nt.Get(cell.NID)
if node == nil || node.State != proto.RUNNING { // XXX PENDING is also ok ? if node == nil || node.State != proto.RUNNING { // XXX PENDING is also ok ?
continue continue
} }
...@@ -237,7 +237,7 @@ func (pt *PartitionTable) String() string { ...@@ -237,7 +237,7 @@ func (pt *PartitionTable) String() string {
} }
for _, cell := range cellv { for _, cell := range cellv {
fmt.Fprintf(buf, " %s(%s)", cell.UUID, cell.State) fmt.Fprintf(buf, " %s(%s)", cell.NID, cell.State)
} }
fmt.Fprintf(buf, "\n") fmt.Fprintf(buf, "\n")
} }
......
...@@ -26,15 +26,15 @@ import ( ...@@ -26,15 +26,15 @@ import (
) )
func TestPartTabOperational(t *testing.T) { func TestPartTabOperational(t *testing.T) {
s1 := proto.UUID(proto.STORAGE, 1) s1 := proto.NID(proto.STORAGE, 1)
s2 := proto.UUID(proto.STORAGE, 2) s2 := proto.NID(proto.STORAGE, 2)
// create nodeinfo for uuid/state // create nodeinfo for nid/state
n := func(uuid proto.NodeUUID, state proto.NodeState) proto.NodeInfo { n := func(nid proto.NodeID, state proto.NodeState) proto.NodeInfo {
return proto.NodeInfo{UUID: uuid, State: state} // XXX .Type? return proto.NodeInfo{NID: nid, State: state} // XXX .Type?
} }
// create nodetab with [](uuid, state) // create nodetab with [](nid, state)
N := func(nodeiv ...proto.NodeInfo) *NodeTable { N := func(nodeiv ...proto.NodeInfo) *NodeTable {
nt := &NodeTable{} nt := &NodeTable{}
for _, nodei := range nodeiv { for _, nodei := range nodeiv {
...@@ -43,9 +43,9 @@ func TestPartTabOperational(t *testing.T) { ...@@ -43,9 +43,9 @@ func TestPartTabOperational(t *testing.T) {
return nt return nt
} }
// create cell with uuid/state // create cell with nid/state
C := func(uuid proto.NodeUUID, state proto.CellState) Cell { C := func(nid proto.NodeID, state proto.CellState) Cell {
return Cell{proto.CellInfo{UUID: uuid, State: state}} return Cell{proto.CellInfo{NID: nid, State: state}}
} }
// shortcut to create []Cell // shortcut to create []Cell
......
...@@ -66,7 +66,7 @@ type NodeApp struct { ...@@ -66,7 +66,7 @@ type NodeApp struct {
// NewNodeApp creates new node application // NewNodeApp creates new node application
func NewNodeApp(net xnet.Networker, typ proto.NodeType, clusterName, masterAddr string) *NodeApp { func NewNodeApp(net xnet.Networker, typ proto.NodeType, clusterName, masterAddr string) *NodeApp {
app := &NodeApp{ app := &NodeApp{
MyInfo: proto.NodeInfo{Type: typ, Addr: proto.Address{}, UUID: 0, IdTime: proto.IdTimeNone}, MyInfo: proto.NodeInfo{Type: typ, Addr: proto.Address{}, NID: 0, IdTime: proto.IdTimeNone},
ClusterName: clusterName, ClusterName: clusterName,
Net: net, Net: net,
MasterAddr: masterAddr, MasterAddr: masterAddr,
...@@ -116,7 +116,7 @@ func (app *NodeApp) Dial(ctx context.Context, peerType proto.NodeType, addr stri ...@@ -116,7 +116,7 @@ func (app *NodeApp) Dial(ctx context.Context, peerType proto.NodeType, addr stri
req := &proto.RequestIdentification{ req := &proto.RequestIdentification{
NodeType: app.MyInfo.Type, NodeType: app.MyInfo.Type,
UUID: app.MyInfo.UUID, NID: app.MyInfo.NID,
Address: app.MyInfo.Addr, Address: app.MyInfo.Addr,
ClusterName: app.ClusterName, ClusterName: app.ClusterName,
IdTime: app.MyInfo.IdTime, // XXX ok? IdTime: app.MyInfo.IdTime, // XXX ok?
...@@ -146,8 +146,8 @@ func (app *NodeApp) Dial(ctx context.Context, peerType proto.NodeType, addr stri ...@@ -146,8 +146,8 @@ func (app *NodeApp) Dial(ctx context.Context, peerType proto.NodeType, addr stri
return nil, nil, fmt.Errorf("accepted, but peer is not %v (identifies as %v)", peerType, accept.NodeType) return nil, nil, fmt.Errorf("accepted, but peer is not %v (identifies as %v)", peerType, accept.NodeType)
} }
// XXX accept.MyUUID, link // XXX register .NodeTab? no -> LinkTab as NodeTab is driven by M // XXX accept.MyNID, link // XXX register .NodeTab? no -> LinkTab as NodeTab is driven by M
// XXX accept.YourUUID // XXX M can tell us to change UUID -> take in effect // XXX accept.YourNID // XXX M can tell us to change NID -> take in effect
// XXX accept.NumPartitions, ... wrt app.node.PartTab // XXX accept.NumPartitions, ... wrt app.node.PartTab
log.Info(ctx, "identification accepted") log.Info(ctx, "identification accepted")
...@@ -232,7 +232,7 @@ func (app *NodeApp) UpdateNodeTab(ctx context.Context, msg *proto.NotifyNodeInfo ...@@ -232,7 +232,7 @@ func (app *NodeApp) UpdateNodeTab(ctx context.Context, msg *proto.NotifyNodeInfo
// XXX we have to provide IdTime when requesting identification to other peers // XXX we have to provide IdTime when requesting identification to other peers
// (e.g. Spy checks this is what master broadcast them and if not replies "unknown by master") // (e.g. Spy checks this is what master broadcast them and if not replies "unknown by master")
if nodeInfo.UUID == app.MyInfo.UUID { if nodeInfo.NID == app.MyInfo.NID {
// XXX recheck locking // XXX recheck locking
// XXX do .MyInfo = nodeInfo ? // XXX do .MyInfo = nodeInfo ?
app.MyInfo.IdTime = nodeInfo.IdTime app.MyInfo.IdTime = nodeInfo.IdTime
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment