Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
N
neo
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Jobs
  • Commits
  • Kirill Smelkov
  • neo
  • Merge Requests
  • !1

Closed
Opened Jan 11, 2023 by Levin Zimmermann@levin.zimmermann
  • Report abuse
Report abuse

WIP: Fix discrepancy between NEO/go and NEO/py: Expand ~ in TLS key/certificate file paths

Good day Kirill,

as we discussed in nexedi/slapos!1307 (closed) I started to work on a patch for NEO/go which lets NEO/go expand the ~ prefix for the TLS key/certificate file paths.

I implemented the functionality in the new xpath package (maybe it's rather an extension of os/user than of path?).

I locally run go test in neo/go/neo path and tests passed so far.

While I added unit tests for the new ExpandTilde function, I didn't add specific tests inside client_tests yet. My initial idea is to add one more option to NEOPySrv which declares whether the base path for the certificates/keys is with ~ or without ~. Then we switch between this new option here. Does this sound reasonable to you?

Best, Levin

/cc @kirr

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://lab.nexedi.com/levin.zimmermann/neoppod.git twtilde
git checkout -b levin.zimmermann/neoppod-twtilde FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/t
git merge --no-ff levin.zimmermann/neoppod-twtilde

Step 4. Push the result of the merge to GitLab

git push origin t

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 13
  • Commits 2
  • Changes 3
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: kirr/neo!1
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7