Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
N neo
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • Kirill Smelkov
  • neo
  • Merge requests
  • !1

Closed
Created Jan 11, 2023 by Levin Zimmermann@levin.zimmermann
  • Report abuse
Report abuse

WIP: Fix discrepancy between NEO/go and NEO/py: Expand ~ in TLS key/certificate file paths

  • Overview 13
  • Commits 2
  • Changes 3

Good day Kirill,

as we discussed in nexedi/slapos!1307 (closed) I started to work on a patch for NEO/go which lets NEO/go expand the ~ prefix for the TLS key/certificate file paths.

I implemented the functionality in the new xpath package (maybe it's rather an extension of os/user than of path?).

I locally run go test in neo/go/neo path and tests passed so far.

While I added unit tests for the new ExpandTilde function, I didn't add specific tests inside client_tests yet. My initial idea is to add one more option to NEOPySrv which declares whether the base path for the certificates/keys is with ~ or without ~. Then we switch between this new option here. Does this sound reasonable to you?

Best, Levin

/cc @kirr

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: twtilde
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7