.

wcfs/client/wcfs.cpp

@@ -1160,7 +1160,7 @@ error _Mapping::unmap() {
 //
 // The following locks must be held by caller:
 // - f.wconn.atMu
-// - f._mmapMu          XXX not needed? (f._mmaps and f._pinned are not used)
+// - f._mmapMu
 error _Mapping::_remmapblk(int64_t blk, zodb::Tid at) {
     // XXX must not be called after Mapping is switched to efault?
 

wcfs/client/wcfs.h

@@ -230,7 +230,7 @@ struct _FileH : object {
     Conn        wconn;
     zodb::Oid   foid;       // ZBigFile root object ID (does not change after fileh open)
 
-    // protect by wconn._filehMu
+    // protected by wconn._filehMu
     _FileHState _state;  // opening/opened/closing/closed
     int         _nopen;  // number of times Conn.open returned this fileh
 
@@ -278,6 +278,7 @@ struct _Mapping : object {
     FileH   fileh;
     int64_t blk_start;  // offset of this mapping in file
 
+    // protected by fileh._mmapMu
     uint8_t  *mem_start;    // mmapped memory [mem_start, mem_stop)
     uint8_t  *mem_stop;
     VMA      *vma;          // mmapped under this virtmem VMA | nil if created standalone from virtmem