.

wcfs/misc.go

@@ -415,16 +415,24 @@ func (sk *FileSock) Close() error {
 	return err
 }
 
-// Flush implements nodefs.File to handle close(file) call.
-// XXX -> Release?
+// Release implements nodefs.File to handle when last user reference to the file is gone.
+//
+// Note: it is not Flush, since Fush is called on close(file) and in general
+// multiple time (e.g. in case of duplicated file descriptor).
+//
 // XXX -> call dtor on release?
-func (f *skFile) Flush() fuse.Status {
+func (f *skFile) Release() {
 	err := f.rx.Close()
 	err2 := f.tx.Close()
 	if err == nil {
 		err = err2
 	}
-	return err2LogStatus(err)
+
+	// the kernel ignores any error return from release.
+	// close on pipes always returns nil and can be called multiple times.
+	if err != nil {
+		panic(err)
+	}
 }
 
 

wcfs/wcfs.go

@@ -1409,7 +1409,6 @@ func (wlink *WatchLink) setupWatch(ctx context.Context, foid zodb.Oid, at zodb.T
 	for blk, rev := range toPin {
 		blk := blk
 		rev := rev
-		//fmt.Printf("S: watch: -> pin #%d @%s\n", blk, rev)
 		wg.Go(func() error {
 			return w.pin(ctx, blk, rev)
 		})