go/neo/neonet: Demonstrate problem in handshake with NEO/py (b2da69e2) · Commits · Levin Zimmermann / neoppod

mentioned in commit 052856ce

...	@@ -67,6 +67,12 @@ type _VersionMismatchError struct {	...	@@ -67,6 +67,12 @@ type _VersionMismatchError struct {
	RemoteVer uint32		RemoteVer uint32
	}		}

			// _EncodingMismatchError is reported as cause when handshake detects that peer does not accept our encoding.
			type _EncodingMismatchError struct {
			LocalEnc proto.Encoding
			RemoteEnc proto.Encoding
			}

	func (e *_HandshakeError) Error() string {		func (e *_HandshakeError) Error() string {
	role := ""		role := ""
	switch e.LocalRole {		switch e.LocalRole {
...	@@ -83,6 +89,9 @@ func (e *_HandshakeError) Unwrap() error { return e.Err }	...	@@ -83,6 +89,9 @@ func (e *_HandshakeError) Unwrap() error { return e.Err }
	func (e *_VersionMismatchError) Error() string {		func (e *_VersionMismatchError) Error() string {
	return fmt.Sprintf("protocol version mismatch: peer = %08x ; our side = %08x", e.RemoteVer, e.LocalVer)		return fmt.Sprintf("protocol version mismatch: peer = %08x ; our side = %08x", e.RemoteVer, e.LocalVer)
	}		}
			func (e *_EncodingMismatchError) Error() string {
			return fmt.Sprintf("protocol encoding mismatch: peer = %q ; our side = %q", e.RemoteEnc, e.LocalEnc)
			}

	// handshakeClient implements client-side NEO protocol handshake just after raw		// handshakeClient implements client-side NEO protocol handshake just after raw
	// connection between 2 nodes was established.		// connection between 2 nodes was established.
...		...

...	@@ -110,9 +110,53 @@ func _TestHandshake(t *T) {	...	@@ -110,9 +110,53 @@ func _TestHandshake(t *T) {
	err2, estr(err2), e2ok, e2ok.Error())		err2, estr(err2), e2ok, e2ok.Error())
	}		}

	// tx & rx problem (client)		// encoding mismatch (mimic behaviour of NEO/py server who does not accept client-proposed encoding)
	p1, p2 = net.Pipe()		p1, p2 = net.Pipe()
	var err error		var err error
			var srvEnc proto.Encoding
			switch t.enc {
			case 'N': srvEnc = 'M'
			case 'M': srvEnc = 'N'
			default: panic("bug")
			}
			wg = xsync.NewWorkGroup(bg)
			gox(wg, func(ctx context.Context) {
			_, _, err = _handshakeClient(ctx, p1, 1, t.enc)
			})
			gox(wg, func(ctx context.Context) {
			wg := xsync.NewWorkGroup(ctx)
			gox(wg, func(ctx context.Context) {
			err := txHello("tx hello", p2, 1, srvEnc)
			exc.Raiseif(err)
			})

			gox(wg, func(ctx context.Context) {
			rxbuf := newXBufReader(p2, 1024)
			_, _, err := rxHello("rx hello", rxbuf)
			exc.Raiseif(err)
			})
			xwait(wg)
			})
			xwait(wg)
			xclose(p1)
			xclose(p2)

			eok := &_HandshakeError{
			LocalRole: _LinkClient,
			LocalAddr: p1.LocalAddr(),
			RemoteAddr: p1.RemoteAddr(),
			Err: &_EncodingMismatchError{
			LocalEnc: t.enc,
			RemoteEnc: srvEnc,
			},
			}
			if !reflect.DeepEqual(err, eok) {
			t.Errorf("handshake encoding mismatch: client: unexpected error:\nhave: %#v\n %q\nwant: %#v\n %q",
			err, estr(err), eok, eok.Error())
			}

			// tx & rx problem (client)
			p1, p2 = net.Pipe()
	wg = xsync.NewWorkGroup(bg)		wg = xsync.NewWorkGroup(bg)
	gox(wg, func(ctx context.Context) {		gox(wg, func(ctx context.Context) {
	_, _, err = _handshakeClient(ctx, p1, 1, t.enc)		_, _, err = _handshakeClient(ctx, p1, 1, t.enc)
...		...