Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
083179e9
Commit
083179e9
authored
Jun 27, 2017
by
Shinya Maeda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add a test for checking validates :key does not override by concern
parent
41aebaa1
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
34 additions
and
0 deletions
+34
-0
spec/models/ci/variable_spec.rb
spec/models/ci/variable_spec.rb
+34
-0
No files found.
spec/models/ci/variable_spec.rb
View file @
083179e9
...
@@ -6,6 +6,40 @@ describe Ci::Variable, models: true do
...
@@ -6,6 +6,40 @@ describe Ci::Variable, models: true do
it
{
is_expected
.
to
be_kind_of
(
HasVariable
)
}
it
{
is_expected
.
to
be_kind_of
(
HasVariable
)
}
it
{
is_expected
.
to
validate_uniqueness_of
(
:key
).
scoped_to
(
:project_id
)
}
it
{
is_expected
.
to
validate_uniqueness_of
(
:key
).
scoped_to
(
:project_id
)
}
describe
'validates :key'
do
let
(
:project
)
{
create
(
:project
)
}
it
'be invalid if it exceeds maximum'
do
expect
do
create
(
:ci_variable
,
project:
project
,
key:
"A"
*
256
)
end
.
to
raise_error
(
ActiveRecord
::
RecordInvalid
)
end
it
'be invalid if violates constraints'
do
expect
do
create
(
:ci_variable
,
project:
project
,
key:
"*"
)
end
.
to
raise_error
(
ActiveRecord
::
RecordInvalid
)
end
context
'when there is a variable'
do
before
do
create
(
:ci_variable
,
key:
'AAA'
,
project:
project
)
end
it
'be valid if it is unique'
do
expect
do
create
(
:ci_variable
,
project:
project
,
key:
'CCC'
)
end
.
not_to
raise_error
end
it
'be invalid if it is duplicated'
do
expect
do
create
(
:ci_variable
,
project:
project
,
key:
'AAA'
)
end
.
to
raise_error
(
ActiveRecord
::
RecordInvalid
)
end
end
end
describe
'.unprotected'
do
describe
'.unprotected'
do
subject
{
described_class
.
unprotected
}
subject
{
described_class
.
unprotected
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment