Skip to content

G
gitlab-ce
Commit 19dc2fb0 authored by Brett Walker's avatar Brett Walker Committed by Fatih Acet
Browse files
Options

Fix TaskListToggleService specs

parent 58cd21c2
Show whitespace changes
Inline Side-by-side
Showing with 81 additions and 40 deletions
spec/services/task_list_toggle_service_spec.rb
View file @ 19dc2fb0
...@@ -4,6 +4,7 @@ require 'spec_helper' ...@@ -4,6 +4,7 @@ require 'spec_helper'
describe TaskListToggleService do describe TaskListToggleService do
context 'when ' do context 'when ' do
let(:sourcepos) { true }
let(:markdown) do let(:markdown) do
<<-EOT.strip_heredoc <<-EOT.strip_heredoc
* [ ] Task 1 * [ ] Task 1
...@@ -18,20 +19,20 @@ describe TaskListToggleService do ...@@ -18,20 +19,20 @@ describe TaskListToggleService do
let(:markdown_html) do let(:markdown_html) do
<<-EOT.strip_heredoc <<-EOT.strip_heredoc
<ul class="task-list" dir="auto"> <ul data-sourcepos="1:1-3:0" class="task-list" dir="auto">
<li class="task-list-item"> <li data-sourcepos="1:1-1:12" class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Task 1 <input type="checkbox" class="task-list-item-checkbox" disabled> Task 1
</li> </li>
<li class="task-list-item"> <li data-sourcepos="2:1-3:0" class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled checked> Task 2 <input type="checkbox" class="task-list-item-checkbox" disabled checked> Task 2
</li> </li>
</ul> </ul>
<p dir="auto">A paragraph</p> <p data-sourcepos="4:1-4:11" dir="auto">A paragraph</p>
<ol class="task-list" dir="auto"> <ol data-sourcepos="6:1-7:19" class="task-list" dir="auto">
<li class="task-list-item"> <li data-sourcepos="6:1-7:19" class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled checked> Item 1 <input type="checkbox" class="task-list-item-checkbox" disabled checked> Item 1
<ul class="task-list"> <ul data-sourcepos="7:4-7:19" class="task-list">
<li class="task-list-item"> <li data-sourcepos="7:4-7:19" class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Sub-item 1 <input type="checkbox" class="task-list-item-checkbox" disabled> Sub-item 1
</li> </li>
</ul> </ul>
...@@ -40,10 +41,12 @@ describe TaskListToggleService do ...@@ -40,10 +41,12 @@ describe TaskListToggleService do
EOT EOT
end end
shared_examples 'task lists' do
it 'checks Task 1' do it 'checks Task 1' do
toggler = described_class.new(markdown, markdown_html, toggler = described_class.new(markdown, markdown_html,
index: 1, currently_checked: false, index: 1, toggle_as_checked: true,
line_source: '* [ ] Task 1', line_number: 1) line_source: '* [ ] Task 1', line_number: 1,
sourcepos: sourcepos)
expect(toggler.execute).to be_truthy expect(toggler.execute).to be_truthy
expect(toggler.updated_markdown.lines[0]).to eq "* [x] Task 1\n" expect(toggler.updated_markdown.lines[0]).to eq "* [x] Task 1\n"
...@@ -52,8 +55,9 @@ describe TaskListToggleService do ...@@ -52,8 +55,9 @@ describe TaskListToggleService do
it 'unchecks Item 1' do it 'unchecks Item 1' do
toggler = described_class.new(markdown, markdown_html, toggler = described_class.new(markdown, markdown_html,
index: 3, currently_checked: true, index: 3, toggle_as_checked: false,
line_source: '1. [X] Item 1', line_number: 6) line_source: '1. [X] Item 1', line_number: 6,
sourcepos: sourcepos)
expect(toggler.execute).to be_truthy expect(toggler.execute).to be_truthy
expect(toggler.updated_markdown.lines[5]).to eq "1. [ ] Item 1\n" expect(toggler.updated_markdown.lines[5]).to eq "1. [ ] Item 1\n"
...@@ -62,26 +66,63 @@ describe TaskListToggleService do ...@@ -62,26 +66,63 @@ describe TaskListToggleService do
it 'returns false if line_source does not match the text' do it 'returns false if line_source does not match the text' do
toggler = described_class.new(markdown, markdown_html, toggler = described_class.new(markdown, markdown_html,
index: 2, currently_checked: true, index: 2, toggle_as_checked: false,
line_source: '* [x] Task Added', line_number: 2) line_source: '* [x] Task Added', line_number: 2,
sourcepos: sourcepos)
expect(toggler.execute).to be_falsey expect(toggler.execute).to be_falsey
end end
it 'returns false if markdown is nil' do it 'returns false if markdown is nil' do
toggler = described_class.new(nil, markdown_html, toggler = described_class.new(nil, markdown_html,
index: 2, currently_checked: true, index: 2, toggle_as_checked: false,
line_source: '* [x] Task Added', line_number: 2) line_source: '* [x] Task Added', line_number: 2,
sourcepos: sourcepos)
expect(toggler.execute).to be_falsey expect(toggler.execute).to be_falsey
end end
it 'returns false if markdown_html is nil' do it 'returns false if markdown_html is nil' do
toggler = described_class.new(markdown, nil, toggler = described_class.new(markdown, nil,
index: 2, currently_checked: true, index: 2, toggle_as_checked: false,
line_source: '* [x] Task Added', line_number: 2) line_source: '* [x] Task Added', line_number: 2,
sourcepos: sourcepos)
expect(toggler.execute).to be_falsey expect(toggler.execute).to be_falsey
end end
end end
context 'when using sourcepos' do
it_behaves_like 'task lists'
end
context 'when using checkbox indexing' do
let(:sourcepos) { false }
let(:markdown_html) do
<<-EOT.strip_heredoc
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Task 1
</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled checked> Task 2
</li>
</ul>
<p dir="auto">A paragraph</p>
<ol class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled checked> Item 1
<ul class="task-list">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Sub-item 1
</li>
</ul>
</li>
</ol>
EOT
end
it_behaves_like 'task lists'
end
end
end end
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7