Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
2378dde2
Commit
2378dde2
authored
Apr 02, 2019
by
Donald Cook
Committed by
Clement Ho
Apr 02, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove non-functional add issue button on welcome list
parent
5570ce7d
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
24 additions
and
2 deletions
+24
-2
app/assets/javascripts/boards/components/board.js
app/assets/javascripts/boards/components/board.js
+4
-1
app/assets/stylesheets/pages/boards.scss
app/assets/stylesheets/pages/boards.scss
+1
-1
changelogs/unreleased/55980-remove-add-issue-on-blank-list.yml
...elogs/unreleased/55980-remove-add-issue-on-blank-list.yml
+5
-0
spec/javascripts/boards/components/board_spec.js
spec/javascripts/boards/components/board_spec.js
+14
-0
No files found.
app/assets/javascripts/boards/components/board.js
View file @
2378dde2
...
...
@@ -54,7 +54,10 @@ export default Vue.extend({
return
`
${
n__
(
'
%d issue
'
,
'
%d issues
'
,
issuesSize
)}
`
;
},
isNewIssueShown
()
{
return
this
.
list
.
type
===
'
backlog
'
||
(
!
this
.
disabled
&&
this
.
list
.
type
!==
'
closed
'
);
return
(
this
.
list
.
type
===
'
backlog
'
||
(
!
this
.
disabled
&&
this
.
list
.
type
!==
'
closed
'
&&
this
.
list
.
type
!==
'
blank
'
)
);
},
},
watch
:
{
...
...
app/assets/stylesheets/pages/boards.scss
View file @
2378dde2
...
...
@@ -234,7 +234,7 @@
}
.board-title-text
{
margin
-right
:
auto
;
margin
:
$gl-vert-padding
auto
$gl-vert-padding
0
;
}
.board-delete
{
...
...
changelogs/unreleased/55980-remove-add-issue-on-blank-list.yml
0 → 100644
View file @
2378dde2
---
title
:
Remove non-functional add issue button on welcome list
merge_request
:
!26742
author
:
type
:
fixed
spec/javascripts/boards/components/board_spec.js
View file @
2378dde2
...
...
@@ -103,4 +103,18 @@ describe('Board component', () => {
})
.
catch
(
done
.
fail
);
});
it
(
'
does render add issue button
'
,
()
=>
{
expect
(
vm
.
$el
.
querySelector
(
'
.issue-count-badge-add-button
'
)).
not
.
toBeNull
();
});
it
(
'
does not render add issue button when list type is blank
'
,
done
=>
{
vm
.
list
.
type
=
'
blank
'
;
Vue
.
nextTick
(()
=>
{
expect
(
vm
.
$el
.
querySelector
(
'
.issue-count-badge-add-button
'
)).
toBeNull
();
done
();
});
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment