Merge branch 'fix-qa-auto-devops-before-all' into 'master'

Fix QA spec sharing project in the wrong context

Closes gitlab-org/quality/nightly#54

See merge request gitlab-org/gitlab-ce!24183

qa/qa/specs/features/browser_ui/7_configure/auto_devops/create_project_with_auto_devops_spec.rb

@@ -10,12 +10,14 @@ module QA
         Page::Main::Login.act { sign_in_using_credentials }
       end
 
+      [true, false].each do |rbac|
+        context "when rbac is #{rbac ? 'enabled' : 'disabled'}" do
           before(:all) do
             login
 
             @project = Resource::Project.fabricate! do |p|
               p.name = Runtime::Env.auto_devops_project_name || 'project-with-autodevops'
-          p.description = 'Project with Auto Devops'
+              p.description = 'Project with Auto DevOps'
             end
 
             # Disable code_quality check in Auto DevOps pipeline as it takes
@@ -26,7 +28,7 @@ module QA
               resource.value = '1'
             end
 
-        # Create Auto Devops compatible repo
+            # Create Auto DevOps compatible repo
             Resource::Repository::ProjectPush.fabricate! do |push|
               push.project = @project
               push.directory = Pathname
@@ -36,11 +38,7 @@ module QA
             end
 
             Page::Project::Show.act { wait_for_push }
-      end
 
-      [true, false].each do |rbac|
-        context "when rbac is #{rbac ? 'enabled' : 'disabled'}" do
-          before(:all) do
             # Create and connect K8s cluster
             @cluster = Service::KubernetesCluster.new(rbac: rbac).create!
             kubernetes_cluster = Resource::KubernetesCluster.fabricate! do |cluster|