Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
5a7a221f
Commit
5a7a221f
authored
Nov 30, 2018
by
Filipa Lacerda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixes tooltip overflowing in mini pipeline
parent
93d6f569
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
33 deletions
+1
-33
app/assets/javascripts/pipelines/components/graph/job_item.vue
...ssets/javascripts/pipelines/components/graph/job_item.vue
+1
-5
spec/javascripts/pipelines/graph/job_item_spec.js
spec/javascripts/pipelines/graph/job_item_spec.js
+0
-28
No files found.
app/assets/javascripts/pipelines/components/graph/job_item.vue
View file @
5a7a221f
...
@@ -84,10 +84,6 @@ export default {
...
@@ -84,10 +84,6 @@ export default {
return
textBuilder
.
join
(
'
'
);
return
textBuilder
.
join
(
'
'
);
},
},
tooltipBoundary
()
{
return
this
.
dropdownLength
<
5
?
'
viewport
'
:
null
;
},
/**
/**
* Verifies if the provided job has an action path
* Verifies if the provided job has an action path
*
*
...
@@ -108,7 +104,7 @@ export default {
...
@@ -108,7 +104,7 @@ export default {
<div
class=
"ci-job-component"
>
<div
class=
"ci-job-component"
>
<gl-link
<gl-link
v-if=
"status.has_details"
v-if=
"status.has_details"
v-gl-tooltip
=
"
{ boundary: tooltipBoundary }"
v-gl-tooltip
:href=
"status.details_path"
:href=
"status.details_path"
:title=
"tooltipText"
:title=
"tooltipText"
:class=
"cssClassJobName"
:class=
"cssClassJobName"
...
...
spec/javascripts/pipelines/graph/job_item_spec.js
View file @
5a7a221f
...
@@ -139,34 +139,6 @@ describe('pipeline graph job item', () => {
...
@@ -139,34 +139,6 @@ describe('pipeline graph job item', () => {
});
});
});
});
describe
(
'
tooltip placement
'
,
()
=>
{
it
(
'
does not set tooltip boundary by default
'
,
()
=>
{
component
=
mountComponent
(
JobComponent
,
{
job
:
mockJob
,
});
expect
(
component
.
tooltipBoundary
).
toBeNull
();
});
it
(
'
sets tooltip boundary to viewport for small dropdowns
'
,
()
=>
{
component
=
mountComponent
(
JobComponent
,
{
job
:
mockJob
,
dropdownLength
:
1
,
});
expect
(
component
.
tooltipBoundary
).
toEqual
(
'
viewport
'
);
});
it
(
'
does not set tooltip boundary for large lists
'
,
()
=>
{
component
=
mountComponent
(
JobComponent
,
{
job
:
mockJob
,
dropdownLength
:
7
,
});
expect
(
component
.
tooltipBoundary
).
toBeNull
();
});
});
describe
(
'
for delayed job
'
,
()
=>
{
describe
(
'
for delayed job
'
,
()
=>
{
beforeEach
(()
=>
{
beforeEach
(()
=>
{
const
fifteenMinutesInMilliseconds
=
900000
;
const
fifteenMinutesInMilliseconds
=
900000
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment