Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
64239828
Commit
64239828
authored
Sep 24, 2013
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Force user to provide old password in order to change it
parent
0630be38
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
59 additions
and
19 deletions
+59
-19
app/controllers/profiles_controller.rb
app/controllers/profiles_controller.rb
+8
-1
app/views/profiles/account.html.haml
app/views/profiles/account.html.haml
+27
-18
features/profile/profile.feature
features/profile/profile.feature
+6
-0
features/steps/profile/profile.rb
features/steps/profile/profile.rb
+18
-0
No files found.
app/controllers/profiles_controller.rb
View file @
64239828
...
@@ -33,7 +33,14 @@ class ProfilesController < ApplicationController
...
@@ -33,7 +33,14 @@ class ProfilesController < ApplicationController
end
end
def
update_password
def
update_password
params
[
:user
].
reject!
{
|
k
,
v
|
k
!=
"password"
&&
k
!=
"password_confirmation"
}
params
[
:user
].
select!
do
|
key
,
value
|
%w(current_password password password_confirmation)
.
include?
(
key
.
to_s
)
end
unless
@user
.
valid_password?
(
params
[
:user
][
:current_password
])
redirect_to
account_profile_path
,
alert:
'You must provide a valid current password'
return
end
if
@user
.
update_attributes
(
params
[
:user
])
if
@user
.
update_attributes
(
params
[
:user
])
flash
[
:notice
]
=
"Password was successfully updated. Please login with it"
flash
[
:notice
]
=
"Password was successfully updated. Please login with it"
...
...
app/views/profiles/account.html.haml
View file @
64239828
...
@@ -57,16 +57,25 @@
...
@@ -57,16 +57,25 @@
.tab-pane
#tab-password
.tab-pane
#tab-password
%fieldset
.update-password
%fieldset
.update-password
%legend
Password
%legend
Password
-
if
current_user
.
ldap_user?
%h3
.nothing_here_message
Not available for LDAP user
-
else
=
form_for
@user
,
url:
update_password_profile_path
,
method: :put
do
|
f
|
=
form_for
@user
,
url:
update_password_profile_path
,
method: :put
do
|
f
|
%div
%div
%p
.slead
After a successful password update you will be redirected to login page where you should login with your new password
%p
.slead
You must provide current password in order to change it.
%br
After a successful password update you will be redirected to login page where you should login with your new password
-
if
@user
.
errors
.
any?
-
if
@user
.
errors
.
any?
.alert.alert-error
.alert.alert-error
%ul
%ul
-
@user
.
errors
.
full_messages
.
each
do
|
msg
|
-
@user
.
errors
.
full_messages
.
each
do
|
msg
|
%li
=
msg
%li
=
msg
.control-group
.control-group
=
f
.
label
:password
=
f
.
label
:current_password
,
class:
'cgreen'
.controls
=
f
.
password_field
:current_password
,
required:
true
.control-group
=
f
.
label
:password
,
'New password'
.controls
=
f
.
password_field
:password
,
required:
true
.controls
=
f
.
password_field
:password
,
required:
true
.control-group
.control-group
=
f
.
label
:password_confirmation
=
f
.
label
:password_confirmation
...
...
features/profile/profile.feature
View file @
64239828
...
@@ -11,6 +11,12 @@ Feature: Profile
...
@@ -11,6 +11,12 @@ Feature: Profile
Then
I change my contact info
Then
I change my contact info
And
I should see new contact info
And
I should see new contact info
Scenario
:
I
change my password without old one
Given
I visit profile account page
When
I try change my password w/o old one
Then
I should see a missing password error message
And
I should be redirected to account page
Scenario
:
I
change my password
Scenario
:
I
change my password
Given
I visit profile account page
Given
I visit profile account page
Then
I change my password
Then
I change my password
...
...
features/steps/profile/profile.rb
View file @
64239828
...
@@ -22,8 +22,17 @@ class Profile < Spinach::FeatureSteps
...
@@ -22,8 +22,17 @@ class Profile < Spinach::FeatureSteps
@user
.
twitter
.
should
==
'testtwitter'
@user
.
twitter
.
should
==
'testtwitter'
end
end
step
'I try change my password w/o old one'
do
within
'.update-password'
do
fill_in
"user_password"
,
with:
"222333"
fill_in
"user_password_confirmation"
,
with:
"222333"
click_button
"Save"
end
end
step
'I change my password'
do
step
'I change my password'
do
within
'.update-password'
do
within
'.update-password'
do
fill_in
"user_current_password"
,
with:
"123456"
fill_in
"user_password"
,
with:
"222333"
fill_in
"user_password"
,
with:
"222333"
fill_in
"user_password_confirmation"
,
with:
"222333"
fill_in
"user_password_confirmation"
,
with:
"222333"
click_button
"Save"
click_button
"Save"
...
@@ -32,12 +41,17 @@ class Profile < Spinach::FeatureSteps
...
@@ -32,12 +41,17 @@ class Profile < Spinach::FeatureSteps
step
'I unsuccessfully change my password'
do
step
'I unsuccessfully change my password'
do
within
'.update-password'
do
within
'.update-password'
do
fill_in
"user_current_password"
,
with:
"123456"
fill_in
"user_password"
,
with:
"password"
fill_in
"user_password"
,
with:
"password"
fill_in
"user_password_confirmation"
,
with:
"confirmation"
fill_in
"user_password_confirmation"
,
with:
"confirmation"
click_button
"Save"
click_button
"Save"
end
end
end
end
step
"I should see a missing password error message"
do
page
.
should
have_content
"You must provide a valid current password"
end
step
"I should see a password error message"
do
step
"I should see a password error message"
do
page
.
should
have_content
"Password doesn't match confirmation"
page
.
should
have_content
"Password doesn't match confirmation"
end
end
...
@@ -110,6 +124,10 @@ class Profile < Spinach::FeatureSteps
...
@@ -110,6 +124,10 @@ class Profile < Spinach::FeatureSteps
current_path
.
should
==
new_user_session_path
current_path
.
should
==
new_user_session_path
end
end
step
'I should be redirected to account page'
do
current_path
.
should
==
account_profile_path
end
step
'I click on my profile picture'
do
step
'I click on my profile picture'
do
click_link
'profile-pic'
click_link
'profile-pic'
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment