Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
7eee6cd2
Commit
7eee6cd2
authored
Jul 17, 2018
by
Alexis Reigel
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
convert admin runners table to responsive table
parent
34bdb747
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
100 additions
and
80 deletions
+100
-80
app/views/admin/runners/_runner.html.haml
app/views/admin/runners/_runner.html.haml
+77
-50
app/views/admin/runners/index.html.haml
app/views/admin/runners/index.html.haml
+13
-16
spec/features/admin/admin_runners_spec.rb
spec/features/admin/admin_runners_spec.rb
+10
-14
No files found.
app/views/admin/runners/_runner.html.haml
View file @
7eee6cd2
%tr
{
id:
dom_id
(
runner
)
}
%td
.gl-responsive-table-row
{
id:
dom_id
(
runner
)
}
.table-section.section-10
.table-mobile-header
{
role:
"rowheader"
}
Type
.table-mobile-content
-
if
runner
.
instance_type?
%span
.badge.badge-success
shared
-
elsif
runner
.
group_type?
...
...
@@ -11,41 +13,66 @@
-
unless
runner
.
active?
%span
.badge.badge-danger
paused
%td
=
link_to
admin_runner_path
(
runner
)
do
=
runner
.
short_sha
%td
.table-section.section-10
.table-mobile-header
{
role:
'rowheader'
}
Runner token
.table-mobile-content
=
link_to
runner
.
short_sha
,
admin_runner_path
(
runner
)
.table-section.section-10
.table-mobile-header
{
role:
'rowheader'
}
Description
.table-mobile-content
=
runner
.
description
%td
.table-section.section-10
.table-mobile-header
{
role:
'rowheader'
}
Version
.table-mobile-content
=
runner
.
version
%td
.table-section.section-10
.table-mobile-header
{
role:
'rowheader'
}
IP Address
.table-mobile-content
=
runner
.
ip_address
%td
.table-section.section-10
.table-mobile-header
{
role:
'rowheader'
}
Projects
.table-mobile-content
-
if
runner
.
instance_type?
||
runner
.
group_type?
n/a
-
else
=
runner
.
projects
.
count
(
:all
)
%td
#{
runner
.
builds
.
count
(
:all
)
}
%td
.table-section.section-10
.table-mobile-header
{
role:
'rowheader'
}
Jobs
.table-mobile-content
=
runner
.
builds
.
count
(
:all
)
.table-section.section-10
.table-mobile-header
{
role:
'rowheader'
}
Tags
.table-mobile-content
-
runner
.
tag_list
.
sort
.
each
do
|
tag
|
%span
.badge.badge-primary
=
tag
%td
.table-section.section-10
.table-mobile-header
{
role:
'rowheader'
}
Last contact
.table-mobile-content
-
if
runner
.
contacted_at
=
time_ago_with_tooltip
runner
.
contacted_at
-
else
Never
%td
.admin-runner-btn-group-cell
.float-right.btn-group
=
link_to
admin_runner_path
(
runner
),
class:
'btn btn-sm btn-default has-tooltip'
,
title:
'Edit'
,
ref:
'tooltip'
,
aria:
{
label:
'Edit'
},
data:
{
placement:
'top'
,
container:
'body'
}
do
.table-section.table-button-footer.section-10
.btn-group.table-action-buttons
.btn-group
=
link_to
admin_runner_path
(
runner
),
class:
'btn btn-default has-tooltip'
,
title:
'Edit'
,
ref:
'tooltip'
,
aria:
{
label:
'Edit'
},
data:
{
placement:
'top'
,
container:
'body'
}
do
=
icon
(
'pencil'
)
.btn-group
-
if
runner
.
active?
=
link_to
[
:pause
,
:admin
,
runner
],
method: :get
,
class:
'btn btn-sm
btn-default has-tooltip'
,
title:
'Pause'
,
ref:
'tooltip'
,
aria:
{
label:
'Pause'
},
data:
{
placement:
'top'
,
container:
'body'
,
confirm:
"Are you sure?"
}
do
=
link_to
[
:pause
,
:admin
,
runner
],
method: :get
,
class:
'btn
btn-default has-tooltip'
,
title:
'Pause'
,
ref:
'tooltip'
,
aria:
{
label:
'Pause'
},
data:
{
placement:
'top'
,
container:
'body'
,
confirm:
"Are you sure?"
}
do
=
icon
(
'pause'
)
-
else
=
link_to
[
:resume
,
:admin
,
runner
],
method: :get
,
class:
'btn btn-default btn-sm
has-tooltip'
,
title:
'Resume'
,
ref:
'tooltip'
,
aria:
{
label:
'Resume'
},
data:
{
placement:
'top'
,
container:
'body'
}
do
=
link_to
[
:resume
,
:admin
,
runner
],
method: :get
,
class:
'btn btn-default
has-tooltip'
,
title:
'Resume'
,
ref:
'tooltip'
,
aria:
{
label:
'Resume'
},
data:
{
placement:
'top'
,
container:
'body'
}
do
=
icon
(
'play'
)
=
link_to
[
:admin
,
runner
],
method: :delete
,
class:
'btn btn-danger btn-sm has-tooltip'
,
title:
'Remove'
,
ref:
'tooltip'
,
aria:
{
label:
'Remove'
},
data:
{
placement:
'top'
,
container:
'body'
,
confirm:
"Are you sure?"
}
do
.btn-group
=
link_to
[
:admin
,
runner
],
method: :delete
,
class:
'btn btn-danger has-tooltip'
,
title:
'Remove'
,
ref:
'tooltip'
,
aria:
{
label:
'Remove'
},
data:
{
placement:
'top'
,
container:
'body'
,
confirm:
"Are you sure?"
}
do
=
icon
(
'remove'
)
app/views/admin/runners/index.html.haml
View file @
7eee6cd2
...
...
@@ -92,21 +92,18 @@
%br
-
if
@runners
.
any?
.runners-content
.runners-content
.content-list
.table-holder
%table
.table
%thead
%tr
%th
Type
%th
Runner token
%th
Description
%th
Version
%th
IP Address
%th
Projects
%th
Jobs
%th
Tags
%th
Last contact
%th
.gl-responsive-table-row.table-row-header
{
role:
'row'
}
.table-section.section-10
{
role:
'rowheader'
}
Type
.table-section.section-10
{
role:
'rowheader'
}
Runner token
.table-section.section-10
{
role:
'rowheader'
}
Description
.table-section.section-10
{
role:
'rowheader'
}
Version
.table-section.section-10
{
role:
'rowheader'
}
IP Address
.table-section.section-10
{
role:
'rowheader'
}
Projects
.table-section.section-10
{
role:
'rowheader'
}
Jobs
.table-section.section-10
{
role:
'rowheader'
}
Tags
.table-section.section-10
{
role:
'rowheader'
}
Last contact
-
@runners
.
each
do
|
runner
|
=
render
"admin/runners/runner"
,
runner:
runner
...
...
spec/features/admin/admin_runners_spec.rb
View file @
7eee6cd2
...
...
@@ -99,29 +99,25 @@ describe "Admin Runners", :js do
visit
admin_runners_path
within
'.runners-content tbody'
do
within
(
'tr:nth-child(1)'
)
do
within
'.runners-content .gl-responsive-table-row:nth-child(2)'
do
expect
(
page
).
to
have_content
'runner-2'
end
within
(
'tr:nth-child(2)'
)
do
within
'.runners-content .gl-responsive-table-row:nth-child(3)'
do
expect
(
page
).
to
have_content
'runner-1'
end
end
sorting_by
'Last Contact'
within
'.runners-content tbody'
do
within
(
'tr:nth-child(1)'
)
do
within
'.runners-content .gl-responsive-table-row:nth-child(2)'
do
expect
(
page
).
to
have_content
'runner-1'
end
within
(
'tr:nth-child(2)'
)
do
within
'.runners-content .gl-responsive-table-row:nth-child(3)'
do
expect
(
page
).
to
have_content
'runner-2'
end
end
end
end
context
"when there are no runners"
do
before
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment