Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
869de96e
Commit
869de96e
authored
Apr 01, 2016
by
Lin Jen-Shin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
bang to indicate that this method could raise an exception
parent
aac297ad
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
3 deletions
+3
-3
lib/gitlab/email/receiver.rb
lib/gitlab/email/receiver.rb
+3
-3
No files found.
lib/gitlab/email/receiver.rb
View file @
869de96e
...
@@ -40,7 +40,7 @@ module Gitlab
...
@@ -40,7 +40,7 @@ module Gitlab
author
=
sent_notification
.
recipient
author
=
sent_notification
.
recipient
project
=
sent_notification
.
project
project
=
sent_notification
.
project
validate_permission
(
author
,
project
,
:create_note
)
validate_permission
!
(
author
,
project
,
:create_note
)
raise
NoteableNotFoundError
unless
sent_notification
.
noteable
raise
NoteableNotFoundError
unless
sent_notification
.
noteable
...
@@ -59,7 +59,7 @@ module Gitlab
...
@@ -59,7 +59,7 @@ module Gitlab
end
end
def
process_create_issue
def
process_create_issue
validate_permission
(
message_sender
,
message_project
,
:create_issue
)
validate_permission
!
(
message_sender
,
message_project
,
:create_issue
)
issue
=
Issues
::
CreateService
.
new
(
issue
=
Issues
::
CreateService
.
new
(
message_project
,
message_project
,
...
@@ -78,7 +78,7 @@ module Gitlab
...
@@ -78,7 +78,7 @@ module Gitlab
end
end
end
end
def
validate_permission
(
author
,
project
,
permission
)
def
validate_permission
!
(
author
,
project
,
permission
)
raise
UserNotFoundError
unless
author
raise
UserNotFoundError
unless
author
raise
UserBlockedError
if
author
.
blocked?
raise
UserBlockedError
if
author
.
blocked?
# TODO: Give project not found error if author cannot read project
# TODO: Give project not found error if author cannot read project
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment