Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
9c0f2485
Commit
9c0f2485
authored
May 05, 2017
by
Valery Sizov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Multiple issue assignee: resolve conflicts after merging upstream
parent
40f51c8e
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
20 deletions
+14
-20
app/services/slash_commands/interpret_service.rb
app/services/slash_commands/interpret_service.rb
+13
-19
spec/services/slash_commands/interpret_service_spec.rb
spec/services/slash_commands/interpret_service_spec.rb
+1
-1
No files found.
app/services/slash_commands/interpret_service.rb
View file @
9c0f2485
...
@@ -91,41 +91,35 @@ module SlashCommands
...
@@ -91,41 +91,35 @@ module SlashCommands
end
end
desc
'Assign'
desc
'Assign'
explanation
do
|
user
|
explanation
do
|
user
s
|
"Assigns
#{
user
.
to_reference
}
."
if
user
"Assigns
#{
user
s
.
map
(
&
:to_reference
).
to_sentence
}
."
if
users
.
any?
end
end
params
'@user'
params
'@user'
condition
do
condition
do
current_user
.
can?
(
:"admin_
#{
issuable
.
to_ability_name
}
"
,
project
)
current_user
.
can?
(
:"admin_
#{
issuable
.
to_ability_name
}
"
,
project
)
end
end
<<<<<<<
HEAD
parse_params
do
|
assignee_param
|
command
:assign
do
|
assignee_param
|
users
=
extract_references
(
assignee_param
,
:user
)
user_ids
=
extract_references
(
assignee_param
,
:user
).
map
(
&
:id
)
if
user
_id
s
.
empty?
if
users
.
empty?
user
_ids
=
User
.
where
(
username:
assignee_param
.
split
(
' '
).
map
(
&
:strip
)).
pluck
(
:id
)
user
s
=
User
.
where
(
username:
assignee_param
.
split
(
' '
).
map
(
&
:strip
)
)
end
end
next
if
user_ids
.
empty?
users
end
command
:assign
do
|
users
|
next
if
users
.
empty?
if
issuable
.
is_a?
(
Issue
)
if
issuable
.
is_a?
(
Issue
)
@updates
[
:assignee_ids
]
=
user
_ids
@updates
[
:assignee_ids
]
=
user
s
.
map
(
&
:id
)
else
else
@updates
[
:assignee_id
]
=
user_ids
.
last
@updates
[
:assignee_id
]
=
users
.
last
.
id
end
=======
parse_params
do
|
assignee_param
|
extract_references
(
assignee_param
,
:user
).
first
||
User
.
find_by
(
username:
assignee_param
)
end
end
command
:assign
do
|
user
|
@updates
[
:assignee_id
]
=
user
.
id
if
user
>>>>>>>
10
c1bf2d77fd0ab21309d0b136cbc0ac11f56c77
end
end
desc
'Remove assignee'
desc
'Remove assignee'
explanation
do
explanation
do
"Removes assignee
#{
issuable
.
assignee
.
to_reference
}
."
"Removes assignee
#{
issuable
.
assignee
s
.
first
.
to_reference
}
."
end
end
condition
do
condition
do
issuable
.
persisted?
&&
issuable
.
persisted?
&&
...
...
spec/services/slash_commands/interpret_service_spec.rb
View file @
9c0f2485
...
@@ -874,7 +874,7 @@ describe SlashCommands::InterpretService, services: true do
...
@@ -874,7 +874,7 @@ describe SlashCommands::InterpretService, services: true do
describe
'unassign command'
do
describe
'unassign command'
do
let
(
:content
)
{
'/unassign'
}
let
(
:content
)
{
'/unassign'
}
let
(
:issue
)
{
create
(
:issue
,
project:
project
,
assignee
:
developer
)
}
let
(
:issue
)
{
create
(
:issue
,
project:
project
,
assignee
s:
[
developer
]
)
}
it
'includes current assignee reference'
do
it
'includes current assignee reference'
do
_
,
explanations
=
service
.
explain
(
content
,
issue
)
_
,
explanations
=
service
.
explain
(
content
,
issue
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment