Merge branch '53621-review-app-credentials-does-not-reliably-work' into 'master'

Ensure we create the secrets at the right time

Closes #53621

See merge request gitlab-org/gitlab-ce!22938

.gitlab-ci.yml

@@ -954,7 +954,6 @@ review:
     - download_gitlab_chart
     - ensure_namespace
     - install_tiller
-    - create_secret
     - install_external_dns
     - deploy
   environment:

scripts/review_apps/review-apps.sh

@@ -126,6 +126,9 @@ function deploy() {
     delete
     cleanup
   fi
+
+  create_secret
+
   helm repo add gitlab https://charts.gitlab.io/
   helm dep update .