Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
d6c69373
Commit
d6c69373
authored
Jan 13, 2018
by
Lin Jen-Shin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make sure it's not offending to use local ||= val
parent
72c489e9
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
0 deletions
+14
-0
spec/rubocop/cop/gitlab/predicate_memoization_spec.rb
spec/rubocop/cop/gitlab/predicate_memoization_spec.rb
+14
-0
No files found.
spec/rubocop/cop/gitlab/predicate_memoization_spec.rb
View file @
d6c69373
...
@@ -70,6 +70,20 @@ describe RuboCop::Cop::Gitlab::PredicateMemoization do
...
@@ -70,6 +70,20 @@ describe RuboCop::Cop::Gitlab::PredicateMemoization do
end
end
end
end
context
'when source is a predicate method using local with ||='
do
it_behaves_like
'not registering offense'
do
let
(
:source
)
do
<<~
RUBY
class C
def really?
really ||= true
end
end
RUBY
end
end
end
context
'when source is a regular method memoizing via ivar'
do
context
'when source is a regular method memoizing via ivar'
do
it_behaves_like
'not registering offense'
do
it_behaves_like
'not registering offense'
do
let
(
:source
)
do
let
(
:source
)
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment