Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
d807d381
Commit
d807d381
authored
Aug 31, 2017
by
Maxim Rydkin
Committed by
Grzegorz Bizon
Aug 31, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Decrease ABC threshold to 55.25
parent
6d6223ec
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
48 additions
and
41 deletions
+48
-41
.rubocop.yml
.rubocop.yml
+1
-1
changelogs/unreleased/28202_decrease_abc_threshold_step3.yml
changelogs/unreleased/28202_decrease_abc_threshold_step3.yml
+5
-0
lib/github/import.rb
lib/github/import.rb
+42
-40
No files found.
.rubocop.yml
View file @
d807d381
...
...
@@ -624,7 +624,7 @@ Style/PredicateName:
# branches, and conditions.
Metrics/AbcSize
:
Enabled
:
true
Max
:
5
6.96
Max
:
5
5.25
# This cop checks if the length of a block exceeds some maximum value.
Metrics/BlockLength
:
...
...
changelogs/unreleased/28202_decrease_abc_threshold_step3.yml
0 → 100644
View file @
d807d381
---
title
:
Decrease ABC threshold to
55.25
merge_request
:
13904
author
:
Maxim Rydkin
type
:
other
lib/github/import.rb
View file @
d807d381
...
...
@@ -226,7 +226,13 @@ module Github
while
url
response
=
Github
::
Client
.
new
(
options
).
get
(
url
,
state: :all
,
sort: :created
,
direction: :asc
)
response
.
body
.
each
do
|
raw
|
response
.
body
.
each
{
|
raw
|
populate_issue
(
raw
)
}
url
=
response
.
rels
[
:next
]
end
end
def
populate_issue
(
raw
)
representation
=
Github
::
Representation
::
Issue
.
new
(
raw
,
options
)
begin
...
...
@@ -235,12 +241,12 @@ module Github
# for both features, like manipulating assignees, labels
# and milestones, are provided within the Issues API.
if
representation
.
pull_request?
next
unless
representation
.
has_labels?
return
unless
representation
.
has_labels?
merge_request
=
MergeRequest
.
find_by!
(
target_project_id:
project
.
id
,
iid:
representation
.
iid
)
merge_request
.
update_attribute
(
:label_ids
,
label_ids
(
representation
.
labels
))
else
next
if
Issue
.
where
(
iid:
representation
.
iid
,
project_id:
project
.
id
).
exists?
return
if
Issue
.
where
(
iid:
representation
.
iid
,
project_id:
project
.
id
).
exists?
author_id
=
user_id
(
representation
.
author
,
project
.
creator_id
)
issue
=
Issue
.
new
...
...
@@ -268,10 +274,6 @@ module Github
end
end
url
=
response
.
rels
[
:next
]
end
end
def
fetch_comments
(
noteable
,
type
,
url
,
klass
=
Note
)
while
url
comments
=
Github
::
Client
.
new
(
options
).
get
(
url
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment