Commit fadc58c5 authored by Phil Hughes's avatar Phil Hughes

Merge branch 'vue-eslint' into 'master'

Adds a better explanation for alignment section

Closes #32071

See merge request !14109
parents 39a93e0b 70cc9861
...@@ -311,6 +311,7 @@ A forEach will cause side effects, it will be mutating the array being iterated. ...@@ -311,6 +311,7 @@ A forEach will cause side effects, it will be mutating the array being iterated.
#### Alignment #### Alignment
1. Follow these alignment styles for the template method: 1. Follow these alignment styles for the template method:
1. With more than one attribute, all attributes should be on a new line:
```javascript ```javascript
// bad // bad
<component v-if="bar" <component v-if="bar"
...@@ -327,9 +328,16 @@ A forEach will cause side effects, it will be mutating the array being iterated. ...@@ -327,9 +328,16 @@ A forEach will cause side effects, it will be mutating the array being iterated.
<button class="btn"> <button class="btn">
Click me Click me
</button> </button>
```
// if props fit in one line then keep it on the same line 1. The tag can be inline if there is only one attribute:
```javascript
// good
<component bar="bar" /> <component bar="bar" />
// good
<component
bar="bar"
/>
``` ```
#### Quotes #### Quotes
...@@ -381,9 +389,12 @@ A forEach will cause side effects, it will be mutating the array being iterated. ...@@ -381,9 +389,12 @@ A forEach will cause side effects, it will be mutating the array being iterated.
} }
``` ```
1. Default key should always be provided if the prop is not required: 1. Default key should be provided if the prop is not required.
_Note:_ There are some scenarios where we need to check for the existence of the property.
On those a default key should not be provided.
```javascript ```javascript
// bad // good
props: { props: {
foo: { foo: {
type: String, type: String,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment