Merge branch 'features/show-project-id-on-home-panel' into 'master'

Features/show project id on home panel

Closes #46342

See merge request gitlab-org/gitlab-ce!20305

app/views/projects/_home_panel.html.haml

@@ -12,6 +12,9 @@
     .project-home-desc
       - if @project.description.present?
         = markdown_field(@project, :description)
+      - if can?(current_user, :read_project, @project)
+        .text-secondary.prepend-top-8
+          = s_('ProjectPage|Project ID: %{project_id}') % { project_id: @project.id }
 
       - if @project.forked?
         %p

changelogs/unreleased/features-show-project-id-on-home-panel.yml

+---
+title: Show Project ID on project home panel
+merge_request: 20305
+author: Tuğçe Nur Taş
+type: added

locale/gitlab.pot

@@ -4057,6 +4057,9 @@ msgstr ""
 msgid "ProjectLifecycle|Stage"
 msgstr ""
 
+msgid "ProjectPage|Project ID: %{project_id}"
+msgstr ""
+
 msgid "Projects"
 msgstr ""
 

spec/views/projects/_home_panel.html.haml_spec.rb

 require 'spec_helper'
 
 describe 'projects/_home_panel' do
-  let(:group) { create(:group) }
-  let(:project) { create(:project, :public, namespace: group) }
-
-  let(:notification_settings) do
-    user&.notification_settings_for(project)
-  end
+  context 'notifications' do
+    let(:project) { create(:project) }
 
     before do
       assign(:project, project)
-    assign(:notification_setting, notification_settings)
 
       allow(view).to receive(:current_user).and_return(user)
-    allow(view).to receive(:can?).and_return(false)
+      allow(view).to receive(:can?).with(user, :read_project, project).and_return(false)
     end
 
     context 'when user is signed in' do
       let(:user) { create(:user) }
 
+      before do
+        notification_settings = user.notification_settings_for(project)
+        assign(:notification_setting, notification_settings)
+      end
+
       it 'makes it possible to set notification level' do
         render
 
@@ -30,26 +30,19 @@ describe 'projects/_home_panel' do
     context 'when user is signed out' do
       let(:user) { nil }
 
+      before do
+        assign(:notification_setting, nil)
+      end
+
       it 'is not possible to set notification level' do
         render
 
         expect(rendered).not_to have_selector('.notification_dropdown')
       end
     end
-
-  context 'when project' do
-    let!(:user) { create(:user) }
-    let(:badges) { project.badges }
-
-    context 'has no badges' do
-      it 'should not render any badge' do
-        render
-
-        expect(rendered).to have_selector('.project-badges')
-        expect(rendered).not_to have_selector('.project-badges > a')
-      end
   end
 
+  context 'badges' do
     shared_examples 'show badges' do
       it 'should render the all badges' do
         render
@@ -62,7 +55,31 @@ describe 'projects/_home_panel' do
       end
     end
 
+    let(:user) { create(:user) }
+    let(:badges) { project.badges }
+
+    before do
+      assign(:project, project)
+
+      allow(view).to receive(:current_user).and_return(user)
+      allow(view).to receive(:can?).with(user, :read_project, project).and_return(false)
+    end
+
+    context 'has no badges' do
+      let(:project) { create(:project) }
+
+      it 'should not render any badge' do
+        render
+
+        expect(rendered).to have_selector('.project-badges')
+        expect(rendered).not_to have_selector('.project-badges > a')
+      end
+    end
+
     context 'only has group badges' do
+      let(:group) { create(:group) }
+      let(:project) { create(:project, namespace: group) }
+
       before do
         create(:group_badge, group: project.group)
       end
@@ -71,6 +88,8 @@ describe 'projects/_home_panel' do
     end
 
     context 'only has project badges' do
+      let(:project) { create(:project) }
+
       before do
         create(:project_badge, project: project)
       end
@@ -79,6 +98,9 @@ describe 'projects/_home_panel' do
     end
 
     context 'has both group and project badges' do
+      let(:group) { create(:group) }
+      let(:project) { create(:project, namespace: group) }
+
       before do
         create(:project_badge, project: project)
         create(:group_badge, group: project.group)
@@ -87,4 +109,35 @@ describe 'projects/_home_panel' do
       it_behaves_like 'show badges'
     end
   end
+
+  context 'project id' do
+    let(:project) { create(:project) }
+    let(:user) { create(:user) }
+
+    before do
+      assign(:project, project)
+
+      allow(view).to receive(:current_user).and_return(user)
+    end
+
+    context 'user can read project' do
+      it 'is shown' do
+        allow(view).to receive(:can?).with(user, :read_project, project).and_return(true)
+
+        render
+
+        expect(rendered).to have_content("Project ID: #{project.id}")
+      end
+    end
+
+    context 'user cannot read project' do
+      it 'is not shown' do
+        allow(view).to receive(:can?).with(user, :read_project, project).and_return(false)
+
+        render
+
+        expect(rendered).not_to have_content("Project ID: #{project.id}")
+      end
+    end
+  end
 end