Cleanup.

coupler/opc-ua-server/common.h

@@ -4,7 +4,6 @@
 
 #include <sys/time.h>
 #include <stdio.h>
-
 #include <open62541/server.h>
 
 

coupler/opc-ua-server/keep_alive.h

@@ -6,6 +6,7 @@ const int DEFAULT_HEART_BEAT_INTERVAL = 250;
 static int HEART_BEAT_INTERVAL = DEFAULT_HEART_BEAT_INTERVAL;
 
 // the list of couplers onto which we depend for properly running$
+// XXX: assume ONLY 8 couplers!
 unsigned int HEART_BEAT_ID_LIST[] = {0, 0, 0, 0, 0, 0, 0, 0};
 
 // the interval for publishing messages$

coupler/opc-ua-server/mod_io_i2c.h

 // global relay state
 uint8_t I2C_0_RELAYS_STATE = 0; // state of 4 relays at I2C slave 0
 uint8_t I2C_1_RELAYS_STATE = 0; // state of 4 relays at I2C slave 1
-// XXX: what if we have more than 2 MOd-IOs / I2C slaves, we need better structure
 
 // the default addresses of MOD-IOs
 static char *DEFAULT_I2C_0_ADDR = "0x58";
 
 // the list of attached I2C slaves
 const int DEFAULT_I2C_SLAVE_ADDR = 0x58;
-// XXX: make dynamic array
-int I2C_SLAVE_ADDR_LIST[] = {0, 0, 0, 0, 0};
+
+// XXX:code assumes only 8 I2C slaves but it can be more
+int I2C_SLAVE_ADDR_LIST[] = {0, 0, 0, 0, 0, 0, 0, 0};
 
 // the block device at host machine
 static char *DEFAULT_I2C_BLOCK_DEVICE_NAME = "/dev/i2c-1";