Bugfix. Chat wasn't being opened when receiving a message.

spec/chatbox.js

@@ -56,13 +56,14 @@
                     null, ['rosterGroupsFetched'], {},
                     function (done, _converse) {
 
+                var view;
+                test_utils.createContacts(_converse, 'current');
                 test_utils.waitUntilDiscoConfirmed(_converse, 'localhost', [], ['vcard-temp'])
                 .then(function () {
                     return test_utils.waitUntil(function () {
                         return _converse.xmppstatus.get('fullname');
                     }, 300);
                 }).then(function () {
-                    test_utils.createContacts(_converse, 'current');
                     test_utils.openControlBox();
                     expect(_converse.chatboxes.length).toEqual(1);
                     var sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@localhost';
@@ -76,8 +77,12 @@
                         .c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree();
 
                     _converse.chatboxes.onMessage(msg);
-                    var view = _converse.chatboxviews.get(sender_jid);
-                    expect(_.includes($(view.el).find('.chat-msg-author').text(), '**Max Frankfurter')).toBeTruthy();
+                    view = _converse.chatboxviews.get(sender_jid);
+
+                    test_utils.waitUntil(function () {
+                        return u.isVisible(view.el);
+                    }).then(function () {
+                        expect(_.includes(view.el.querySelector('.chat-msg-author').textContent, '**Max Frankfurter')).toBeTruthy();
                         expect($(view.el).find('.chat-msg-content').text()).toBe(' is tired');
 
                         message = '/me is as well';
@@ -86,6 +91,7 @@
                         expect($(view.el).find('.chat-msg-content:last').text()).toBe(' is as well');
                         done();
                     });
+                });
             }));
 
             it("is created when you click on a roster item",
@@ -189,7 +195,7 @@
                 test_utils.createContacts(_converse, 'current');
 
                 var sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@localhost';
-                var chat = _converse.api.chats.open(sender_jid, {
+                var chat = _converse.api.chats.create(sender_jid, {
                     minimized: true
                 });
 

src/converse-chatboxes.js

@@ -367,10 +367,14 @@
                         attrs = jid;
                         jid = attrs.jid;
                     }
-                    jid = jid.toLowerCase();
+                    jid = Strophe.getBareJidFromJid(jid.toLowerCase());
                     attrs.jid = jid;
                     attrs.id = jid;
 
+                    if (!attrs.fullname) {
+                        const roster_item = _converse.roster.get(jid);
+                        attrs.fullname = roster_item.get('fullname');
+                    }
                     let  chatbox = this.get(Strophe.getBareJidFromJid(jid));
                     if (!chatbox && create) {
                         chatbox = this.create(attrs, {

src/converse-chatview.js

@@ -688,6 +688,10 @@
                     return message;
                 },
 
+                shouldShowOnTextMessage () {
+                    return !u.isVisible(this.el);
+                },
+
                 handleTextMessage (message) {
                     this.showMessage(_.clone(message.attributes));
                     if (u.isNewMessage(message)) {
@@ -701,7 +705,11 @@
                             this.showNewMessagesIndicator();
                         }
                     }
+                    if (this.shouldShowOnTextMessage()) {
+                        this.show();
+                    } else {
                         this.scrollDown();
+                    }
                 },
 
                 handleErrorMessage (message) {

src/converse-minimize.js

@@ -116,6 +116,11 @@
                         this.__super__.isNewMessageHidden.apply(this, arguments);
                 },
 
+                shouldShowOnTextMessage () {
+                    return !this.model.get('minimized') &&
+                        this.__super__.shouldShowOnTextMessage.apply(this, arguments);
+                },
+
                 setChatBoxHeight (height) {
                     if (!this.model.get('minimized')) {
                         return this.__super__.setChatBoxHeight.apply(this, arguments);

src/converse-rosterview.js

@@ -691,11 +691,8 @@
                     // assigned to their various groups.
                     _converse.on('rosterGroupsFetched', this.sortAndPositionAllItems.bind(this));
 
-                    // _converse.on('rosterGroupsFetched', this.positionFetchedGroups, this);
                     _converse.on('rosterContactsFetched', () => {
-                        _converse.roster.each((contact) => {
-                            this.addRosterContact(contact, {'silent': true});
-                        });
+                        _converse.roster.each((contact) => this.addRosterContact(contact, {'silent': true}));
                         this.update();
                         this.updateFilter();
                         this.trigger('rosterContactsFetchedAndProcessed');

src/converse-singleton.js

@@ -63,6 +63,10 @@
             },
 
             ChatBoxView: {
+                shouldShowOnTextMessage () {
+                    return false;
+                },
+
                 _show (focus) {
                     /* We only have one chat visible at any one
                      * time. So before opening a chat, we make sure all other