Upgrade pylint configuration

Signed-off-by: Michal Čihař <michal@cihar.com>

.travis.yml

@@ -43,7 +43,7 @@ script:
   - if [ -z "$DO_LINT" ] ; then ./manage.py migrate --settings weblate.settings_test --traceback ; fi
   - if [ -z "$DO_LINT" ] ; then coverage run --source=. ./manage.py test --settings weblate.settings_test $TRAVIS_RUN_TESTS ; fi
   - if [ -n "$DO_LINT" ] ; then pep8 --exclude south_migrations,migrations weblate ; fi
-  - if [ -n "$DO_LINT" ] ; then pylint --reports=n --rcfile=pylint.rc weblate ; fi
+  - if [ -n "$DO_LINT" ] ; then pylint --rcfile=pylint.rc weblate ; fi
   - if [ -n "$DO_LINT" ] ; then pyflakes `find . -name '*.py' -not -name '__init__.py' -not -name 'settings_test_nose.py' -not -name 'settings_test.py'` ; fi
 after_script:
   - coveralls

pylint.rc

 [MASTER]
 
+# Specify a configuration file.
+#rcfile=
+
+# Python code to execute, usually for sys.path manipulation such as
+# pygtk.require().
+#init-hook=
+
 # Profiled execution.
 profile=no
 
@@ -9,39 +16,116 @@ ignore=migrations,south_migrations,settings.py,settings_test.py,settings_test_my
 
 # Pickle collected data for later comparisons.
 persistent=yes
-cache-size=500
+
+# List of plugins (as comma separated values of python modules names) to load,
+# usually to register additional checkers.
 load-plugins=pylint_django
 
+
 [MESSAGES CONTROL]
-# C0111 Missing docstring 
-# I0011 Warning locally suppressed using disable-msg
-# I0012 Warning locally suppressed using disable-msg
-# W0142 Used * or * magic* Used when a function or method is called using *args or **kwargs to dispatch arguments.
-# W0613 Unused argument %r Used when a function or method argument is not used.
-# R0201 Method could be a function
-# E1101 does not work well on metaclasses like Django models or Mechanize browser
-# E1103 does not work with WSGIRequest or file objects
-# W0703 Catching too general exception Exception
-# R0921,R0922 Is raised when abstract classes are used in different module
-# E1002 Produces lot of false positives with Django 1.5
-# R0401(cyclic-import) we have too many of them
-# W1302(bad-format-string) looks like a false positive with PyLint 1.3.0
+
+# Enable the message, report, category or checker with the given id(s). You can
+# either give multiple identifier separated by comma (,) or put this option
+# multiple time. See also the "--disable" option for examples.
+#enable=
+
+# Disable the message, report, category or checker with the given id(s). You
+# can either give multiple identifiers separated by comma (,) or put this
+# option multiple times (only on the command line, not in the configuration
+# file where it should appear only once).You can also use "--disable=all" to
+# disable everything first and then reenable specific checks. For example, if
+# you want to run only the similarities checker, you can use "--disable=all
+# --enable=similarities". If you want to run only the classes checker, but have
+# no Warning level messages displayed, use"--disable=all --enable=classes
+# --disable=W"
 disable=C0111,I0011,I0012,W0142,W0613,W0703,R0201,E1103,E1101,R0401,R0921,R0922,E1002,W1302
 
+
 [REPORTS]
 
 # Set the output format. Available formats are text, parseable, colorized, msvs
-# (visual studio) and html
-#output-format=parseable
+# (visual studio) and html. You can also give a reporter class, eg
+# mypackage.mymodule.MyReporterClass.
+output-format=text
+
+# Put messages in a separate file for each module / package specified on the
+# command line instead of printing them on stdout. Reports (if any) will be
+# written in a file name "pylint_global.[txt|html]".
+files-output=no
+
+# Tells whether to display a full report or only the messages
+reports=no
+
+# Python expression which should return a note less than 10 (10 is the highest
+# note). You have access to the variables errors warning, statement which
+# respectively contain the number of errors / warnings messages and the total
+# number of statements analyzed. This is used by the global evaluation report
+# (RP0004).
+evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10)
+
+# Add a comment according to your evaluation note. This is used by the global
+# evaluation report (RP0004).
+comment=no
+
+# Template used to display messages. This is a python new-style format string
+# used to format the message information. See doc for all details
+msg-template={path}:{line}: [{msg_id}({symbol}), {obj}] {msg}
+
+
+[TYPECHECK]
+
+# Tells whether missing members accessed in mixin class should be ignored. A
+# mixin class is detected if its name ends with "mixin" (case insensitive).
+ignore-mixin-members=yes
+
+# List of module names for which member attributes should not be checked
+# (useful for modules/projects where namespaces are manipulated during runtime
+# and thus extisting member attributes cannot be deduced by static analysis
+ignored-modules=
+
+# List of classes names for which member attributes should not be checked
+# (useful for classes with attributes dynamically set).
+ignored-classes=SQLObject
+
+# When zope mode is activated, add a predefined set of Zope acquired attributes
+# to generated-members.
+zope=no
+
+# List of members which are set dynamically and missed by pylint inference
+# system, and so shouldn't trigger E0201 when accessed. Python regular
+# expressions are accepted.
+generated-members=objects,DoesNotExist,id,pk,_meta,base_fields,context
+
+
+[VARIABLES]
+
+# Tells whether we should check for unused import in __init__ files.
+init-import=no
+
+# A regular expression matching the name of dummy variables (i.e. expectedly
+# not used).
+dummy-variables-rgx=dummy
+
+# List of additional names supposed to be defined in builtins. Remember that
+# you should avoid to define new builtins when possible.
+additional-builtins=
 
-# Include message's id in output
-include-ids=yes
 
 [FORMAT]
 
 # Maximum number of characters on a single line.
 max-line-length=80
 
+# Regexp for a line that is allowed to be longer than the limit.
+ignore-long-lines=^\s*(# )?<?https?://\S+>?$
+
+# Allow the body of an if to be on the same line as the test if there is no
+# else.
+single-line-if-stmt=no
+
+# List of optional constructs for which whitespace checking is disabled
+no-space-check=trailing-comma,dict-separator
+
 # Maximum number of lines in a module
 max-module-lines=1500
 
@@ -49,6 +133,15 @@ max-module-lines=1500
 # tab).
 indent-string='    '
 
+# Number of spaces of indent required inside a hanging or continued line.
+indent-after-paren=4
+
+
+[MISCELLANEOUS]
+
+# List of note tags to take in consideration, separated by a comma.
+notes=FIXME,XXX,TODO
+
 
 [SIMILARITIES]
 
@@ -61,77 +154,123 @@ ignore-comments=yes
 # Ignore docstrings when computing similarities.
 ignore-docstrings=yes
 
+# Ignore imports when computing similarities.
+ignore-imports=no
 
-[VARIABLES]
 
-# Tells whether we should check for unused import in __init__ files.
-init-import=no
+[BASIC]
 
-# A regular expression matching the beginning of the name of dummy variables
-# (i.e. not used).
-dummy-variables-rgx=dummy
+# Required attributes for module, separated by a comma
+required-attributes=
 
-# List of additional names supposed to be defined in builtins. Remember that
-# you should avoid to define new builtins when possible.
-additional-builtins=
+# List of builtins function names that should not be used, separated by a comma
+bad-functions=map,filter,apply,input,file
 
+# Good variable names which should always be accepted, separated by a comma
+good-names=_,i,j,k,e,qs,pk,setUp,tearDown,id
 
-[TYPECHECK]
+# Bad variable names which should always be refused, separated by a comma
+bad-names=foo,bar,baz,toto,tutu,tata
 
-# Tells whether missing members accessed in mixin class should be ignored. A
-# mixin class is detected if its name ends with "mixin" (case insensitive).
-ignore-mixin-members=yes
+# Colon-delimited sets of names that determine each other's naming style when
+# the name regexes allow several styles.
+name-group=
 
-# List of classes names for which member attributes should not be checked
-# (useful for classes with attributes dynamically set).
-ignored-classes=SQLObject
+# Include a hint for the correct naming format with invalid-name
+include-naming-hint=no
 
-# When zope mode is activated, add a predefined set of Zope acquired attributes
-# to generated-members.
-zope=no
+# Regular expression matching correct function names
+function-rgx=[a-zA_][a-zA-Z0-9_]{2,70}$
 
-# List of members which are set dynamically and missed by pylint inference
-# system, and so shouldn't trigger E0201 when accessed. Python regular
-# expressions are accepted.
-generated-members=objects,DoesNotExist,id,pk,_meta,base_fields,context
+# Naming hint for function names
+function-name-hint=[a-z_][a-z0-9_]{2,30}$
 
+# Regular expression matching correct variable names
+variable-rgx=[a-z_][a-z0-9_]{2,30}$
 
-[MISCELLANEOUS]
+# Naming hint for variable names
+variable-name-hint=[a-z_][a-z0-9_]{2,30}$
 
-# List of note tags to take in consideration, separated by a comma.
-notes=FIXME,XXX,TODO
+# Regular expression matching correct constant names
+const-rgx=(([A-Z_][A-Z0-9_]*)|([a-z_][a-z0-9_]*)|(__.*__)|register|urlpatterns)$
 
+# Naming hint for constant names
+const-name-hint=(([A-Z_][A-Z0-9_]*)|(__.*__))$
 
-[BASIC]
+# Regular expression matching correct attribute names
+attr-rgx=[a-z_][a-z0-9_]{2,30}$
 
-# Regular expression which should only match correct module level names
-const-rgx=(([A-Z_][A-Z0-9_]*)|([a-z_][a-z0-9_]*)|(__.*__)|register|urlpatterns)$
+# Naming hint for attribute names
+attr-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct argument names
+argument-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for argument names
+argument-name-hint=[a-z_][a-z0-9_]{2,30}$
 
-# Regular expression which should only match correct class names
+# Regular expression matching correct class attribute names
+class-attribute-rgx=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
+
+# Naming hint for class attribute names
+class-attribute-name-hint=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
+
+# Regular expression matching correct inline iteration names
+inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$
+
+# Naming hint for inline iteration names
+inlinevar-name-hint=[A-Za-z_][A-Za-z0-9_]*$
+
+# Regular expression matching correct class names
 class-rgx=[A-Z_][a-zA-Z0-9_]+$
 
-# Regular expression which should only match correct function names
-function-rgx=[a-zA_][a-zA-Z0-9_]{2,70}$
+# Naming hint for class names
+class-name-hint=[A-Z_][a-zA-Z0-9]+$
+
+# Regular expression matching correct module names
+module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Naming hint for module names
+module-name-hint=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
 
-# Regular expression which should only match correct method names
+# Regular expression matching correct method names
 method-rgx=[a-z_][a-zA-Z0-9_]{2,70}$
 
-# Good variable names which should always be accepted, separated by a comma
-good-names=_,i,j,k,e,qs,pk,setUp,tearDown,id
+# Naming hint for method names
+method-name-hint=[a-z_][a-z0-9_]{2,30}$
 
-# Regular expression which should only match functions or classes name which do
-# not require a docstring
+# Regular expression which should only match function or class names that do
+# not require a docstring.
 no-docstring-rgx=__.*__|_.*
 
+# Minimum line length for functions/classes that require docstrings, shorter
+# ones are exempt.
+docstring-min-length=-1
 
-[CLASSES]
 
+[LOGGING]
 
+# Logging modules to check that the string format arguments are in logging
+# function parameter format
+logging-modules=logging
 
 
+[IMPORTS]
 
-# List of method names used to declare (i.e. assign) instance attributes.
-defining-attr-methods=__init__,__new__,setUp
+# Deprecated modules which should not be used, separated by a comma
+deprecated-modules=regsub,TERMIOS,Bastion,rexec
+
+# Create a graph of every (i.e. internal and external) dependencies in the
+# given file (report RP0402 must not be disabled)
+import-graph=
+
+# Create a graph of external dependencies in the given file (report RP0402 must
+# not be disabled)
+ext-import-graph=
+
+# Create a graph of internal dependencies in the given file (report RP0402 must
+# not be disabled)
+int-import-graph=
 
 
 [DESIGN]
@@ -139,6 +278,10 @@ defining-attr-methods=__init__,__new__,setUp
 # Maximum number of arguments for function / method
 max-args=10
 
+# Argument names that match this expression will be ignored. Default to name
+# with leading underscore
+ignored-argument-names=_.*
+
 # Maximum number of locals for function / method body
 max-locals=20
 
@@ -146,7 +289,7 @@ max-locals=20
 max-returns=8
 
 # Maximum number of branch for function / method body
-max-branchs=12
+max-branches=12
 
 # Maximum number of statements in function / method body
 max-statements=50
@@ -162,3 +305,26 @@ min-public-methods=0
 
 # Maximum number of public methods for a class (see R0904).
 max-public-methods=110
+
+
+[CLASSES]
+
+# List of interface methods to ignore, separated by a comma. This is used for
+# instance to not check methods defines in Zope's Interface base class.
+ignore-iface-methods=isImplementedBy,deferred,extends,names,namesAndDescriptions,queryDescriptionFor,getBases,getDescriptionFor,getDoc,getName,getTaggedValue,getTaggedValueTags,isEqualOrExtendedBy,setTaggedValue,isImplementedByInstancesOf,adaptWith,is_implemented_by
+
+# List of method names used to declare (i.e. assign) instance attributes.
+defining-attr-methods=__init__,__new__,setUp
+
+# List of valid names for the first argument in a class method.
+valid-classmethod-first-arg=cls
+
+# List of valid names for the first argument in a metaclass class method.
+valid-metaclass-classmethod-first-arg=mcs
+
+
+[EXCEPTIONS]
+
+# Exceptions that will emit a warning when being caught. Defaults to
+# "Exception"
+overgeneral-exceptions=Exception