Merge pull request #373 from floriancargoet/fix/group-show

Fixes #372

Merge pull request #373 from floriancargoet/fix/group-show
Fixes #372
2ede031c · JC Brand · 292d4a1b · 63e3794b · 2ede031c
Commit 2ede031c authored Apr 17, 2015 by JC Brand
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 4 deletions

converse.js converse.js +6 -4

No files found.
--- a/converse.js
+++ b/converse.js
@@ -4003,10 +4003,12 @@
            },

            show: function () {
-                // FIXME: There's a bug here, if show_only_online_users is true
-                // Possible solution, get the group, call _.each and check
-                // showInRoster
-                this.$el.nextUntil('dt').addBack().show();
+                this.$el.show();
+                _.each(this.getAll(), function (contactView) {
+                    if (contactView.model.showInRoster()) {
+                        contactView.$el.show();
+                    }
+                });
            },

            hide: function () {