Show requesting contacts when filtering by chat state.

Also add an initial test case for filtering by chat state.

docs/CHANGES.md

@@ -8,6 +8,7 @@
   to make it the same as the method of `ChatRoomView`. [jcbrand]
 - Render error messages received from the server (for undelivered chat
   messages). [jcbrand]
+- Show requesting contacts when filtering by chat state. [jcbrand]
 
 ## 1.0.3 (2016-06-20)
 

src/converse-rosterview.js

@@ -801,9 +801,20 @@
                     } else {
                         q = q.toLowerCase();
                         if (type === 'state') {
+                            if (this.model.get('name') === HEADER_REQUESTING_CONTACTS) {
+                                // When filtering by chat state, we still want to
+                                // show requesting contacts, even though they don't
+                                // have the state in question.
+                                matches = this.model.contacts.filter(
+                                    function (contact) {
+                                        return utils.contains.not('chat_status', q)(contact) && !contact.get('requesting');
+                                    }
+                                );
+                            } else {
                                 matches = this.model.contacts.filter(
                                     utils.contains.not('chat_status', q)
                                 );
+                            }
                         } else  {
                             matches = this.model.contacts.filter(
                                 utils.contains.not('fullname', q)