Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
converse.js
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
converse.js
Commits
bf611228
Commit
bf611228
authored
May 31, 2015
by
JC Brand
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Avoid trying to retrieve non-existing models. fixes #415
parent
e3f20bf1
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
6 deletions
+9
-6
converse.js
converse.js
+8
-6
docs/CHANGES.rst
docs/CHANGES.rst
+1
-0
No files found.
converse.js
View file @
bf611228
...
...
@@ -3411,17 +3411,19 @@
},
closeAllChatBoxes
:
function
(
include_controlbox
)
{
var
i
,
chatbox
;
// TODO: once Backbone.Overview has been refactored, we should
// be able to call .each on the views themselves.
this
.
model
.
each
(
$
.
proxy
(
function
(
model
)
{
var
ids
=
[];
this
.
model
.
each
(
function
(
model
)
{
var
id
=
model
.
get
(
'
id
'
);
if
(
include_controlbox
||
id
!==
'
controlbox
'
)
{
if
(
this
.
get
(
id
))
{
// Should always resolve, but shit happens
this
.
get
(
id
).
close
();
ids
.
push
(
id
);
}
}
},
this
));
});
ids
.
forEach
(
function
(
id
)
{
var
chatbox
=
this
.
get
(
id
);
if
(
chatbox
)
{
chatbox
.
close
();
}
},
this
);
return
this
;
},
...
...
docs/CHANGES.rst
View file @
bf611228
...
...
@@ -9,6 +9,7 @@ Changelog
* Bugfix. clearSessions during unload event would throw an error when not logged in. [gbonvehi]
* Bugfix. wrong callback argument mapping in XmppStatus initialize: fullname is null [thierrytiti]
* #389 Allow login panel placeholders and roster item 'Name' translations. [gbonvehi]
* #415 closeAllChatBoxes is giving ReferenceError when 2 chats are open [nevcos, jcbrand]
* Add placeholder for "Insert a smiley" translation [thierrytiti]
* Updated French translation [thierrytiti]
* CSS fix: position and width of the div #conversejs [thierrytiti]
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment