Move updateOnlineCount to controlbox, where it belongs.

src/converse-controlbox.js

@@ -323,9 +323,7 @@
 
                 onControlBoxToggleHidden: function () {
                     this.$el.show('fast', function () {
-                        if (converse.rosterview) {
-                            converse.rosterview.updateOnlineCount();
-                        }
+                        converse.controlboxtoggle.updateOnlineCount();
                         utils.refreshWebkit();
                         converse.emit('controlBoxOpened', this);
                     }.bind(this));
@@ -680,6 +678,12 @@
 
                 initialize: function () {
                     this.render();
+                    converse.on('initialized', function () {
+                        converse.roster.on("add", this.updateOnlineCount, this);
+                        converse.roster.on('change', this.updateOnlineCount, this);
+                        converse.roster.on("destroy", this.updateOnlineCount, this);
+                        converse.roster.on("remove", this.updateOnlineCount, this);
+                    }.bind(this));
                 },
 
                 render: function () {
@@ -696,6 +700,14 @@
                     return this;
                 },
 
+                updateOnlineCount: function () {
+                    var $count = this.$('#online-count');
+                    $count.text('('+converse.roster.getNumOnlineContacts()+')');
+                    if (!$count.is(':visible')) {
+                        $count.show();
+                    }
+                },
+
                 hide: function (callback) {
                     this.$el.fadeOut('fast', callback);
                 },

src/converse-rosterview.js

@@ -226,7 +226,6 @@
                      * Debounced so that it doesn't get called for every
                      * contact fetched from browser storage.
                      */
-                    converse.log('updateFilter called!!!!!!');
                     var type = this.filter_view.model.get('filter_type');
                     if (type === 'state') {
                         this.filter(this.filter_view.model.get('chat_state'), type);
@@ -244,16 +243,7 @@
                     delete this.presence_ref;
                 },
 
-                updateOnlineCount: function () {
-                    var $count = $('#online-count');
-                    $count.text('('+converse.roster.getNumOnlineContacts()+')');
-                    if (!$count.is(':visible')) {
-                        $count.show();
-                    }
-                },
-
                 update: _.debounce(function () {
-                    this.updateOnlineCount();
                     if (this.$roster.parent().length === 0) {
                         this.$el.append(this.$roster.show());
                     }