Some refactoring to make plugins easier.

- Refactored sound notification to make it a bit more generic
- Split up onMessage

spec/chatroom.js

@@ -196,7 +196,7 @@
                 test_utils.openChatRoom('lounge', 'localhost', 'dummy');
                 spyOn(converse, 'emit');
                 converse.play_sounds = true;
-                spyOn(converse, 'playNotification');
+                spyOn(converse, 'notifyOfNewMessage');
                 var view = this.chatboxviews.get('lounge@localhost');
                 if (!view.$el.find('.chat-area').length) { view.renderChatArea(); }
                 var text = 'This message will play a sound because it mentions dummy';
@@ -207,7 +207,7 @@
                     type: 'groupchat'
                 }).c('body').t(text);
                 view.onChatRoomMessage(message.nodeTree);
-                expect(converse.playNotification).toHaveBeenCalled();
+                expect(converse.notifyOfNewMessage).toHaveBeenCalled();
 
                 text = "This message won't play a sound";
                 message = $msg({
@@ -217,7 +217,7 @@
                     type: 'groupchat'
                 }).c('body').t(text);
                 view.onChatRoomMessage(message.nodeTree);
-                expect(converse.playNotification, 1);
+                expect(converse.notifyOfNewMessage, 1);
                 converse.play_sounds = false;
 
                 text = "This message won't play a sound because it is sent by dummy";
@@ -228,7 +228,7 @@
                     type: 'groupchat'
                 }).c('body').t(text);
                 view.onChatRoomMessage(message.nodeTree);
-                expect(converse.playNotification, 1);
+                expect(converse.notifyOfNewMessage, 1);
                 converse.play_sounds = false;
             }.bind(converse));
 

src/converse-muc.js

@@ -916,7 +916,7 @@
                     }
                     this.model.createMessage($message, $delay, archive_id);
                     if (!delayed && sender !== this.model.get('nick') && (new RegExp("\\b"+this.model.get('nick')+"\\b")).test(body)) {
-                        converse.playNotification();
+                        converse.notifyOfNewMessage();
                     }
                     if (sender !== this.model.get('nick')) {
                         // We only emit an event if it's not our own message