Commit fc2a0d07 authored by JC Brand's avatar JC Brand

Build improvemnets

* Remove CleanWebpackPlugin
    This pugin would wipe the non-minified files every time `make dist` was called,
    and generally made it more difficult to build only particular files.
* Use order-only prerequisites for the `dist` Make recipe
    This allows more efficient building because order-only prerequisites
    don't force a rebuild of the main recipe.
    https://www.gnu.org/software/make/manual/make.html#Prerequisite-Types
parent 5162f3f6
......@@ -175,8 +175,8 @@ logo/conversejs-filled%.png:: logo/conversejs-filled.svg
src/headless/dist/converse-headless.min.js: src webpack.common.js node_modules @converse/headless
npm run headless
dist:: node_modules src/*
npm run dev && npm run build && make dist/website.css && make dist/website.min.css
dist:: node_modules src/* | dist/converse.js dist/converse.css dist/website.css dist/website.min.css
npm run prod
.PHONY: install
install:: dist
......
......@@ -5,18 +5,9 @@ const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const common = require("./webpack.common.js");
const path = require('path');
const webpack = require('webpack');
const { CleanWebpackPlugin } = require('clean-webpack-plugin');
const { merge} = require("webpack-merge");
module.exports = merge(common, {
output: {
publicPath: ASSET_PATH,
filename: 'converse.min.js',
},
plugins: [
new CleanWebpackPlugin({
cleanStaleWebpackAssets: false // resolves conflict with CopyWebpackPlugin
}),
const plugins = [
new MiniCssExtractPlugin({filename: '../dist/converse.min.css'}),
new CopyWebpackPlugin({
patterns: [
......@@ -34,7 +25,14 @@ module.exports = merge(common, {
new webpack.DefinePlugin({ // This makes it possible for us to safely use env vars on our code
'process.env.ASSET_PATH': JSON.stringify(ASSET_PATH)
})
],
];
module.exports = merge(common, {
plugins,
output: {
publicPath: ASSET_PATH,
filename: 'converse.min.js',
},
mode: "production",
devtool: "source-map",
module: {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment