CyLock: systematic error messages when doing a lock op on NULL

4c5140bc · samaingw · Xavier Thompson · fcb5135e · 4c5140bc
Commit 4c5140bc authored Jan 28, 2020 by samaingw Committed by Xavier Thompson Aug 17, 2020
Show whitespace changes
Inline Side-by-side

Showing with 18 additions and 3 deletions

Cython/Utility/CyObjects.cpp Cython/Utility/CyObjects.cpp +18 -3

No files found.
--- a/Cython/Utility/CyObjects.cpp
+++ b/Cython/Utility/CyObjects.cpp
@@ -125,15 +125,30 @@
    }

    static inline void _Cy_RLOCK(CyObject *op) {
+        if (op != NULL) {
            op->CyObject_RLOCK();
        }
+        else {
+            fprintf(stderr, "ERROR: trying to read lock NULL !\n");
+        }
+    }

    static inline void _Cy_WLOCK(CyObject *op) {
+        if (op != NULL) {
            op->CyObject_WLOCK();
        }
+        else {
+            fprintf(stderr, "ERROR: trying to write lock NULL !\n");
+        }
+    }

    static inline void _Cy_UNLOCK(CyObject *op) {
-        if (op != NULL) op->CyObject_UNLOCK();
+        if (op != NULL) {
+            op->CyObject_UNLOCK();
+        }
+        else {
+            fprintf(stderr, "ERROR: trying to unlock NULL !\n");
+        }
    }

    static inline int _Cy_TRYRLOCK(CyObject *op) {