Skip to content

erp5
erp5
Commit 1fa90034 authored by Gabriel Monnerat's avatar Gabriel Monnerat
6 Browse files
Options

erp5_calendar: Add an interaction to reindex Groups Calendar Assignments when 

the related Calendar Exception gets changed
parent b1f5a740
Show whitespace changes
Inline Side-by-side
Showing with 170 additions and 0 deletions
bt5/erp5_calendar/WorkflowTemplateItem/portal_workflow/group_calendar_interaction_workflow/interactions/calendar_exception_update_related_assignment.xml 0 → 100644
View file @ 1fa90034
<?xml version="1.0"?>
<ZopeData>
<record id="1" aka="AAAAAAAAAAE=">
<pickle>
<global name="InteractionDefinition" module="Products.ERP5.Interaction"/>
</pickle>
<pickle>
<dictionary>
<item>
<key> <string>actbox_category</string> </key>
<value> <string>workflow</string> </value>
</item>
<item>
<key> <string>actbox_name</string> </key>
<value> <string></string> </value>
</item>
<item>
<key> <string>actbox_url</string> </key>
<value> <string></string> </value>
</item>
<item>
<key> <string>activate_script_name</string> </key>
<value>
<tuple/>
</value>
</item>
<item>
<key> <string>after_script_name</string> </key>
<value>
<tuple/>
</value>
</item>
<item>
<key> <string>before_commit_script_name</string> </key>
<value>
<list>
<string>CalendarException_callUpdateRelatedAssignment</string>
</list>
</value>
</item>
<item>
<key> <string>description</string> </key>
<value> <string></string> </value>
</item>
<item>
<key> <string>guard</string> </key>
<value>
<none/>
</value>
</item>
<item>
<key> <string>id</string> </key>
<value> <string>calendar_exception_update_related_assignment</string> </value>
</item>
<item>
<key> <string>method_id</string> </key>
<value>
<list>
<string>_set.*</string>
</list>
</value>
</item>
<item>
<key> <string>once_per_transaction</string> </key>
<value> <int>0</int> </value>
</item>
<item>
<key> <string>portal_type_filter</string> </key>
<value>
<list>
<string>Calendar Exception</string>
</list>
</value>
</item>
<item>
<key> <string>portal_type_group_filter</string> </key>
<value>
<none/>
</value>
</item>
<item>
<key> <string>script_name</string> </key>
<value>
<tuple/>
</value>
</item>
<item>
<key> <string>temporary_document_disallowed</string> </key>
<value> <int>0</int> </value>
</item>
<item>
<key> <string>title</string> </key>
<value> <string></string> </value>
</item>
<item>
<key> <string>trigger_type</string> </key>
<value> <int>2</int> </value>
</item>
</dictionary>
</pickle>
</record>
</ZopeData>
bt5/erp5_calendar/WorkflowTemplateItem/portal_workflow/group_calendar_interaction_workflow/scripts/CalendarException_callUpdateRelatedAssignment.xml 0 → 100644
View file @ 1fa90034
<?xml version="1.0"?>
<ZopeData>
<record id="1" aka="AAAAAAAAAAE=">
<pickle>
<global name="PythonScript" module="Products.PythonScripts.PythonScript"/>
</pickle>
<pickle>
<dictionary>
<item>
<key> <string>Script_magic</string> </key>
<value> <int>3</int> </value>
</item>
<item>
<key> <string>_bind_names</string> </key>
<value>
<object>
<klass>
<global name="NameAssignments" module="Shared.DC.Scripts.Bindings"/>
</klass>
<tuple/>
<state>
<dictionary>
<item>
<key> <string>_asgns</string> </key>
<value>
<dictionary>
<item>
<key> <string>name_container</string> </key>
<value> <string>container</string> </value>
</item>
<item>
<key> <string>name_context</string> </key>
<value> <string>context</string> </value>
</item>
<item>
<key> <string>name_m_self</string> </key>
<value> <string>script</string> </value>
</item>
<item>
<key> <string>name_subpath</string> </key>
<value> <string>traverse_subpath</string> </value>
</item>
</dictionary>
</value>
</item>
</dictionary>
</state>
</object>
</value>
</item>
<item>
<key> <string>_body</string> </key>
<value> <string>group_calendar = state_change["object"].getParentValue().getParentValue()\n
group_calendar.GroupCalendar_updateRelatedAssignment()\n
</string> </value>
</item>
<item>
<key> <string>_params</string> </key>
<value> <string>state_change, **kw</string> </value>
</item>
<item>
<key> <string>id</string> </key>
<value> <string>CalendarException_callUpdateRelatedAssignment</string> </value>
</item>
</dictionary>
</pickle>
</record>
</ZopeData>
  • Gabriel Monnerat @gabriel ·
    Developer

    @jerome This interaction should be enough to update Group Calendar assignment when created or change a Calendar Exception.

    Probably a nice and beautiful unit test is required.

  • Jérome Perrin @jerome ·
    Owner

    @gabriel I sent that other email before seeing this commit. For reference, the email was:

    Interaction is missing on:

    • Calendar Exception._set.* (but be care ful Calendar Exception can also exist as subobjects of Leave Period or Presence Request, we should only take care of the case where they are added in Group Presence Period)
    • Group Presence Request.manage_delObjects for the case of a deleted Calendar Exception

    Another possible improvement here is that these interactions are synchronous, they properly use portal_catalog.searchAndActivate, but the first call to searchAndActivate is also costly and it would be a bit better to activate it as well.

    Probably a nice and beautiful unit test is required.

    Yes, it's required. I feel that the workflow chain is Calendar Exception | group_calendar_interaction_workflow is missing. An unit test would also confirm that.

    I see that interaction workflow was introducted in a79219bb but I do not find the corresponding unit test. Is it also missing ?

    I guess the way to go is to make a merge request for all these calendar reindex interaction workflow problems.

  • Jérome Perrin @jerome

    mentioned in merge request !261 (closed)

     ·

    mentioned in merge request !261 (closed)

    Toggle commit list
  • Jérome Perrin @jerome

    mentioned in merge request !631 (merged)

     ·

    mentioned in merge request !631 (merged)

    Toggle commit list
  • Jérome Perrin @jerome

    mentioned in commit 9bc5eb10

     ·

    mentioned in commit 9bc5eb10

    Toggle commit list
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7