Commit f31de504 authored by Jean-Paul Smets's avatar Jean-Paul Smets

Added comments (TODO) and removed logs.

git-svn-id: https://svn.erp5.org/repos/public/erp5/sandbox/amount_generator@36064 20353a03-c40f-0410-a6d1-a30d3c3de9de
parent 90af6d56
...@@ -40,6 +40,10 @@ class ExplanationCache: ...@@ -40,6 +40,10 @@ class ExplanationCache:
an explanation. It is based on the idea that a value is calculated an explanation. It is based on the idea that a value is calculated
once and once only, as a way to accelerate performance of algorithms once and once only, as a way to accelerate performance of algorithms
related to an explanation. related to an explanation.
TODO:
- implement property explanation calculation
(with parent simulation movements, not only children)
""" """
def __init__(self, explanation): def __init__(self, explanation):
...@@ -172,7 +176,6 @@ class ExplanationCache: ...@@ -172,7 +176,6 @@ class ExplanationCache:
kw['path'] = self.getSimulationPathPatternList() # XXX-JPS Explicit Query is better kw['path'] = self.getSimulationPathPatternList() # XXX-JPS Explicit Query is better
if kw.get('explanation_uid', None) is None: if kw.get('explanation_uid', None) is None:
kw['explanation_uid'] = self.getRootExplanationUidList() kw['explanation_uid'] = self.getRootExplanationUidList()
LOG('getSimulationMovementValueList', 0, repr(kw))
if self.simulation_movement_cache.get(kw_tuple, None) is None: if self.simulation_movement_cache.get(kw_tuple, None) is None:
self.simulation_movement_cache[kw_tuple] = \ self.simulation_movement_cache[kw_tuple] = \
self.portal_catalog(portal_type="Simulation Movement", self.portal_catalog(portal_type="Simulation Movement",
...@@ -207,18 +210,13 @@ class ExplanationCache: ...@@ -207,18 +210,13 @@ class ExplanationCache:
""" """
# Try to return cached value first # Try to return cached value first
new_business_process = self.closure_cache.get(business_path, None) new_business_process = self.closure_cache.get(business_path, None)
LOG('Inside getBusinessPathClosure cache: new_business_process', 0, repr(new_business_process))
if new_business_process is not None: if new_business_process is not None:
LOG('Leaving getBusinessPathClosure new_business_process', 0, repr(new_business_process))
return new_business_process return new_business_process
# Build a list of path patterns which apply to current business_path # Build a list of path patterns which apply to current business_path
path_list = self.getSimulationPathPatternList() path_list = self.getSimulationPathPatternList()
LOG('Inside getBusinessPathClosure path_list', 0, repr(path_list))
path_list = map(lambda x:x[0:-1], path_list) # Remove trailing % path_list = map(lambda x:x[0:-1], path_list) # Remove trailing %
path_set = set() path_set = set()
LOG('Inside getBusinessPathClosure _getExplanationRelatedSimulationMovementValueList', 0, repr(business_path.\
_getExplanationRelatedSimulationMovementValueList(self.explanation)))
for simulation_movement in business_path.\ for simulation_movement in business_path.\
_getExplanationRelatedSimulationMovementValueList(self.explanation): _getExplanationRelatedSimulationMovementValueList(self.explanation):
simulation_path = simulation_movement.getPath() simulation_path = simulation_movement.getPath()
...@@ -239,7 +237,6 @@ class ExplanationCache: ...@@ -239,7 +237,6 @@ class ExplanationCache:
causality_uid=business_path.getUid())) causality_uid=business_path.getUid()))
module = business_process.getPortalObject().business_process_module # XXX-JPS module = business_process.getPortalObject().business_process_module # XXX-JPS
LOG('module', 0, repr(module))
new_business_process = module.newContent(portal_type="Business Process", new_business_process = module.newContent(portal_type="Business Process",
temp_object=True) # XXX-JPS is this really OK with union business processes temp_object=True) # XXX-JPS is this really OK with union business processes
i = 0 i = 0
...@@ -251,7 +248,6 @@ class ExplanationCache: ...@@ -251,7 +248,6 @@ class ExplanationCache:
self.closure_cache[business_path] = new_business_process self.closure_cache[business_path] = new_business_process
self.closure_cache[path_tuple] = new_business_process self.closure_cache[path_tuple] = new_business_process
LOG('Leaving getBusinessPathClosure new_business_process', 0, repr(new_business_process))
return new_business_process return new_business_process
def getUnionBusinessProcess(self): def getUnionBusinessProcess(self):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment