Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
erp5
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
139
Merge Requests
139
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Jobs
Commits
Open sidebar
nexedi
erp5
Commits
f932c89f
Commit
f932c89f
authored
Jan 23, 2020
by
Jérome Perrin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
testSecurity: adjust test_workflow_transition_protection
Only "user action" methods needs a security declaration.
parent
007de00c
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
2 deletions
+3
-2
product/ERP5/tests/testSecurity.py
product/ERP5/tests/testSecurity.py
+3
-2
No files found.
product/ERP5/tests/testSecurity.py
View file @
f932c89f
...
@@ -31,6 +31,7 @@ import unittest
...
@@ -31,6 +31,7 @@ import unittest
from
types
import
MethodType
from
types
import
MethodType
from
Acquisition
import
aq_base
from
Acquisition
import
aq_base
from
Products.ERP5Type.tests.ERP5TypeTestCase
import
ERP5TypeTestCase
from
Products.ERP5Type.tests.ERP5TypeTestCase
import
ERP5TypeTestCase
from
Products.ERP5Type.Core.WorkflowTransition
import
TRIGGER_USER_ACTION
# You can invoke security tests in your favourite collection of business templates
# You can invoke security tests in your favourite collection of business templates
# by using TestSecurityMixin like the following :
# by using TestSecurityMixin like the following :
...
@@ -121,8 +122,8 @@ class TestSecurityMixin(ERP5TypeTestCase):
...
@@ -121,8 +122,8 @@ class TestSecurityMixin(ERP5TypeTestCase):
if
wf
.
__class__
.
__name__
in
[
'InteractionWorkflowDefinition'
,
'Interaction Workflow'
]:
if
wf
.
__class__
.
__name__
in
[
'InteractionWorkflowDefinition'
,
'Interaction Workflow'
]:
continue
continue
for
transition
in
wf
.
getTransitionValueList
():
for
transition
in
wf
.
getTransitionValueList
():
if
transition
.
getTriggerType
()
==
0
:
if
transition
.
getTriggerType
()
!=
TRIGGER_USER_ACTION
:
#
Automatic transition without guard is safe
#
Only user action workflow transitions needs a security definition.
continue
continue
if
not
transition
.
isGuarded
():
if
not
transition
.
isGuarded
():
error_list
.
append
(
'%s/transitions/%s'
%
(
wf
.
getId
(),
transition
.
getId
()))
error_list
.
append
(
'%s/transitions/%s'
%
(
wf
.
getId
(),
transition
.
getId
()))
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment