upgrader: make upgrader pass coding style test
Change upgrader internal API to use
filter_dict instead of
which is a builtin.
Remove a lot of unused code in extensions
The changes were merged into master. The source branch has been removed.
@jerome About the change in API from
filteras argument so I don't really see the point of breaking the API then. More generally, I don't think API should be broken for the sake of fixing such pylint warnings because it is too much of a hassle for developers who have to fix their projects code just for naming sake and making pylint happy.
Thanks for feedback. Generally, you are completely right, but I really wonder if this is "API" that is supposed to be used from "outside" of these scripts.
Base_postCheckConsistencyResultscript which is called only by
ERP5Site_checkUpgraderConsistency. I thought this was something "internal", were we can change both the callers and the callees. If you don't see it this way, I'm happy with keeping
# pylint: disable=redefined-builtin.
ping :) I looked again at these scripts and I feel it was fine to change the parameter to
filter_dict, I'll merge as is if not objections.
mergedToggle commit list