Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5
erp5
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Merge Requests 114
    • Merge Requests 114
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Jobs
  • Commits
  • nexedi
  • erp5erp5
  • Merge Requests
  • !1059

Closed
Opened Feb 21, 2020 by Yusei Tahara@yusei
  • Report abuse
Report abuse

erp5_web_renderjs_ui: Stop using <input type="date"> in search editor.

With <input_type="date"> end users can't explicitly control string representation of Zope DateTime which supports various different kinds of string representations including with or without timezone that causes wrong filtering results as I described in !1053 (closed) and !1058 (closed) .

If search editor provides <input type="text"> for date columns, then end users can control string representation of Zope DateTime the same as xhtml style.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://lab.nexedi.com/yusei/erp5.git erp5js_searcheditor_date_bug2
git checkout -b yusei/erp5-erp5js_searcheditor_date_bug2 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff yusei/erp5-erp5js_searcheditor_date_bug2

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 6
  • Commits 1
  • Changes 1
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: nexedi/erp5!1059
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备14008524号