Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5
erp5
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Merge Requests 114
    • Merge Requests 114
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Jobs
  • Commits
  • nexedi
  • erp5erp5
  • Merge Requests
  • !1163

Open
Opened Jun 19, 2020 by Jérome Perrin@jerome
  • Report abuse
Report abuse

advanced_ecommerce: remove problematic script

This script:

  • redirects with password in URL, which causes password to be in log files and web analytics software
  • uses "immediate reindex"
  • uses manage_setLocalRoles instead of proper roles definitions (so roles are lost when roles are regenerated and other problems)

A more proper way seem to use credential request

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/advance_ecommerce_coding_crimes origin/fix/advance_ecommerce_coding_crimes

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/advance_ecommerce_coding_crimes

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 6
  • Commits 1
  • Pipelines 1
  • Changes 7
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: nexedi/erp5!1163
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备14008524号