Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 140
    • Merge requests 140
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1358

Merged
Created Feb 10, 2021 by Jérome Perrin@jeromeOwner

web_renderjs_ui: don't use manage_FTPget to get page code

  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 2

manage_FTPget is an API to serve the file content to response, it is not suitable to just get the file/page template content like we need here. It was causing issues when running through activities, because timerserver responses does not have the setBase method, but is also wrong because large files are streamed to response directly.

Zope does not really offer an unified API to get the source of page templates or files, except the PrincipiaSearchSource method which it uses for its builtin search engine. It seems suitable to use here as well.

Also add a test for the case where web pages are in a OFS.File, only the case of PageTemplate was covered.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/renderjs_ui_manageFTPget
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7