WIP: simulation: add 'frozen' state in causality workflow for documents that are no longer simulated. (!226) · Merge Requests · nexedi / erp5 · GitLab

WIP: simulation: add 'frozen' state in causality workflow for documents that are no longer simulated.

erp5_base: add frozen state and freeze transition in delivery_causality_workflow.
ERP5/mixin/rule.py: do nothing in _updateSimulation() if causality_state is 'frozen'.

Background :

The purpose I need this is to delete simulation trees (and avoid regeneration of simulation tree of course) for old enough documents whith we no longer want to handle at all. Since the consistency with simulation is tracked by causality_state, I choose it as the place to declare no-longer-simulated. And I choose frozen as the state id and freeze as the transition id and also give Add portal content permission to nobody and Modify portal content permission to Manager only.

But there may be use cases where we simply want to abandon simulation but still wants to modify or add sub documents etc. If so, the id of the new state and the transition should be different (but what ?).

Edited 2017-01-27 05:24:49 UTC

Check out branch

Request to merge no_longer_simulated_state into master (3429 commits behind)

Discussion 3
Commits 2
Changes 11
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved

Toggle discussion

Sebastien Robin

@seb started a discussion on commit 4dccd2dd 2017-01-26 08:58:08 UTC

Last updated by Kazuhiko Shiozaki 2017-01-26 09:00:49 UTC

495	495
496	496	See _updateSimulation for accepted parameters.
497	497	"""
	498	if self.getCausalityState() == self.getPortalFrozenCausalityStateList():
		@seb Sebastien Robin @seb commented 2017-01-26 08:58:08 UTC Developer must be : "in" instead of "==" @kazuhiko Kazuhiko Shiozaki @kazuhiko commented 2017-01-26 09:00:49 UTC Owner Oops, thanks !! Edited 2017-01-26 09:01:02 UTC

@kazuhiko Kazuhiko Shiozaki
@kazuhiko
Added 1 commit:

9873122a - fixup! simulation: add 'frozen' state in causality workflow for documents that a…

2017-01-26 09:00:36 UTC
Added 1 commit:

9873122a - fixup! simulation: add 'frozen' state in causality workflow for documents that a…
Toggle commit list
@romain Romain Courteaud
@romain
Marked this merge request as a Work In Progress
2017-01-26 13:28:50 UTC

Marked this merge request as a Work In Progress

Toggle commit list
@yusei Yusei Tahara
@yusei commented 2017-01-27 05:24:48 UTC

Owner

I think that such a thing should be handled by business process and we should use a different word to say "this document is no longer expandable" because the word "frozen" is already used by business process to say "this simulation movement is no longer editable". Please discuss with @jp .

Please register or sign in to post a comment