Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5
erp5
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Merge Requests 115
    • Merge Requests 115
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Jobs
  • Commits
  • nexedi
  • erp5erp5
  • Merge Requests
  • !250

Open
Opened Apr 05, 2017 by Kazuhiko Shiozaki@kazuhiko
  • Report abuse
Report abuse

cleanup acquisition base categories in categories and properties definition

We no longer use order/delivery category to acquire categories and properties. Having needless acquisition base categories in category/property definition makes accessor slower. Yes, category accessor is slow in ERP5. So I propose to drop order and delivery from acquisition base categories from generic business templates.

One thing I'm still wondering is specialisethat is only used in variation's acquitision base categories. Is it really required ? I think that in getAggeregatedAmountList() usage, specialise is anyway taken into account by asComponent() result and we don't need explicit acquisition in variation base category. At least I find no reason to have specialise only in variation.

/cc @nexedi

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b cleanup_acquisition_base_category origin/cleanup_acquisition_base_category

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff cleanup_acquisition_base_category

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 7
  • Commits 1
  • Changes 57
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: nexedi/erp5!250
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备14008524号