Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 140
    • Merge requests 140
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !276

Merged
Created May 24, 2017 by Nicolas Wavrant@NicolasMaintainer

Fix upgrader activity dependencies

  • Overview 21
  • Commits 7
  • Changes 7

Currently the full-upgrade alarm calls the 3 upgrade-related-alarm's activeSense methods in activities. As activeSense method runs Alarm's methods in activities too, the final activities do not get the good "tag" and "after_tag" values, which creates a lack of depency between them. In consequence, if we are not running the real upgrade (= just activeSense), no need to run post-upgrade's activeSense : indeed, post-upgrade constraints will be run on what are currently installed, and not on the result of the previous steps of the upgrader, which lead to a wrong and misleading consistency check.

This Merge Request intends to fix it by :

  • Adding a "activate_kw" parameter to activeSense method, which allow to configure its internal call to "activate"
  • Improving upgrader to remove the useless calls to activeSense, and properly parameterize activeSense's activity generation
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix-upgrader
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7