Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !382

Closed
Created Sep 08, 2017 by Tomáš Peterka@katomasoContributor
  • Report abuse
Report abuse

[erp5_core] Careful refactoring of Base_edit

  • Overview 62
  • Commits 2
  • Changes 2

Whole @nexedi can be interested in this MR.

Please use "Hide whitespace changes" for the diff because often it is just a change of indentation.

Base_edit in json_style was refactored for correctness and readability. This MR brings those changes back to erp5_core. Full test suite passed on those changes https://nexedijs.erp5.net/#/test_result_module/20170908-EB5B74F

More comments why the refactoring was almost necessary on diffs in the code.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: refactor/base_edit
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7