nexedi / erp5

mentioned in merge request !31

Added 22 commits:

28576e35...5b3dbf8d - 11 commits from branch nexedi:master
684b2c67 - erp5_officejs: spreadsheet_editor improvements
a79f665c - erp5_web_renderjs_ui: .ui-content-fullscreen in gadget_erp5.css added
8f06da6a - erp5_xhtml_style: .ui-content-fullscreen in erp5.css added
5dd5985e - erp5_officejs: fix form
17784d7d - erp5_officejs: disable autosave
f8e049b2 - erp5_officejs: fix synchronization spreadsheet gadget
7d5fc731 - erp5_officejs: update ooffice
21ea8e13 - erp5_officejs: fix search form
911aae0d - erp5_officejs: support text editor for OOoDocuments
33fec7d9 - erp5_officejs: deminimify app.js documenteditor, presentationeditor
7fd8fb56 - erp5_officejs, erp5_xhtml_style: triggerMaximize(), submitContent(), setFillStyl…

Added 16 commits:

7fd8fb56...d8e6e6a4 - 3 commits from branch nexedi:master
af007eef - erp5_officejs: spreadsheet_editor improvements
37d762c3 - erp5_web_renderjs_ui: .ui-content-fullscreen in gadget_erp5.css added
4776ff73 - erp5_xhtml_style: .ui-content-fullscreen in erp5.css added
971c2a61 - erp5_officejs: fix form
5217910c - erp5_officejs: disable autosave
b0196c58 - erp5_officejs: fix synchronization spreadsheet gadget
3ddbe89e - erp5_officejs: update ooffice
178bf5c9 - erp5_officejs: fix search form
ad05877c - erp5_officejs: support text editor for OOoDocuments
2d3e1380 - erp5_officejs: deminimify app.js documenteditor, presentationeditor
b1e8b649 - erp5_officejs, erp5_xhtml_style: triggerMaximize(), triggerSubmit(), setFillStyl…
755071b1 - erp5_officejs: use standart submit buttons in erp5_mode and renderjsui_mode
b48828dd - erp5_officejs: fix for jslint

Title changed from submitContent method in erp5_gadgetfield.js to triggerSubmit method in erp5_gadgetfield.js

Oh, I should have started with this, but thanks for your work. It is working nicely and gives the impression of faster than before.

You introduced a function triggerMaximize and CSS ui-content-fullscreen class to Maximize working space. I could not find the way to maximize neither Text Document Editor and Spreadsheet Document Editor. Is it deactivated on purpose?

Regarding documents types. They are not compatible with ERP5 Documents so far. Is there any plan to add compatibility? If not, could check data format to prevent if OnlyOffice Editors are compatible with the current data and take the necessary action such as a warning or preventing the user from editing it for now?

about maximize button - it's not deactivated. The maximize action is linked to the button "Go to Documents" in the right upper conner of the editor.

OnlyOffice uses its own formats - xlsy, docy, ppty. As for now we have only the binary converter on server side: xlsy<->xlsx, etc. In slapos!20 cloudooo!2 CloudOOO converts yformats in background automatically during the document first opening. These merge requests should be merged for conversion can be used.

Plan for Compatability is (if i correctly understand @jp):

Merge as it is for somebody can try to use. (Currently i'm working on appcache but some files don't want to be cached :(
Create open source version of converter. or may be wait when onlyoffice team public it because they wrote they were going to.

about maximize button - it's not deactivated. The maximize action is linked to the button "Go to Documents" in the right upper conner of the editor.

Do you think it would be possible to add a patch or modify the text "Go to document" to "FullScreen" ?

In slapos!20 cloudooo!2 CloudOOO converts yformats in background automatically during the document first opening. These merge requests should be merged for conversion can be used.

I'll check with Gabriel about their status.

It would be interesting to check the data format prior to importing it into the editor to avoid edition of documents not manageable by OnlyOffice Editor. This is a sort of backward compatibility feature that would ease spread of OnlyOffice to systems not having the compatible cloudoo. Would this feature be hard to introduce? Maybe at the Gadget Level?

Do you mean - if the user opens x-format document and click on tab "Online Edit" he sees the smth like "Your version of cloudoo does not support convertion to yformat"? About gadget level - i have an idea how to implement for erp5 standart ui. In gadget ui there is a synchronisation, so i have no idea how to do it yet.

Maybe the Gadget could just check the first letters of the data. For spreadsheet it is "XLSY;"

Lets imagine the situation when firstly there is no convertion in cloudoo. User synchronizes the xlsx files with server. As there is no conversion in cloudo - the files will not be converted and edited. Then admin adds support of yformat in cloudoo. User still has the same xlsx files instead of xlsy because xlsx is actual in his cache.

The related issue is synchronisation of readonly documents. If Jio supports the readonly documents synchronisation then we could mark xlsx files as readonly if convertion is not possible.

Convertion of readonly documents is impossilble now - so user will not be able to read readonly document.

I think this 3 issues have 1 decision.

As for the problem of readonly documents. This is a trickier problem... It is not solved in other officeJS apps for now. Lets thinks a bit more about it.

Added 4 commits:

c2269be0 - erp5_officejs: add missed in ad05877c files
93d52acd - erp5_officejs: fix ooeditor action priority, thanks cedric.leninivin
af4cb0f6 - erp5_officejs: add appcaches for ooeditors and change gadget sanboxing to iframe
60d8a150 - erp5_officejs: rename field my_modification_date to your_modification_date, thanks cedric.leninivin

Added 1 commit:

4eba4662 - erp5_oofficejs: "Go to Documents" change to ===

@cedric.leninivin , i made all changes you asked except avoiding edition of documents if converter is not available.

Added 1 commit:

faa65a9e - erp5_officejs: avoiding edit of documents if converter is not available.

@cedric.leninivin , could you please check and merge.

Added 1 commit:

1a9e95bb - erp5_officejs: avoiding edit of documents if converter is not available, thanks @cedric.leninivin

Thanks For all your modification, I'm currently checking. On a side matter, I was wondering where is your repository with your changes for the only office suite?

If i correctly understood what did you mean - https://lab.nexedi.com/bk/erp5.git bk_officejs . I coppied it from popup window after clicking the button "Check out branch" at the right upper corner of this page.

My bad, no, I was mentionned the Only Office code of the editors. I saw you clone their repository https://lab.nexedi.com/bk/DocumentServer, but I did not saw any modification from you in it. Did you modified the editors directly in ERP5?

Sorry, i understood. Really i have some small changes of Document Server which i haven't split into commits. I will try to do it until tomorrow.

Okay, thanks. I reviewed gadget_ooffice.js:

I saw there is a lot of code commented there. Especially the one regarding history. What is the status of this code?
JSLint has 2 errors with unused variables event.
Is there documentation on the configuration to provide to the editor?
for function onError(event) If the error is critical, it should crash the application. I'm thinking we should use "throw error" in a promise that will be caught by parent gadget and transfer until it is displayed by gadget_erp5_js method: displayErrorContent . I'm not familiar with this kind of errors, what is your opinion on this matter?

BTW, I add a branch in ERP5 @erp5-bk_officejs to include small fixes I find like this one @23612ee1

I've added patches for Document Server.

In fact i think gadget_ooffice.js should be fully rewritten because it adds 1 more iframe and uses the iframe communication differed from the communication used in renderjs. In my opinion the component architecture of renderjs is good one so it would be well to use it for features enhancement of onlyoffice.

For collaboration and OLAP purposes we can try to use subgadgets inside foreign technology (in our case: onlyoffice editor). For that we will need the communication transport for linking the parent gadget and subgadget which is inside onlyoffice editor.

Current version of gadget_ooffice.js was done as proof of concept. If in light of the above you think this code should be sanitized now as you wrote i will.

BTW, I add a branch in ERP5 @erp5-bk_officejs to include small fixes I find like this one @23612ee1

Thank you. I pull patch and add master permission for you on bk/erp5, bk/DocumentServer repositories.

I've added patches for Document Server. Thanks

In fact i think gadget_ooffice.js should be fully rewritten because it adds 1 more iframe and uses the iframe communication differed from the communication used in renderjs. In my opinion the component architecture of renderjs is good one so it would be well to use it for features enhancement of onlyoffice.

I see, I understand.

For collaboration and OLAP purposes we can try to use subgadgets inside foreign technology (in our case: onlyoffice editor). For that we will need the communication transport for linking the parent gadget and subgadget which is inside onlyoffice editor.

Good to know for the future

Current version of gadget_ooffice.js was done as proof of concept. If in light of the above you think this code should be sanitized now as you wrote i will.

The current objective is to have people using it in the near future, as I see it, the two element above will need extensive development and the current gadget is enough to start

On a different subject, I tested the updated appcache you made for spreadsheet. It made me discover that there is a quota on chrome on how much data you can have for an app. The limit on chromebook, the size of the appcache for officejs_spreadsheet application is around 100Mb. So on chrome it fails with the following error Application Cache Error event: Failed to commit new cache to storage, would exceed quota . I'll investigate if there is a way around this problem, in the meantime the current appacache is unusable in Chrome. More information can be found here: https://developer.chrome.com/apps/offline_storage

I had this Application Cache Error event when used Chromium. The free space on my ssd was about 300Mb. When free disk space was increased then the appcash sized 22Mb was saved by Chromium successfully.

From the url you've sent is:

Each app can have up to 20% of the shared pool. As an example, if the total available disk space is 60 GB, the shared pool is 20 GB, and the app can have up to 4 GB. This is calculated from 20% (up to 4 GB) of 1/3 (up to 20 GB) of the available disk space (60 GB).

The shared pool can be up to 1/3 of the of available disk space.

So we need about 196Mb*15=2940Mb free disk space. Based on similar calculation you have about 1500Mb free disk space, is it true?

This is not a decision but just an information.

Ahah, you are right, I had 1,2G free. After freeing space, I could cache integraly the 195Mb... So, mmmhhh, we have here a browser specific bug depending on user free disk space... Interesting. This is statement, not a decision.

For the decision, I think we should leave that as a bug in Nexedi ERP5 to begin.

Added 1 commit:

81ab3fcc - erp5_officejs: "Go to Documents" change to === for all locales

Title changed from triggerSubmit method in erp5_gadgetfield.js to OfficeJS: Only Office Integration

Hello, Yesterday Romain pushed commits to master regarding RenderJS and OfficeJS: https://lab.nexedi.cn/nexedi/erp5/commits/master I rebased your work on top of it, and it is working fine. I also commited: 10f0a21f that fix the error "No setFillStyle method to acquire" when you load ooffice gadget in the backoffice.

Reassigned to @cedric.leninivin

mentioned in merge request cloudooo!2

Is triggerMaximize a way to toggle maximize ? I would expect to have a kind of triggerMaximizeChange (inspired from the native fullscreenchange event).

Or a requestMaximize and leaveMaximize (inspired from the native requestFullScreen method)

Added 1 commit:

64200373 - erp5_office: ooffice: update fomts

Added 298 commits:

64200373...c55a74f0 - 297 commits from branch nexedi:master
2467360b - erp5_officejs: Only Office Integration improvement

Added 1 commit:

1d1381cd - erp5_xhtml_style: triggerMaximize(), triggerSubmit(), setFillStyle() add to erp5_gadgetfield.js

Added 1 commit:

462c85c0 - erp5_officejs: move ooffice_fonts in separate bt erp5_officejs_ooffice_fonts

Added 1 commit:

95135337 - erp5_officejs: move ooffice_fonts in separate bt erp5_officejs_ooffice_fonts

Added 1 commit:

d4a8cf3d - erp5_officejs: intergrate gadget into ooffice, split app part on small files

Added 1 commit:

4218ac97 - erp5_officejs: ooffice: fix appcache and adding new file in gadget mode

Added 2 commits:

b16c395f - erp5_officejs: add serviceworker/jio offline mode
22add6fd - erp5_officejs: disable security and appcache

Added 1 commit:

0028c318 - erp5_officejs: serviceworker download only new changed files

Added 1 commit:

f03ea07e - erp5_officejs: rewrite serviceworker: use files from web_page_module

Added 3 commits:

01176737 - erp5_officejs: use url_string instead of grouping_reference property
a4f9ba19 - erp5_officejs: move ooffice files from portal_skin to web_page_module
6fa5e247 - erp5_ingestion_mysql_innodb_catalog: index url_string in portal_type: Fax, Telep…

Added 2 commits:

dff82cb0 - erp5_ingestion_mysql_innodb_catalog: index url_string in portal_type: Fax, Telep…
6056c96c - erp5_officejs: move ooffice files from portal_skin to web_page_module

Added 1 commit:

3527ccce - erp5_hal_json_style: set sort_on variable default to None

Added 1 commit:

242ef52a - erp5_officejs: add jio_view actions for WebScript WebStyle portal_types

Added 1 commit:

042420e7 - erp5_officejs: add jio_view actions for WebScript WebStyle portal_types

Added 302 commits:

042420e7...8eaf4969 - 289 commits from branch nexedi:master
4ac23f7f - erp5_officejs: Only Office Integration improvement
e36ce693 - erp5_xhtml_style: triggerMaximize(), triggerSubmit(), setFillStyle() add to erp5_gadgetfield.js
f63abd96 - erp5_officejs: move ooffice_fonts in separate bt erp5_officejs_ooffice_fonts
2accbadc - erp5_officejs: intergrate gadget into ooffice, split app part on small files
f27b5fdd - erp5_officejs: ooffice: fix appcache and adding new file in gadget mode
35cebbd0 - erp5_officejs: add serviceworker/jio offline mode
6e7c8be9 - erp5_officejs: disable security and appcache
dc5e6440 - erp5_officejs: serviceworker download only new changed files
bcb5c34e - erp5_officejs: rewrite serviceworker: use files from web_page_module
ad9a20e7 - erp5_officejs: use url_string instead of grouping_reference property
c2203549 - erp5_ingestion_mysql_innodb_catalog: index url_string in portal_type: Fax, Telep…
ca96da3e - erp5_officejs: move ooffice files from portal_skin to web_page_module
cb04f483 - erp5_officejs: add jio_view actions for WebScript WebStyle portal_types

Added 4 commits:

f00dbad5 - erp5_officejs: use url_string instead of grouping_reference property
aaeca911 - erp5_ingestion_mysql_innodb_catalog: index url_string in portal_type: Fax, Telep…
6795c593 - erp5_officejs: move ooffice files from portal_skin to web_page_module
bacd7425 - erp5_officejs: add jio_view actions for WebScript WebStyle portal_types

Added 2 commits:

02541501 - 1 commit from branch nexedi:master
9c0f3464 - erp5_officejs: OnlyOffice integration

Added 1 commit:

4e78ebdd - erp5_officejs: OnlyOffice integration

Added 126 commits:

4e78ebdd...8c90e61c - 125 commits from branch nexedi:master
4e3853bd - erp5_officejs: OnlyOffice integration

Added 1 commit:

09c5fa0e - erp5_ingestion_mysql_innodb_catalog: index url_string in portal_type: Fax, Telep…

Added 1 commit:

1032e833 - erp5_officejs: not complete sync with @cedric.leninivin changes

Added 4 commits:

3b8bb434 - erp5_officejs_ooffice: integrate jio inside ooffice
13f7830d - erp5_officejs_ooffice: new version ooffice
11cf0995 - erp5_officejs: new ooffice version and add presentation app
37b59a92 - erp5_officejs: add excluded and mapped paths in serviceworker

Added 3 commits:

4c205eb1 - erp5_officejs_ooffice: fix font path
53943331 - erp5_officejs: add ooffice_fonts handler in service_worker
dbde6b91 - erp5_officejs: publish officejs_presentation site

Added 1 commit:

06154c63 - erp5_officejs: dirty hack for speedup loading.

Added 1 commit:

430f3245 - erp5_officejs: speedup loading application use only one jio request for *.js files

Added 1 commit:

460fe3fb - erp5_officejs: block runing if application files synchronize

Added 1 commit:

b5e64615 - erp5_officejs: fix list of cached files for ooffice_text

Added 2 commits:

167c9f03 - erp5_officejs: fix jio_configurator
41f8646e - erp5_officejs, erp5_web_renderjs_ui: add setVolatileSetting

Added 3 commits:

9f57e3a0 - Revert "erp5_officejs: speedup loading application use only one jio request for *.js files"
ec26a8da - Revert "erp5_officejs: dirty hack for speedup loading."
72bfe9f6 - erp5_officejs: speedup caching serviceworker

Added 1 commit:

6931b511 - erp5_oofficejs: fix offline mode broken by 460fe3fb

Added 1 commit:

76e443f7 - erp5_officejs: bypass only network error for offline mode.

Added 1 commit:

dc39764d - erp5_officejs: add jio_view action for Presentation portal_type

Added 6 commits:

e781c097 - Revert "erp5_officejs: speedup loading application use only one jio request for *.js files"
6d40cd08 - Revert "erp5_officejs: dirty hack for speedup loading."
118798ce - erp5_officejs: speedup caching serviceworker
00ef5b20 - erp5_oofficejs: fix offline mode broken by 460fe3fb
cacf297b - erp5_officejs: bypass only network error for offline mode.
95248682 - erp5_officejs: add jio_view action for Presentation portal_type

Added 1 commit:

7baa525a - erp5_officejs: add jio_view action for Presentation portal_type

Added 1 commit:

84f6e967 - erp5_officejs: serviceworker correctly handles failed requests thx @cedric.leninivin

Added 1 commit:

373a80da - erp5_officejs: fix list of offline files for oofficejs thx @cedric.leninivin

Added 1 commit:

8dc68d1b - erp5_officejs: Fix Offline application specific resources list

Hello,

About MIME type, I found that "application/x-asc-spreadsheet" was used as debug code [1]. The "asc" is the abbreviation of "Ascencio System" who made OnlyOffice. I like this mime type, also I would use "application/x-asc-text" for text document and "application/x-asc-presentation" for presentation document.

@bk - For information, for non-standard MIME types like for OnlyOffice documents, the minor part should start with "x-" like in "application/x-gzip" for gzipped data or "text/x-go" for go source code. In [2], I see that you used "application/yformat.docy". Can you change these mimetypes to used the "application/x-asc-" version ?

@bk @cedric.leninivin - As I did not find any reference of docy, xlsy and ppty format in the OnlyOffice code, I'm wondering why did we choose such a file extension ?

[1] https://github.com/ONLYOFFICE/core/blob/master/XlsxSerializerCom/Reader/BinaryWriter.h#L3649

[2] https://lab.nexedi.com/bk/erp5/blame/bk_officejs/bt5/erp5_officejs/SkinTemplateItem/portal_skins/erp5_officejs_theme/OOoDocument_convertForJio.py#L23

(I cannot comment your code because your first commit is too long so gitlab answers me with 502)

I also like "application/x-ascoffice-" version.

I found XLSY format in the code (I forgot the -i option in grep), also, XLSY is written in the first bytes of XLSY files.

I updated ERP5 master branch to this latest mimetype: 4453c6c6

@bk: Can you add this commit : https://lab.nexedi.com/vincentB/erp5/commit/ec8507ed999914a5b8e878154a8fea6cd636b9e2

It's from my work on jio, on mapping storage.

so you can find the compiled jio here: https://softinst72175.host.vifib.net/jio/dist/jio-latest.js

@vincentB, have you checked offline mode of officejs application with your changes applied?

As i see, you added jio "mapping" storage and switched off "attachasproperty" storage. They have different functionality, so as a result of this "switching off" the offline mode of officejs application will not work.

i created the "attachasproperty" storage because the jio replication does not support attachments (may be now it's already done?)

Mapping storage has good functionality - to map attachment to specified url . Blob in attachment should have the correct mime type, does mapping storage support this?

Do i correctly understand that current use of mapping storage is to prevent of document Id setting from jio client? If it's true, then how the developers should create js documents if the including this document in certain bt5 determinated by Id?

Added 287 commits:

8dc68d1b...c5f8e57a - 263 commits from branch nexedi:master
19ccd88a - erp5_officejs: OnlyOffice integration
b6781e77 - erp5_ingestion_mysql_innodb_catalog: index url_string in portal_type: Fax, Telep…
69ddede5 - erp5_officejs: not complete sync with @cedric.leninivin changes
e230b039 - erp5_officejs_ooffice: integrate jio inside ooffice
5dbcd23b - erp5_officejs_ooffice: new version ooffice
65ec152b - erp5_officejs: new ooffice version and add presentation app
f94028b1 - erp5_officejs: add excluded and mapped paths in serviceworker
04d8d018 - erp5_officejs_ooffice: fix font path
6f862cfc - erp5_officejs: add ooffice_fonts handler in service_worker
1c4935af - erp5_officejs: publish officejs_presentation site
4243fcb5 - erp5_officejs: dirty hack for speedup loading.
f877aef9 - erp5_officejs: speedup loading application use only one jio request for *.js files
4301cb07 - erp5_officejs: block runing if application files synchronize
34b89fba - erp5_officejs: fix list of cached files for ooffice_text
6104d6ee - Revert "erp5_officejs: speedup loading application use only one jio request for *.js files"
c3f6c238 - Revert "erp5_officejs: dirty hack for speedup loading."
b47ce72f - erp5_officejs: speedup caching serviceworker
abdfbea2 - erp5_oofficejs: fix offline mode broken by 460fe3fb
c00bd821 - erp5_officejs: bypass only network error for offline mode.
bfda50eb - erp5_officejs: serviceworker correctly handles failed requests thx @cedric.leninivin
dce23f60 - erp5_officejs: fix list of offline files for oofficejs thx @cedric.leninivin
6e6a1441 - erp5_officejs_ooffice: add web_page_module/ooffice_apps_common_Analytics_js.js
36a0e330 - erp5_officejs_ooffice: use jio storrage for save document images
3d73f18e - erp5_officejs: change jio_getAttachment and jio_putAttachment for compatability with ooffice

Added 3 commits:

3f73dfb3 - erp5_officejs_ooffice: fix path to fonts
4aaf62f0 - erp5_officejs: gadget_officejs_router_js.js jslint fix
ca23e7f0 - erp5_officejs: fixed error: replication (appresources) is with looses if previou…

Added images support in OnlyOffice documents using get/putAttachment only for local storage, because replication storage doesn't support get/putAttachment.

Founded and fixed bug which leaded to incomplete replication (for offline work) if any previous replication was interrupted.

You can get images from zip like y format, don't you ? If the attachment replication does not work, (assuming synchronising with ERP5) images will be lost in ERP5 or the previous images will still be present ?

What is "ooffice" ? "OpenOffice" or "OnlyOffice" ? OfficeJS might handle OpenOffice documents too.

When I search "ooffice" in google I have "NeoOffice" - "Ooffice docker image" - "github.com/saks/ooffice" and "Microsoft Office"... and an old "ooffice.com" web site.

Can you please rename to "onlyoffice" ?

Added 48 commits:

ca23e7f0...29aa0cc9 - 21 commits from branch nexedi:master
53230878 - erp5_officejs: OnlyOffice integration
aefb0f82 - erp5_ingestion_mysql_innodb_catalog: index url_string in portal_type: Fax, Telep…
6614f78d - erp5_officejs: not complete sync with @cedric.leninivin changes
b30ccffc - erp5_officejs_ooffice: integrate jio inside ooffice
d52dfa24 - erp5_officejs_ooffice: new version ooffice
6b249127 - erp5_officejs: new ooffice version and add presentation app
15f20b2e - erp5_officejs: add excluded and mapped paths in serviceworker
c2ca11d1 - erp5_officejs_ooffice: fix font path
e99eaa38 - erp5_officejs: add ooffice_fonts handler in service_worker
dceca2cd - erp5_officejs: publish officejs_presentation site
041706c1 - erp5_officejs: dirty hack for speedup loading.
3fc2707c - erp5_officejs: speedup loading application use only one jio request for *.js files
9561788f - erp5_officejs: block runing if application files synchronize
65f7c1e1 - erp5_officejs: fix list of cached files for ooffice_text
3984d8f7 - Revert "erp5_officejs: speedup loading application use only one jio request for *.js files"
a2cfa842 - Revert "erp5_officejs: dirty hack for speedup loading."
c62dda3d - erp5_officejs: speedup caching serviceworker
10f48f9f - erp5_oofficejs: fix offline mode broken by 460fe3fb
2d7d4903 - erp5_officejs: bypass only network error for offline mode.
1779a1d5 - erp5_officejs: serviceworker correctly handles failed requests thx @cedric.leninivin
55efa527 - erp5_officejs: fix list of offline files for oofficejs thx @cedric.leninivin
e561a5cf - erp5_officejs_ooffice: add web_page_module/ooffice_apps_common_Analytics_js.js
3a6af188 - erp5_officejs_ooffice: use jio storrage for save document images
883ee908 - erp5_officejs: change jio_getAttachment and jio_putAttachment for compatability with ooffice
8c86c1ff - erp5_officejs_ooffice: fix path to fonts
27029355 - erp5_officejs: gadget_officejs_router_js.js jslint fix
27b2a311 - erp5_officejs: fixed error: replication (appresources) is with looses if previou…

You can get images from zip like y format, don't you ?

Yes, i will make underlayer which will have API getContent for work in classical UI. For that i will use zip archive.

If the attachment replication does not work, (assuming synchronising with ERP5) images will be lost in ERP5 or the previous images will still be present ?

I think i'm not the person who can answer this question. I think @cedric.leninivin may know (or may not :). Cedric works on synchronization of attachments.

What is "ooffice" ? "OpenOffice" or "OnlyOffice" ?

Thank you have drawn attention to this. It's very important topic. In fact i made such name 'ooffice' on purpose to not advertise. Now the situation is changed and converter can be built from sources, so i will add bt5 description with urls . I prefer not to rename business template, but if you and @cedric.leninivin insist on bt5 renaming, i will.

Added 1 commit:

099977e3 - erp5_officejs: fix gadget_officejs_jio_spreadsheet_view_js.js

@bk Yes i test it offline it's work fine.

Added 8 commits:

4afc0ed1 - erp5_officejs_ooffice: cosmetic
c9bfb8e7 - erp5_officejs: cosmetic rename gadget_officejs_jio_spreadsheet_view.js to gadget…
9aece048 - erp5_officejs: serviceworker: compatability with new version jio
327b4585 - erp5_officejs: onlyoffice make compatible with getContent api
a89fe50d - erp5_officejs: add action for editPresentation portal_type documents in OnlyOffice editor
19ad58b6 - erp5_officejs: add landing sites and gadget for OnlyOffice (simpler version appinstaller)
3f6a76c2 - erp5_officejs_ooffice: update comment and description of bt.
4f685585 - erp5_officejs_ooffice: change format onlyoffice documents now it zip file contai…

Added 1 commit:

8de34207 - erp5_officejs: OnlyOffice fix url to landing web_site

Added 1 commit:

d5438f26 - Revert "erp5_officejs: change jio_getAttachment and jio_putAttachment for compat…

I made changes, as @cedric.leninivin asked to support getContent API .

Archiving into zip file is added too, as @tc asked. New format - zip file contains yformat as /body.txt file and related images as files in /media .

For work is nedeed:

jio with 3 branches #bk_for_officejs , #bk_for_seviceworker , #zipfilestorage
for correct work of classical UI additionally needed:
1. time out portal_skins/xhtml_style/renderjs.js should be increase from 5000 to 500000
2. erp5_gadgetfield.js should be taken from https://lab.nexedi.com/snippets/173

To be improved (by myself):

In the document data property the data_url representation of zip archive is saved instead of binary.
The button "save" doesn't work inside only office editors, the erp5/gadget buttons should be used currently.
Images are added to zip archive but can't be deleted from it.
During the first load of OnlyIOffice editors the error appears - it's related to the fact, that not all resources are in web_page_module yet (pictures for buttons, fonts, css). Reloading the page allow to pass the error.

@cedric.leninivin, sometimes subdadget doesn't load, may be it's connected to renderjs@44b646ab .

Added 1 commit:

664e2020 - erp5_officejs: tune login setting for hateoas websection

Added 1 commit:

875c71fa - erp5_officejs: reconnect to serviceworker if window.url is changed

@cedric.leninivin, sometimes subdadget doesn't load, may be it's connected to renderjs@44b646ab .

sorry, that problem was not related to renderjs@44b646ab. It's fixed by 875c71fa - it's very important fix connected to limited lifetime of Service Worker and should be taken in account while creating the installer.

Added 1 commit:

6b3de933 - erp5_officejs: jslint cleanup

Added 148 commits:

6b3de933...5e149355 - 103 commits from branch nexedi:master
11140bd6 - erp5_officejs_connector: Provides independant bt5 to interact with OfficeJS
b741abd2 - erp5_officejs: Provides jIO connector with erp5_officejs_connector bt5
8de86447 - erp5_officejs_connector: Add support for PDF synchronization
7d59754f - erp5_officejs: OnlyOffice integration
fda42363 - erp5_ingestion_mysql_innodb_catalog: index url_string in portal_type: Fax, Telep…
74302ba0 - erp5_officejs: not complete sync with @cedric.leninivin changes
40e6c158 - erp5_officejs_ooffice: integrate jio inside ooffice
d0e251a6 - erp5_officejs_ooffice: new version ooffice
1078028d - erp5_officejs: new ooffice version and add presentation app
55c92d32 - erp5_officejs: add excluded and mapped paths in serviceworker
0a14f651 - erp5_officejs_ooffice: fix font path
fe7e1e82 - erp5_officejs: add ooffice_fonts handler in service_worker
a9cd4ee3 - erp5_officejs: publish officejs_presentation site
9ae4add3 - erp5_officejs: dirty hack for speedup loading.
b3240580 - erp5_officejs: speedup loading application use only one jio request for *.js files
514a097a - erp5_officejs: block runing if application files synchronize
ab2b9d40 - erp5_officejs: fix list of cached files for ooffice_text
bd02080c - Revert "erp5_officejs: speedup loading application use only one jio request for *.js files"
b5ca46fa - Revert "erp5_officejs: dirty hack for speedup loading."
66bc7bea - erp5_officejs: speedup caching serviceworker
2d7bb1db - erp5_oofficejs: fix offline mode broken by 460fe3fb
d82dcad9 - erp5_officejs: bypass only network error for offline mode.
c9814f99 - erp5_officejs: serviceworker correctly handles failed requests thx @cedric.leninivin
75583d1e - erp5_officejs: fix list of offline files for oofficejs thx @cedric.leninivin
da18f539 - erp5_officejs_ooffice: add web_page_module/ooffice_apps_common_Analytics_js.js
024db4fb - erp5_officejs_ooffice: use jio storrage for save document images
b039bec7 - erp5_officejs: change jio_getAttachment and jio_putAttachment for compatability with ooffice
4aa4bfc5 - erp5_officejs_ooffice: fix path to fonts
f7973779 - erp5_officejs: gadget_officejs_router_js.js jslint fix
856de6f0 - erp5_officejs: fixed error: replication (appresources) is with looses if previou…
a7f47553 - erp5_officejs: fix gadget_officejs_jio_spreadsheet_view_js.js
343bd186 - erp5_officejs_ooffice: cosmetic
1c762e96 - erp5_officejs: cosmetic rename gadget_officejs_jio_spreadsheet_view.js to gadget…
bfa7db2e - erp5_officejs: serviceworker: compatability with new version jio
0e3c0c3d - erp5_officejs: onlyoffice make compatible with getContent api
902e7c64 - erp5_officejs: add action for editPresentation portal_type documents in OnlyOffice editor
bc8fac7f - erp5_officejs: add landing sites and gadget for OnlyOffice (simpler version appinstaller)
e808078c - erp5_officejs_ooffice: update comment and description of bt.
ea23a6b4 - erp5_officejs_ooffice: change format onlyoffice documents now it zip file contai…
f65eb7db - erp5_officejs: OnlyOffice fix url to landing web_site
1c85dec3 - Revert "erp5_officejs: change jio_getAttachment and jio_putAttachment for compat…
b4f1b704 - erp5_officejs: tune login setting for hateoas websection
b175dc91 - erp5_officejs: reconnect to serviceworker if window.url is changed
fdc2737c - erp5_officejs: jslint cleanup
3d8f0880 - Merge branch 'cederic_l_master' into bk_officejs

Added 1 commit:

8c55c411 - Merge branch 'cederic_l_master' into bk_officejs

Added 3 commits:

80d5a89e - Merge branch 'cederic_l_master' into bk_officejs
c7647853 - erp5_officejs_connector: add WebPage_viewAsJio/my_url_string
f9435ae1 - erp5_officejs: using MappingStorge thx @vincentB

Added 1 commit:

49a01c56 - erp5_officejs_ooffice: catch and display of document value errors

Added 1 commit:

cbaf6487 - erp5_officejs_connector: OnlyOffice gadget support binary attachment replication…

Added 1 commit:

21b239d9 - erp5_officejs: OnlyOffice support binary replication of document files

Added 110 commits:

21b239d9...80523287 - 109 commits from branch nexedi:master
5b2c8307 - Merge branch 'master' into bk_officejs

Added 1 commit:

3a024a3b - erp5_officejs_ooffice: Improve error catching and informing

Added 2 commits:

627537b4 - erp5_officejs: mv OOoDocument_edit to portal_skins/erp5_officejs_jio_connector/
04a96d9b - erp5_officejs_jio_connector: OnlyOffice use dataUrl as exchange format in classical ui

Added 1 commit:

7a04c780 - erp5_officejs: OnlyOffice gadget repair bulk replication thx @vincentB

Added 1 commit:

48a84fbf - erp5_ingestion_mysql_innodb_catalog: add reference as default value for catalog url_string

Added 1 commit:

78935c32 - erp5_officejs: using of "Base_downloadWithCors" instead of "?format=" during attachment downloading

Wouldn't it be best to do that on the property url_string directly?

No, i think not. If i do that, then the quantity and the frequency of merge conflicts for this branch will increase. So i prefer not to make this change if not sure this change would be merged in next few days.

Added 32 commits:

78935c32...cf3371b3 - 31 commits from branch nexedi:master
90827af3 - Merge branch 'master' into bk_officejs

Added 1 commit:

f6fc6cd1 - erp5_officejs_ooffice: improve error notification for OnlyOffice gadget

Added 1 commit:

288ca3c5 - erp5_officejs: use new version MappingStorage and SignatureStorage

Added 1 commit:

51b61d38 - erp5_officejs: use new version MappingStorage and SignatureStorage

Added 1 commit:

87d0515f - erp5_officejs: OnlyOffice gadget: use separate zipfilestorage-with-jszip.js

Added 12 commits:

16489906 - erp5_officejs: add presentation installer gadget
82b09fe8 - erp5_officejs: add generic installer gadget
006ae32b - erp5_officejs: add codemirror gadget
8509511d - erp5_officejs: add code editor application
47ee7f53 - erp5_officejs: fix add document in codeeditor
92ae5c9c - erp5_core: add cache-manifest to text transform
ee4a9e21 - erp5_ingestion_mysql_innodb_catalog: index url_string in portal_type: Fax, Telep…
e9611c80 - erp5_officejs_ui_test: add service worker installer test
a76679f7 - erp5_officejs: change installer mapping dict
2400c716 - erp5_web_renderjs_ui: add mappingstorage to jio
eea5234c - erp5_officejs: change page names
c6f6267f - Merge branch 'officejs_code_editor' into bk_officejs

Added 1 commit:

f26f409c - erp5_officejs_ooffice: set version = onlyoffice

Added 6 commits:

cf64f37d - erp5_officejs: support multiple versions has been added in application installer
a7617e07 - erp5_officejs: "officejs" version setted for gadget_officejs_* files
296c157f - erp5_officejs: remove OnlyOffice installation from router
ecec5bff - erp5_officejs: files needs for OnlyOffice installation added
4df213e0 - erp5_officejs: OnlyOffice sites changed according to the needs of the app installer
5b9c4b91 - erp5_officejs: zipfilestorage-with-jszip.js move to erp5_officejs_ooffice bt

Added 1 commit:

7736771d - erp5_officejs_ooffice: gadget_onlyoffice_appcache.xml

Added 1 commit:

f42ba103 - erp5_officejs: add officejs_gadget_translation*

Added 1 commit:

9a7fadd9 - erp5_officejs: add officejs_gadget_translation*

Added 98 commits:

9a7fadd9...203a72e1 - 77 commits from branch nexedi:master
7699ba12 - ²erp5_officejs_application: Presentation application bt5
a2f64315 - erp5_officejs_application: Text onlyoffice application
1c79f0e5 - erp5_officejs_application: Spreadsheet OnlyOffice Gadget
c6b01aec - erp5_officejs_application: Spreadsheet OnlyOffice application
332519cd - erp5_officejs_application: Text OnlyOffice Gadget
6f758113 - erp5_officejs_application: Presentation OnlyOffice Application
aa9ad35f - erp5_officejs_application: Text Editor Application
b9baffc8 - erp5_officejs_application: Setting Gadget
905692c8 - erp5_officejs_application: Illustration Editor
d0db0513 - erp5_officejs_application: Trade Application
6e5749ea - erp5_officejs_application: Awesome Free Software Publication List
f5a6849d - erp5_officejs_applicat²ion: Image Editor
db22bee1 - erp5_officejs_application: Web Table Editor
1c79487e - erp5_officejs_application: PDF Viewer
34ad3c7b - erp5_officejs_application: CKEditor Gadget
b041ab7f - erp5_officejs_application: Code Mirror Editor Gadget
941c60ec - erp5_officejs_application: PDF Viewer Gadget
d15d37ed - erp5_officejs_application: Code Editor
0b86043a - erp5_officejs_application: Bookmark manager
c0f30097 - erp5_officejs_application: move and rename application bt
8ef2911c - Merge branch 'vincentB_erp5_officejs_application' into bk_officejs

Added 2 commits:

9ef05039 - erp5_officejs: codeeditor: fix jio_configurator link
73c6e73a - erp5_officejs: codeeditor: fix limit of files

Added 3 commits:

b70095b1 - erp5_officejs: codeeditor: add import/export page
8360833f - erp5_ingestion_mysql_innodb_catalog: index url_string in portal_type Web Manifest
06eb9e4c - erp5_officejs: enable tasty features in codemirror

Added 3 commits:

7f35ac87 - erp5_officejs: dos2unix file convert
f32a81a3 - erp5_officejs: merge with @vincentB work: use jio_view_attachment
73a5fae4 - erp5_officejs_connector: Text, Presentation add jio_view_attachment action

Added 1 commit:

45b9f207 - erp5_officejs: fix wrong url_srings

Added 2 commits:

acc3e142 - erp5_officejs: "Web Manfest" portal_type used for codeeditor_gadget_officejs.appcache
f319e070 - erp5_officejs: import/export: disable button on import and redirect on finish

Added 1 commit:

22cb9663 - erp5_officejs_ooffice: fix "unavailable save state" if save button pressed in not modified document

Added 4 commits:

559c7477 - erp5_officejs: onlyoffice: cleanup landing sites and scripts
144196c6 - erp5_officejs_connector: fix gadget url in online editor form
94cbd2b2 - erp5_officejs_ooffice: fix OnlyOffice work in standalone gadget mode
d7d32573 - erp5_officejs: gadget_officejs_onlyoffice_landing.* moved to erp5_officejs_ooffice

OfficeJS: Only Office Integration

Check out, review, and merge locally