nexedi / erp5

To me it looks good and needed thanks.

Further to this merge request, about:

but it is often forgotten to commit it (as it should be defined explicitely in template_portal_type_base_category_list's bt5 property.

would there be some idea to fix this? Something like a constrain maybe? A Business Template would be inconsistent if it defines a module and does not set this base category? But maybe this is too strict.

erp5_base should do this already

I understood, this is because the script you have been using consider business template containing the module ( as ModuleTemplateItem ) and not the portal type of the module ( PortalTypeTemplateItem with module in group_list ).

This test bt with syncml_test_person_client_module Person Module is maybe the only exceptional case.

I've decided to explicitely add the base category definition in every bt5 where a module is declared, even if the module's portal type is defined somewhere else, because I don't trust the installation process to correctly set the properties when a bt5 overwrites a generic type (ie: in project custom bts).

Normally, the code helper set this category on module creation (https://lab.nexedi.com/nexedi/erp5/blob/master/product/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/ERP5Site_createModule.py#L15), but it is often forgotten to commit it (as it should be defined explicitely in template_portal_type_base_category_list's bt5 property.

• There is no guideline https://www.erp5.com/documentation/developer/guideline/module /cc @frequent

• We could make it an action on business template that also edit the business template to register everything on business template.

There is already an Action "Guess properties of Portal Types" defined on business templates that registers everything on business templates. But it is only useful on module creation, as after it may add properties/actions/whatsoever that were removed on purpose.

I agree to making a guideline. I can see with @frequent to add it after https://www.erp5.com/documentation/developer/guideline/module/erp5-Guideline.Module.Creation/#include-module-local-roles-in-business-template

Hi,

@frequent and me added a new guideline about it : https://www.erp5.com/documentation/developer/guideline/module/erp5-Guideline.Module.Creation/#include-module-base-categories-in-business-template

@frequent and me added a new guideline about it : https://www.erp5.com/documentation/developer/guideline/module/erp5-Guideline.Module.Creation/#include-module-base-categories-in-business-template

Thanks ! I see some small problems with this guideline (I don't know where it's the right place to discuss this):

• formatting is not correct, text from the example is syntax highlighted as python code
  
• instead of bt5 "erp5_foo" declares in its "Base Categories" field in the "Portal Type" view: Foo Module, how about simply sayin bt5 "erp5_foo" does not declare "Base Categories" for the module ? because declaring Foo Module only will cause another error building the bt.
• Guess properties of Portal Types -> the action name is Guess Properties of Portal Types that said. I would not recommend using this action because in most cases it just guess too much.

and I noticed other problems too, maybe we should use a forum for this

Added 1 commit:

• 0311107b - Add the business_application on all modules in which it is missing

I've removed the changes to erp5_syncml_test_data, as discussed in here : !465 (diffs)

mentioned in commit 602abb58

Status changed to merged