Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 141
    • Merge requests 141
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !493

Merged
Created Nov 14, 2017 by Georgios Dagkakis@georgios.dagkakisDeveloper

erp5_calendar: Make Leave Request more user-friendly in parameterisation and appearance.

  • Overview 10
  • Commits 1
  • Changes 31

Follow a simple / non-simple approach, like for Task and its lines.

In default case, user would need only one Leave Request Period, which can be edited directly on LeaveRequest_view. So, in this case, hide the Listbox containing the Leave Request Periods and have default_leave_request_period being created / edited on background, which will acquire quantity, resource, start_date and stop_date from what is set at the view of the Parent.

In case one or more Leave Request Period are added manually, user would get listbox with sub-objects, and editing should be done directly on them, i.e. fields like my_default_leave_request_period_start_date will be disabled from LeaveRequest_view.

Additionally, now Leave Request has it's own:

  • start_date: equal to the minimum start_date of all Leave Request Periods
  • stop_date: equal to the maximum stop_date of all Leave Request Periods

These values are set by interaction on Leave Request Period, triggered on _setStartDate, _setStopDate. This helps so that leave_request_module listbox can have sortable dates.

Commit contains also test that should make it easier to understand.

Test results here

@seb we have talked on this and @cedric.leninivin I know you dealt with Leave Requests. Who else should be notified?

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: leave_request
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7