Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !5

Closed
Created Mar 11, 2015 by Kirill Smelkov@kirrOwner
  • Report abuse
Report abuse

BigFile: Fixes, Tests and on-server Append support (v2+)

  • Overview 4
  • Commits 7
  • Changes

[ this are the same patches as in v2 (see merge request !3 (merged)) but with changed commit sha1 ids so that if we want, we could re-merge after original merge revert (see commit 4f3bb0c9 for details. Original v2 description follow ]

For my current project I needed to rework BigFile interface to support on-server data appension. But while doing so I've discovered in many places current BigFile code could crash and is not working properly. Thus this patch series contain:

  1. fixes for discovered bugs;
  2. support for on-server data append via exposing ._dataAppend(data_chunk) method;
  3. basic tests for BigFile (so that we know fixes are proper and we won't regress on the same things in the future).

Newly introduced BigFile tests were verified to pass on the testrunner:

https://nexedi.erp5.net/test_result_module/20150303-3789A033 https://nexedi.erp5.net/test_result_module/20150303-3789A033/7

NOTE running the whole testsuite failed because of:

  • erp5_test_result:testTaskDistribution failure https://nexedi.erp5.net/test_result_module/20150303-3789A033/23 .

testTaskDistribution is currently failing from time-to-time even on ERP5-MASTER tests, e.g. here https://nexedi.erp5.net/test_result_module/20150226-1F4459D0, so from my point of view that should not be related to BigFile at all.

Please pull.

Thanks beforehand, Kirill


Changes since first pull request (https://lab.nexedi.cn/nexedi/erp5/merge_requests/2)

  • Renamed GET/PUT/CHECK -> get/put/check as per JP comment;
  • Renamed _308 -> R308 as per JP comment;
  • In tabular tests expanded HTTP header names to plain strings, so now shortcuts for their names are not used (as per input from Seb and Romain);
  • Added note for testBigFile_02_DataVarious that it is "called from under testBigFile02_DataVarious driver" (as per question from Jérome).
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: y/bigfile-fixes+append-v2+
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7