Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !622

Merged
Created Apr 03, 2018 by Julien Muchembled@jmOwner

ERP5Form: when editing a FormBox, do not compute the context twice (and wrongly)

  • Overview 5
  • Commits 1
  • Changes 2

This first reverts the following 2 commits: 566c0c5f 3a08c758

to at least fix the issue that the context method takes 2 arguments that aren't available from FormBoxEditor.edit() without slowing things even more.

About deferred style (widget editor objects passed by arguments to activities), the regression in commit a5a2f1cd is solved differently, by customizing the serialization of ERP5 objects into their paths. This would not work with contexes that are temporary objects but there's no known case so far and computing the context twice does not garantee that the result would be the same if the REQUEST is different.

This also removes the unused view() method on editors.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: jm/formbox
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7