Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !691

Merged
Created Jun 11, 2018 by Georgios Dagkakis@georgios.dagkakisDeveloper

Coordinate reachability

  • Overview 12
  • Commits 5
  • Changes 60

This Merge Request adds reachability_workflow and adds it to all Coordinate types (Adress, Email etc.) so that the can be marked as reachable or unreachable. It also adds coordinate_interaction_workflow, so that when a coordinate text changes actions can be triggered. The default behaviour is that, when coordinate text changes for an 'unreachable' Coordinate, it is marked as reachable.

We already discussed this with @jerome , but I cc @nexedi , since this can break compatibility in projects, because in the past Coordinates acquired validation_state by their parent document (Person, Organisation, etc). So now, if some code checks getValidationState (though it should be checking on the parent) for Coordinate, or searches Catalog with validation_state (though it should be parent_validation_state), behaviour will change.

Test Result here seems good (3 failures in UI tests that seem unrelated)

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: coordinate_reachability
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7